Re: [PATCH 0/2] improve code portability

2023-04-03 Thread Tyler Retzlaff
On Mon, Apr 03, 2023 at 06:04:08PM +0100, Bruce Richardson wrote: > On Mon, Apr 03, 2023 at 09:30:22AM -0700, Tyler Retzlaff wrote: > > Improve portability of telemetry code to allow it to be compiled by msvc > > unconditionally. > > > > Remove use of VLA and instead dynamically allocate. MSVC wil

Re: [PATCH 0/2] improve code portability

2023-04-03 Thread Bruce Richardson
On Mon, Apr 03, 2023 at 09:30:22AM -0700, Tyler Retzlaff wrote: > Improve portability of telemetry code to allow it to be compiled by msvc > unconditionally. > > Remove use of VLA and instead dynamically allocate. MSVC will never > implement VLAs due to misuse / security concerns. > > Remove use

[PATCH 0/2] improve code portability

2023-04-03 Thread Tyler Retzlaff
Improve portability of telemetry code to allow it to be compiled by msvc unconditionally. Remove use of VLA and instead dynamically allocate. MSVC will never implement VLAs due to misuse / security concerns. Remove use of ranged based initializer (a gcc extension) instead just explicitly initial