RE: [EXT] Re: [PATCH] test/security: fix buffer leaks in error path

2023-09-19 Thread Akhil Goyal
> On Tue, 22 Aug 2023 23:03:16 +0530 > Akhil Goyal wrote: > > > diff --git a/app/test/test_security_inline_macsec.c > b/app/test/test_security_inline_macsec.c > > index 20670fe5d2..8b57bc51fb 100644 > > --- a/app/test/test_security_inline_macsec.c > > +++ b/app/test/test_security_inline_macsec.c

RE: [EXT] Re: [PATCH] test/security: fix buffer leaks in error path

2023-09-18 Thread Akhil Goyal
> > +#define FREE_PKTS(j, m) { \ > > + while (j--) \ > > + rte_pktmbuf_free(m[j]); \ > > +} > > + > > Changes looks good. However do you want to define a static inline > function here instead of macro? Any specific reason for changing to inline function? In

Re: [PATCH] test/security: fix buffer leaks in error path

2023-08-25 Thread Hemant Agrawal
On 22-Aug-23 11:03 PM, Akhil Goyal wrote: In case of failure of a test in macsec autotest, the buffers were not getting cleaned. Added appropriate code to clean the buffers. Fixes: 993ea577a006 ("test/security: add inline MACsec cases") Cc: sta...@dpdk.org Signed-off-by: Akhil Goyal --- ap

[PATCH] test/security: fix buffer leaks in error path

2023-08-22 Thread Akhil Goyal
In case of failure of a test in macsec autotest, the buffers were not getting cleaned. Added appropriate code to clean the buffers. Fixes: 993ea577a006 ("test/security: add inline MACsec cases") Cc: sta...@dpdk.org Signed-off-by: Akhil Goyal --- app/test/test_security_inline_macsec.c | 70 +