Re: [PATCH] ring: build with global includes

2022-11-22 Thread Tyler Retzlaff
On Tue, Nov 22, 2022 at 09:17:50AM +, Bruce Richardson wrote: > On Tue, Nov 22, 2022 at 09:51:53AM +0100, David Marchand wrote: > > On Mon, Nov 21, 2022 at 11:49 PM Tyler Retzlaff > > wrote: > > > > > > On Mon, Nov 21, 2022 at 10:36:24PM +0100, Thomas Monjalon wrote: > > > > 21/11/2022 22:27,

Re: [PATCH] ring: build with global includes

2022-11-22 Thread Bruce Richardson
On Tue, Nov 22, 2022 at 09:51:53AM +0100, David Marchand wrote: > On Mon, Nov 21, 2022 at 11:49 PM Tyler Retzlaff > wrote: > > > > On Mon, Nov 21, 2022 at 10:36:24PM +0100, Thomas Monjalon wrote: > > > 21/11/2022 22:27, Konstantin Ananyev: > > > > From: Tyler Retzlaff > > > > > e.g. i don't see.

Re: [PATCH] ring: build with global includes

2022-11-22 Thread David Marchand
On Mon, Nov 21, 2022 at 11:49 PM Tyler Retzlaff wrote: > > On Mon, Nov 21, 2022 at 10:36:24PM +0100, Thomas Monjalon wrote: > > 21/11/2022 22:27, Konstantin Ananyev: > > > From: Tyler Retzlaff > > > > e.g. i don't see. > > > > > > > > deps += ['eal'] > > > > > > > > is the dependency on eal the l

Re: [PATCH] ring: build with global includes

2022-11-21 Thread Tyler Retzlaff
On Mon, Nov 21, 2022 at 10:36:24PM +0100, Thomas Monjalon wrote: > 21/11/2022 22:27, Konstantin Ananyev: > > From: Tyler Retzlaff > > > e.g. i don't see. > > > > > > deps += ['eal'] > > > > > > is the dependency on eal the library or just eal headers? because if it > > > is header only it is equ

Re: [PATCH] ring: build with global includes

2022-11-21 Thread Thomas Monjalon
21/11/2022 22:27, Konstantin Ananyev: > From: Tyler Retzlaff > > e.g. i don't see. > > > > deps += ['eal'] > > > > is the dependency on eal the library or just eal headers? because if it > > is header only it is equivalent to telemetry i think? > > rte_ring.c uses bunch of EAL functions: > rte_

RE: [PATCH] ring: build with global includes

2022-11-21 Thread Konstantin Ananyev
> -Original Message- > From: Tyler Retzlaff > Sent: Monday, November 21, 2022 7:53 PM > To: Bruce Richardson > Cc: dev@dpdk.org > Subject: Re: [PATCH] ring: build with global includes > > On Mon, Nov 21, 2022 at 10:31:29AM +, Bruce Richardson wrote: > &

Re: [PATCH] ring: build with global includes

2022-11-21 Thread Tyler Retzlaff
On Mon, Nov 21, 2022 at 10:31:29AM +, Bruce Richardson wrote: > On Fri, Nov 18, 2022 at 03:22:07PM -0800, Tyler Retzlaff wrote: > > ring has no dependencies and should be able to be built standalone but > > cannot be since it cannot find rte_config.h. this change directs meson > > to include gl

Re: [PATCH] ring: build with global includes

2022-11-21 Thread Bruce Richardson
On Fri, Nov 18, 2022 at 03:22:07PM -0800, Tyler Retzlaff wrote: > ring has no dependencies and should be able to be built standalone but > cannot be since it cannot find rte_config.h. this change directs meson > to include global_inc paths just like is done with other libraries > e.g. telemetry. >

[PATCH] ring: build with global includes

2022-11-18 Thread Tyler Retzlaff
Meson include global_inc so that rte_config.h can be found in the include path. Signed-off-by: Tyler Retzlaff --- lib/ring/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/ring/meson.build b/lib/ring/meson.build index c20685c..defd9da 100644 --- a/lib/ring/meson.build +++ b/

[PATCH] ring: build with global includes

2022-11-18 Thread Tyler Retzlaff
ring has no dependencies and should be able to be built standalone but cannot be since it cannot find rte_config.h. this change directs meson to include global_inc paths just like is done with other libraries e.g. telemetry. Tyler Retzlaff (1): ring: build with global includes lib/ring/meson.b