Re: [PATCH] net/vmxnet3: Fix vmxnet3 NULL pointer deref after configuration failure

2024-10-30 Thread Ferruh Yigit
On 10/27/2024 8:43 AM, Morten Brørup wrote: >> From: Roger B Melton [mailto:rmel...@cisco.com] >> Sent: Saturday, 26 October 2024 16.34 >> >> Problem: >> >> If vxmnet3_dev_configure() fails, applications may call >> vmxnet3_dev_close(). If the failure occurs before the vmxnet3 >> hw->shared structu

Re: [PATCH] net/vmxnet3: Fix vmxnet3 NULL pointer deref after configuration failure

2024-10-30 Thread Roger Melton (rmelton)
On 10/30/24 4:28 PM, Roger Melton (rmelton) wrote: > On 10/29/24 11:15 PM, Ferruh Yigit wrote: >> On 10/26/2024 3:33 PM, Roger B Melton wrote: >>> Problem: >>> >>> If vxmnet3_dev_configure() fails, applications may call >>> vmxnet3_dev_close(). If the failure occurs before the vmxnet3 >>> hw->share

Re: [PATCH] net/vmxnet3: Fix vmxnet3 NULL pointer deref after configuration failure

2024-10-30 Thread Roger Melton (rmelton)
On 10/29/24 11:15 PM, Ferruh Yigit wrote: > On 10/26/2024 3:33 PM, Roger B Melton wrote: >> Problem: >> >> If vxmnet3_dev_configure() fails, applications may call >> vmxnet3_dev_close(). If the failure occurs before the vmxnet3 >> hw->shared structure is allocated the close will lead to a segv. >>

Re: [PATCH] net/vmxnet3: Fix vmxnet3 NULL pointer deref after configuration failure

2024-10-29 Thread Ferruh Yigit
On 10/26/2024 3:33 PM, Roger B Melton wrote: > Problem: > > If vxmnet3_dev_configure() fails, applications may call > vmxnet3_dev_close(). If the failure occurs before the vmxnet3 > hw->shared structure is allocated the close will lead to a segv. > > Root Cause: > > This crash is due to incorrec

RE: [PATCH] net/vmxnet3: Fix vmxnet3 NULL pointer deref after configuration failure

2024-10-27 Thread Morten Brørup
> From: Roger B Melton [mailto:rmel...@cisco.com] > Sent: Saturday, 26 October 2024 16.34 > > Problem: > > If vxmnet3_dev_configure() fails, applications may call > vmxnet3_dev_close(). If the failure occurs before the vmxnet3 > hw->shared structure is allocated the close will lead to a segv. >

[PATCH] net/vmxnet3: Fix vmxnet3 NULL pointer deref after configuration failure

2024-10-26 Thread Roger B Melton
Problem: If vxmnet3_dev_configure() fails, applications may call vmxnet3_dev_close(). If the failure occurs before the vmxnet3 hw->shared structure is allocated the close will lead to a segv. Root Cause: This crash is due to incorrect adapter_stopped state in the vmxnet3 dev_private structure. W