RE: [PATCH] net/nfp: add support of UDP fragmentation offload

2024-02-19 Thread Chaoyong He
> On 2/17/2024 1:54 AM, Chaoyong He wrote: > > Add the support of UDP fragmentation offload feature. > > > > Signed-off-by: Chaoyong He > > Reviewed-by: Long Wu > > Reviewed-by: Peng Zhang > > <...> > > > diff --git a/drivers/net/nfp/nfp_net_common.c > > b/drivers/net/nfp/nfp_net_common.c > >

Re: [PATCH] net/nfp: add support of UDP fragmentation offload

2024-02-19 Thread Ferruh Yigit
On 2/17/2024 1:54 AM, Chaoyong He wrote: > Add the support of UDP fragmentation offload feature. > > Signed-off-by: Chaoyong He > Reviewed-by: Long Wu > Reviewed-by: Peng Zhang > Applied to dpdk-next-net/main, thanks.

Re: [PATCH] net/nfp: add support of UDP fragmentation offload

2024-02-19 Thread Ferruh Yigit
On 2/17/2024 1:54 AM, Chaoyong He wrote: > Add the support of UDP fragmentation offload feature. > > Signed-off-by: Chaoyong He > Reviewed-by: Long Wu > Reviewed-by: Peng Zhang <...> > diff --git a/drivers/net/nfp/nfp_net_common.c > b/drivers/net/nfp/nfp_net_common.c > index 72c9a41b00..99c3

Re: [PATCH] net/nfp: add support of UDP fragmentation offload

2024-02-19 Thread Ferruh Yigit
On 2/17/2024 4:47 PM, Stephen Hemminger wrote: > On Sat, 17 Feb 2024 09:54:10 +0800 > Chaoyong He wrote: > >> Add the support of UDP fragmentation offload feature. >> >> Signed-off-by: Chaoyong He >> Reviewed-by: Long Wu >> Reviewed-by: Peng Zhang >> --- >> drivers/common/nfp/nfp_common_ctrl.

Re: [PATCH] net/nfp: add support of UDP fragmentation offload

2024-02-19 Thread Ferruh Yigit
On 2/19/2024 10:26 AM, Bruce Richardson wrote: > On Sun, Feb 18, 2024 at 11:05:35AM +0100, Morten Brørup wrote: >>> From: Stephen Hemminger [mailto:step...@networkplumber.org] >>> Sent: Saturday, 17 February 2024 19.11 >>> >>> On Sat, 17 Feb 2024 19:02:30 +0100 >>> Morten Brørup wrote: >>> No

Re: [PATCH] net/nfp: add support of UDP fragmentation offload

2024-02-19 Thread Bruce Richardson
On Sun, Feb 18, 2024 at 11:05:35AM +0100, Morten Brørup wrote: > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Saturday, 17 February 2024 19.11 > > > > On Sat, 17 Feb 2024 19:02:30 +0100 > > Morten Brørup wrote: > > > > > Not formally... it follows the official DPDK Cod

RE: [PATCH] net/nfp: add support of UDP fragmentation offload

2024-02-18 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Saturday, 17 February 2024 19.11 > > On Sat, 17 Feb 2024 19:02:30 +0100 > Morten Brørup wrote: > > > Not formally... it follows the official DPDK Coding Style [1]. > > > > [1]: > https://doc.dpdk.org/guides/contributing/coding

Re: [PATCH] net/nfp: add support of UDP fragmentation offload

2024-02-17 Thread Stephen Hemminger
On Sat, 17 Feb 2024 19:02:30 +0100 Morten Brørup wrote: > Not formally... it follows the official DPDK Coding Style [1]. > > [1]: https://doc.dpdk.org/guides/contributing/coding_style.html#general > > > Should be: > > > > if ((ol_flags & RTE_MBUF_F_TX_TCP_SEG) == 0 && > > (ol_flags

RE: [PATCH] net/nfp: add support of UDP fragmentation offload

2024-02-17 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Saturday, 17 February 2024 17.47 > > On Sat, 17 Feb 2024 09:54:10 +0800 > Chaoyong He wrote: > > > Add the support of UDP fragmentation offload feature. > > > > Signed-off-by: Chaoyong He > > Reviewed-by: Long Wu > > Reviewe

Re: [PATCH] net/nfp: add support of UDP fragmentation offload

2024-02-17 Thread Stephen Hemminger
On Sat, 17 Feb 2024 09:54:10 +0800 Chaoyong He wrote: > Add the support of UDP fragmentation offload feature. > > Signed-off-by: Chaoyong He > Reviewed-by: Long Wu > Reviewed-by: Peng Zhang > --- > drivers/common/nfp/nfp_common_ctrl.h | 1 + > drivers/net/nfp/nfd3/nfp_nfd3_dp.c | 7 ++-

[PATCH] net/nfp: add support of UDP fragmentation offload

2024-02-16 Thread Chaoyong He
Add the support of UDP fragmentation offload feature. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/common/nfp/nfp_common_ctrl.h | 1 + drivers/net/nfp/nfd3/nfp_nfd3_dp.c | 7 ++- drivers/net/nfp/nfdk/nfp_nfdk_dp.c | 8 +--- drivers/net/nfp/nfp