Re: [PATCH] net/nfb: fix use after free

2024-10-11 Thread Martin Spinler
On Thu, 2024-10-10 at 19:17 +0200, David Marchand wrote: > On Thu, Oct 10, 2024 at 7:16 PM Thomas Monjalon wrote: > > > > With the annotations added to the allocation functions, > > more issues are detected at compilation time: > > > > nfb_rx.c:133:28: error: pointer 'rxq' used after 'rte_free'

Re: [PATCH] net/nfb: fix use after free

2024-10-10 Thread Thomas Monjalon
10/10/2024 19:17, David Marchand: > On Thu, Oct 10, 2024 at 7:16 PM Thomas Monjalon wrote: > > > > With the annotations added to the allocation functions, > > more issues are detected at compilation time: > > > > nfb_rx.c:133:28: error: pointer 'rxq' used after 'rte_free' > > > > It is fixed by mo

Re: [PATCH] net/nfb: fix use after free

2024-10-10 Thread David Marchand
On Thu, Oct 10, 2024 at 7:16 PM Thomas Monjalon wrote: > > With the annotations added to the allocation functions, > more issues are detected at compilation time: > > nfb_rx.c:133:28: error: pointer 'rxq' used after 'rte_free' > > It is fixed by moving the assignment before freeing the parent poin

[PATCH] net/nfb: fix use after free

2024-10-10 Thread Thomas Monjalon
With the annotations added to the allocation functions, more issues are detected at compilation time: nfb_rx.c:133:28: error: pointer 'rxq' used after 'rte_free' It is fixed by moving the assignment before freeing the parent pointer. Fixes: 80da7efbb4c4 ("eal: annotate allocation functions") Si