Re: [PATCH] net/netvsc: fix mtu_set in netvsc devices

2024-07-06 Thread Ferruh Yigit
On 6/28/2024 5:35 PM, Alexander Skorichenko wrote: > Prevent segfault in hn_reinit() caused by changing the MTU for > an incompletely initialized device. > > Signed-off-by: Alexander Skorichenko > Acked-by: Long Li Reviewed-by: Sam Andrew Fixes: 45c83603087e (“net/netvsc: support MTU set”)

RE: [EXTERNAL] Re: [PATCH] net/netvsc: fix mtu_set in netvsc devices

2024-07-03 Thread Long Li
dk.org Subject: RE: [EXTERNAL] Re: [PATCH] net/netvsc: fix mtu_set in netvsc devices Thank you so much, Alexander. I’ve reviewed the patch. It looks good to me as well. Reviewed-by: Sam Andrew mailto:samand...@microsoft.com>> From: Alexander Skorichenko mailto:askoriche...@netgat

RE: [EXTERNAL] Re: [PATCH] net/netvsc: fix mtu_set in netvsc devices

2024-07-03 Thread Sam Andrew
md.com; andrew.rybche...@oktetlabs.ru; Wei Hu ; dev@dpdk.org Subject: [EXTERNAL] Re: [PATCH] net/netvsc: fix mtu_set in netvsc devices You don't often get email from askoriche...@netgate.com<mailto:askoriche...@netgate.com>. Learn why this is important<https://aka.ms/LearnAboutSenderId

Re: [PATCH] net/netvsc: fix mtu_set in netvsc devices

2024-07-03 Thread Alexander Skorichenko
Thanks. >> With this patch, do you see other problems with VPP? No further problems were noticed and MTU can be set to custom values. - Alexander Skorichenko On Wed, Jul 3, 2024 at 2:35 AM Long Li wrote: > Thank you, Alexander. > > > > The patch looks good to me. With this patch, do you see ot

RE: [PATCH] net/netvsc: fix mtu_set in netvsc devices

2024-07-02 Thread Long Li
plumber.org Cc: Sam Andrew ; ferruh.yi...@amd.com; andrew.rybche...@oktetlabs.ru; Long Li ; Wei Hu ; dev@dpdk.org; Matthew Smith Subject: Re: [PATCH] net/netvsc: fix mtu_set in netvsc devices You don't often get email from askoriche...@netgate.com<mailto:askoriche...@netgate.com&

Re: [PATCH] net/netvsc: fix mtu_set in netvsc devices

2024-07-02 Thread Alexander Skorichenko
Hello, The failure happens when running under VPP. In terms of dpdk calls the following sequence of events occurs for a NetVSC device: Durung device probing stage of VPP 1. eth_hn_dev_init() memory for a single primary rx_queue is allocated dev->data->rx_queues[0] = 0, allocated, bu

[PATCH] net/netvsc: fix mtu_set in netvsc devices

2024-06-30 Thread Alexander Skorichenko
Prevent segfault in hn_reinit() caused by changing the MTU for an incompletely initialized device. Signed-off-by: Alexander Skorichenko --- drivers/net/netvsc/hn_ethdev.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/net/netvsc/hn_ethdev.c b/driver