RE: [PATCH] net/iavf: fix checksum offloading

2023-08-22 Thread Zhang, Qi Z
.com; > > sta...@dpdk.org; Wu, Jingjing ; Xing, Beilei > > ; Doherty, Declan ; > > Sinha, Abhijit ; Nicolau, Radu > > > > Subject: Re: [PATCH] net/iavf: fix checksum offloading > > > > On Tue, Aug 22, 2023 at 9:33 AM Zhang, Qi Z wrote: > > > > If

RE: [PATCH] net/iavf: fix checksum offloading

2023-08-22 Thread Zhang, Qi Z
u > Subject: Re: [PATCH] net/iavf: fix checksum offloading > > On Tue, Aug 22, 2023 at 9:33 AM Zhang, Qi Z wrote: > > > If the driver reads l2_len or l3_len, this is an undefined behavior: > > > for example, OVS might have been using l2_len or l3_len for its > >

Re: [PATCH] net/iavf: fix checksum offloading

2023-08-22 Thread David Marchand
On Tue, Aug 22, 2023 at 9:33 AM Zhang, Qi Z wrote: > > If the driver reads l2_len or l3_len, this is an undefined behavior: > > for example, OVS might have been using l2_len or l3_len for its internal > > uses > > (though I agree it would be risky for an application to do so). > > > > We probably

RE: [PATCH] net/iavf: fix checksum offloading

2023-08-22 Thread Zhang, Qi Z
> > To: Zhang, Qi Z > > > Cc: dev@dpdk.org; echau...@redhat.com; m...@redhat.com; > > > sta...@dpdk.org; Wu, Jingjing ; Xing, Beilei > > > ; Doherty, Declan ; > > > Sinha, Abhijit ; Nicolau, Radu > > > > > > Subject: Re: [PATCH] net/iavf

Re: [PATCH] net/iavf: fix checksum offloading

2023-08-21 Thread David Marchand
sta...@dpdk.org; Wu, Jingjing ; Xing, Beilei > > ; Doherty, Declan ; Sinha, > > Abhijit ; Nicolau, Radu > > Subject: Re: [PATCH] net/iavf: fix checksum offloading > > > > On Mon, Aug 21, 2023 at 1:54 PM Zhang, Qi Z wrote: > > > > Subject: [PATCH] net/iavf: fix check

RE: [PATCH] net/iavf: fix checksum offloading

2023-08-21 Thread Zhang, Qi Z
u > Subject: Re: [PATCH] net/iavf: fix checksum offloading > > On Mon, Aug 21, 2023 at 1:54 PM Zhang, Qi Z wrote: > > > Subject: [PATCH] net/iavf: fix checksum offloading > > > > > > The only presence of RTE_MBUF_F_TX_IPV4 can't be used as an > > &

Re: [PATCH] net/iavf: fix checksum offloading

2023-08-21 Thread David Marchand
On Mon, Aug 21, 2023 at 1:54 PM Zhang, Qi Z wrote: > > Subject: [PATCH] net/iavf: fix checksum offloading > > > > The only presence of RTE_MBUF_F_TX_IPV4 can't be used as an indicator that > > a checksum offload has been requested by an application. > >

RE: [PATCH] net/iavf: fix checksum offloading

2023-08-21 Thread Zhang, Qi Z
> -Original Message- > From: David Marchand > Sent: Friday, August 18, 2023 5:04 PM > To: dev@dpdk.org > Cc: echau...@redhat.com; m...@redhat.com; sta...@dpdk.org; Wu, Jingjing > ; Xing, Beilei ; Doherty, Declan > ; Sinha, Abhijit ; Nicolau, > Radu > Sub

Re: [PATCH] net/iavf: fix checksum offloading

2023-08-21 Thread David Marchand
On Mon, Aug 21, 2023 at 10:03 AM Eelco Chaudron wrote: > On 18 Aug 2023, at 11:03, David Marchand wrote: > > > The only presence of RTE_MBUF_F_TX_IPV4 can't be used as an indicator > > that a checksum offload has been requested by an application. > > Check that RTE_MBUF_F_TX_IP_CKSUM or others fla

Re: [PATCH] net/iavf: fix checksum offloading

2023-08-21 Thread Eelco Chaudron
On 18 Aug 2023, at 11:03, David Marchand wrote: > The only presence of RTE_MBUF_F_TX_IPV4 can't be used as an indicator > that a checksum offload has been requested by an application. > Check that RTE_MBUF_F_TX_IP_CKSUM or others flags have been set. > > Fixes: 1e728b01120c ("net/iavf: rework T

[PATCH] net/iavf: fix checksum offloading

2023-08-18 Thread David Marchand
The only presence of RTE_MBUF_F_TX_IPV4 can't be used as an indicator that a checksum offload has been requested by an application. Check that RTE_MBUF_F_TX_IP_CKSUM or others flags have been set. Fixes: 1e728b01120c ("net/iavf: rework Tx path") Cc: sta...@dpdk.org Signed-off-by: David Marchand