Re: [PATCH] net/gve: fix bug in verify driver compatibility

2023-06-02 Thread Rushil Gupta
Thanks for the clarification and for squashing the bug into the main commit. I just tested the net-next branch and it seems to log the right message on the device. On Fri, Jun 2, 2023 at 7:49 AM Ferruh Yigit wrote: > > On 6/1/2023 5:32 PM, Rushil Gupta wrote: > > Thanks for the quick response! >

Re: [PATCH] net/gve: fix bug in verify driver compatibility

2023-06-02 Thread Ferruh Yigit
On 6/1/2023 5:32 PM, Rushil Gupta wrote: > Thanks for the quick response! > Just for my own knowledge, what Junfeng described is the process to > fix the bug if a bug is present in the main dpdk repo? > Correct. As main dpdk repo doesn't rewrite git history, any bug there needs to be fixed with

Re: [PATCH] net/gve: fix bug in verify driver compatibility

2023-06-01 Thread Rushil Gupta
Thanks for the quick response! Just for my own knowledge, what Junfeng described is the process to fix the bug if a bug is present in the main dpdk repo? On Thu, Jun 1, 2023 at 3:24 AM Ferruh Yigit wrote: > > On 6/1/2023 9:26 AM, Ferruh Yigit wrote: > > On 6/1/2023 5:49 AM, Rushil Gupta wrote: >

Re: [PATCH] net/gve: fix bug in verify driver compatibility

2023-06-01 Thread Ferruh Yigit
On 6/1/2023 9:26 AM, Ferruh Yigit wrote: > On 6/1/2023 5:49 AM, Rushil Gupta wrote: >> gVNIC requires physical address to be passed in the adminq command. >> This was initially rightly pointed by ferruh.yigit@. >> Fixed by passing 'driver_info_mem->iova'. >> >> Signed-off-by: Rushil Gupta >> --- >

RE: [PATCH] net/gve: fix bug in verify driver compatibility

2023-06-01 Thread Guo, Junfeng
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, June 1, 2023 16:35 > To: Guo, Junfeng ; Rushil Gupta > ; Zhang, Qi Z > Cc: dev@dpdk.org > Subject: Re: [PATCH] net/gve: fix bug in verify driver compatibility > > On 6/1/2023

Re: [PATCH] net/gve: fix bug in verify driver compatibility

2023-06-01 Thread Ferruh Yigit
On 6/1/2023 7:44 AM, Guo, Junfeng wrote: > > >> -Original Message- >> From: Rushil Gupta >> Sent: Thursday, June 1, 2023 12:50 >> To: Zhang, Qi Z ; ferruh.yi...@amd.com >> Cc: Guo, Junfeng ; dev@dpdk.org; Rushil Gupta >> >> Su

Re: [PATCH] net/gve: fix bug in verify driver compatibility

2023-06-01 Thread Ferruh Yigit
On 6/1/2023 5:49 AM, Rushil Gupta wrote: > gVNIC requires physical address to be passed in the adminq command. > This was initially rightly pointed by ferruh.yigit@. > Fixed by passing 'driver_info_mem->iova'. > > Signed-off-by: Rushil Gupta > --- > drivers/net/gve/gve_ethdev.c | 3 ++- > 1 file

RE: [PATCH] net/gve: fix bug in verify driver compatibility

2023-05-31 Thread Guo, Junfeng
> -Original Message- > From: Rushil Gupta > Sent: Thursday, June 1, 2023 12:50 > To: Zhang, Qi Z ; ferruh.yi...@amd.com > Cc: Guo, Junfeng ; dev@dpdk.org; Rushil Gupta > > Subject: [PATCH] net/gve: fix bug in verify driver compatibility > > gVNIC requires ph

[PATCH] net/gve: fix bug in verify driver compatibility

2023-05-31 Thread Rushil Gupta
gVNIC requires physical address to be passed in the adminq command. This was initially rightly pointed by ferruh.yigit@. Fixed by passing 'driver_info_mem->iova'. Signed-off-by: Rushil Gupta --- drivers/net/gve/gve_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dr

[PATCH] net/gve: fix bug in verify driver compatibility

2023-05-31 Thread Rushil Gupta
gVNIC requires physical address to be passed in the adminq command. This was initially rightly pointed by ferruh.yigit@. Fixed by passing 'driver_info_mem->iova'. Signed-off-by: Rushil Gupta --- drivers/net/gve/gve_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dr