Re: [PATCH] net/gve: Check whether the driver is compatible with the device presented.

2023-05-08 Thread Rushil Gupta
Sounds good. I will document the versioning in a separate patch. For now, the DPDK driver with DQO changes is reported as 1.0.0. I think there is some confusion here. The base code is not coming from the linux kernel driver. Linux kernel driver is in a different repository and it has nothing to do

Re: [PATCH] net/gve: Check whether the driver is compatible with the device presented.

2023-05-08 Thread Ferruh Yigit
On 5/8/2023 7:23 AM, Rushil Gupta wrote: >>> +#ifndef _GVE_VERSION_H_ >>> +#define _GVE_VERSION_H_ >>> + >>> +#include >>> + >>> +#define GVE_VERSION_PREFIX "DPDK-" >>> +#define GVE_VERSION_MAJOR 1 >>> +#define GVE_VERSION_MINOR 0 >>> +#define GVE_VERSION_SUB 0 >>> + >> Is this GVE base version, o

Re: [PATCH] net/gve: Check whether the driver is compatible with the device presented.

2023-05-07 Thread Rushil Gupta
Thanks for reviewing Ferruh Yigit! I wanted to answer your queries before sending the next patch. Please find answers below: On Thu, May 4, 2023 at 8:06 AM Ferruh Yigit wrote: > > On 4/26/2023 10:37 PM, Rushil Gupta wrote: > > Change gve_driver_info fields to report DPDK as OS type and DPDK RTE

Re: [PATCH] net/gve: Check whether the driver is compatible with the device presented.

2023-05-04 Thread Ferruh Yigit
On 4/26/2023 10:37 PM, Rushil Gupta wrote: > Change gve_driver_info fields to report DPDK as OS type and DPDK RTE > version as OS version, reserving driver_version fields for GVE driver > version based on features. > './devtools/check-git-log.sh' is giving some warnings, can you please check them

[PATCH] net/gve: Check whether the driver is compatible with the device presented.

2023-04-26 Thread Rushil Gupta
Change gve_driver_info fields to report DPDK as OS type and DPDK RTE version as OS version, reserving driver_version fields for GVE driver version based on features. Depends-on: series-27687 Signed-off-by: Rushil Gupta Signed-off-by: Joshua Washington Signed-off-by: Junfeng Guo Signed-off-by:

RE: [PATCH] net/gve: Check whether the driver is compatible with the device presented.

2023-04-17 Thread Guo, Junfeng
CH] net/gve: Check whether the driver is compatible > with the device presented. > > On 4/14/2023 10:05 AM, Guo, Junfeng wrote: > > Hi Ferruh, > > > > Here is the summary of the dependency of related patches: > > > > P1: necessary headers update > >

Re: [PATCH] net/gve: Check whether the driver is compatible with the device presented.

2023-04-14 Thread Ferruh Yigit
On 4/14/2023 10:05 AM, Guo, Junfeng wrote: > Hi Ferruh, > > Here is the summary of the dependency of related patches: > > P1: necessary headers update > https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=* > P2: minor update for base code > https://patchwork.dpdk.org/project

RE: [PATCH] net/gve: Check whether the driver is compatible with the device presented.

2023-04-14 Thread Guo, Junfeng
Jeroen de Borst > > Subject: [PATCH] net/gve: Check whether the driver is compatible with > the device presented. > > Change gve_driver_info fields to report DPDK as OS type and DPDK RTE > version as OS version, reserving driver_version fields for GVE driver > version based on fea

[PATCH] net/gve: Check whether the driver is compatible with the device presented.

2023-04-13 Thread Rushil Gupta
Change gve_driver_info fields to report DPDK as OS type and DPDK RTE version as OS version, reserving driver_version fields for GVE driver version based on features. This patch is dependent on https://patchwork.dpdk.org/project/dpdk/list/?series=27687&state=* Signed-off-by: Rushil Gupta Signed