Re: [PATCH] net/failsafe: fix interrupt handle leak

On 8/29/2022 11:23 AM, David Marchand wrote: On Fri, Apr 29, 2022 at 3:56 PM Ferruh Yigit wrote: On 3/24/2022 3:09 PM, David Marchand wrote: A intr_handle is being allocated as a hack to get a (proxy) eventfd from the Linux interrupt implementation. But this handle is never freed. Remove t

Re: [PATCH] net/failsafe: fix interrupt handle leak

On Fri, Apr 29, 2022 at 3:56 PM Ferruh Yigit wrote: > > On 3/24/2022 3:09 PM, David Marchand wrote: > > A intr_handle is being allocated as a hack to get a (proxy) eventfd from > > the Linux interrupt implementation. > > But this handle is never freed. > > > > Remove this convoluted hack and creat

Re: [PATCH] net/failsafe: fix interrupt handle leak

On Fri, Apr 29, 2022 at 4:25 PM David Marchand wrote: > eventfd creation and a intr_handle->nb_intr++, but does nothing on Scratch the part about nb_intr++ :-) I did not re-read before sending. -- David Marchand

Re: [PATCH] net/failsafe: fix interrupt handle leak

Hello Ferruh, On Fri, Apr 29, 2022 at 3:56 PM Ferruh Yigit wrote: > > @@ -442,12 +428,16 @@ fs_rx_queue_setup(struct rte_eth_dev *dev, > > rxq->info.nb_desc = nb_rx_desc; > > rxq->priv = PRIV(dev); > > rxq->sdev = PRIV(dev)->subs; > > - ret = rte_intr_efd_enable(intr_handle,

Re: [PATCH] net/failsafe: fix interrupt handle leak

On 3/24/2022 3:09 PM, David Marchand wrote: A intr_handle is being allocated as a hack to get a (proxy) eventfd from the Linux interrupt implementation. But this handle is never freed. Remove this convoluted hack and create an eventfd in Linux case. Fixes: d61138d4f0e2 ("drivers: remove direct

[PATCH] net/failsafe: fix interrupt handle leak

A intr_handle is being allocated as a hack to get a (proxy) eventfd from the Linux interrupt implementation. But this handle is never freed. Remove this convoluted hack and create an eventfd in Linux case. Fixes: d61138d4f0e2 ("drivers: remove direct access to interrupt handle") Cc: sta...@dpdk.o