Re: [PATCH] net/failsafe: Fix crash due to in-valid sub-device port id

2024-12-12 Thread Stephen Hemminger
On Wed, 7 Dec 2022 17:21:42 + Ferruh Yigit wrote: > On 11/16/2022 12:11 PM, madhuker.myt...@oracle.com wrote: > > From: Madhuker Mythri > > > > Crash occurring while the DPDK secondary processes trying to probe the > > tap-device, where tap-device is a sub-device of Fail-safe device. > > So

Re: [PATCH] net/failsafe: Fix crash due to in-valid sub-device port id

2023-10-17 Thread Stephen Hemminger
On Wed, 7 Dec 2022 17:21:42 + Ferruh Yigit wrote: > This is in the 'FOREACH_SUBDEV()' block, why an invalid subdevice > provided by the macro? > > Instead of invalid port check, should we fix the macro? > > Overall I am not clear why this defect occurs, bugzilla report also > don't have muc

Re: [PATCH] net/failsafe: Fix crash due to in-valid sub-device port id

2022-12-07 Thread Ferruh Yigit
On 11/16/2022 12:11 PM, madhuker.myt...@oracle.com wrote: > From: Madhuker Mythri > > Crash occurring while the DPDK secondary processes trying to probe the > tap-device, where tap-device is a sub-device of Fail-safe device. > Some-times we get in-valid sub-devices(with the in-valid port-id's), >

Re: [PATCH] net/failsafe: Fix crash due to in-valid sub-device port id

2022-11-16 Thread Stephen Hemminger
On Wed, 16 Nov 2022 15:22:24 +0530 madhuker.myt...@oracle.com wrote: > > + if (!rte_eth_dev_is_valid_port(PORT_ID(sdev))) { > + continue; > + } > + Looks ok but DPDK follows kernel style {} is unnecessary on single statement. C

[PATCH] net/failsafe: Fix crash due to in-valid sub-device port id

2022-11-16 Thread madhuker . mythri
From: Madhuker Mythri Crash occurring while the DPDK secondary processes trying to probe the tap-device, where tap-device is a sub-device of Fail-safe device. Some-times we get in-valid sub-devices(with the in-valid port-id's), due to which the IPC communication does not get response and causes t

[PATCH] net/failsafe: Fix crash due to in-valid sub-device port id

2022-11-16 Thread madhuker . mythri
From: Madhuker Mythri Crash occuring while the DPDK secondary processes trying to probe the tap-device, where tap-device is a sub-device of Fail-safe device. Some-times we get in-valid sub-devices(with the in-valid port-id’s and device-names), due to which the IPC communication does not get res