Re: [PATCH] net/enic: avoid extra unlock when setting MTU in enic

2023-11-01 Thread John Daley (johndale)
Reviewed-by: John Daley Thanks, John From: Weiguo Li Date: Wednesday, November 1, 2023 at 12:28 AM To: John Daley (johndale) Cc: dev@dpdk.org , sta...@dpdk.org , Weiguo Li Subject: [PATCH] net/enic: avoid extra unlock when setting MTU in enic The 'set_mtu_done' goto statemen

Re: [PATCH] net/enic: avoid extra unlock when setting MTU in enic

2023-11-01 Thread Ferruh Yigit
On 11/1/2023 7:28 AM, Weiguo Li wrote: > The 'set_mtu_done' goto statement is being executed in a context > where the 'mtu_lock' has not been previously locked. > > To avoid the extra unlocking operation, replace the goto statement > with a return statement. > > Fixes: c3e09182bcd6 ("net/enic: su

[PATCH] net/enic: avoid extra unlock when setting MTU in enic

2023-11-01 Thread Weiguo Li
The 'set_mtu_done' goto statement is being executed in a context where the 'mtu_lock' has not been previously locked. To avoid the extra unlocking operation, replace the goto statement with a return statement. Fixes: c3e09182bcd6 ("net/enic: support scatter Rx in MTU update") Cc: sta...@dpdk.org