RE: [PATCH] net/cpfl: refactor flow parser

2023-11-12 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon > Sent: Monday, November 13, 2023 1:39 AM > To: Qiao, Wenjing ; Zhang, Qi Z > > Cc: Wu, Jingjing ; Xing, Beilei > ; > dev@dpdk.org; Marchand, David > Subject: Re: [PATCH] net/cpfl: refactor flow parser >

Re: [PATCH] net/cpfl: refactor flow parser

2023-11-12 Thread Thomas Monjalon
07/11/2023 09:34, wenjing.q...@intel.com: > From: Wenjing Qiao > > Use strncpy instead of memcpy for string copy and rename macro. I really wonder why memcpy was used for string copy. As you fix it, why not using strlcpy, as recommended by checkpatch? Qi, why do you keep ignoring warnings repor

RE: [PATCH] net/cpfl: refactor flow parser

2023-11-08 Thread Zhang, Qi Z
> -Original Message- > From: wenjing.q...@intel.com > Sent: Tuesday, November 7, 2023 4:35 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; Qiao, Wenjing > Subject: [PATCH] net/cpfl: refactor flow parser > > From: Wenjing Qiao > > Use strncp

[PATCH] net/cpfl: refactor flow parser

2023-11-07 Thread wenjing . qiao
From: Wenjing Qiao Use strncpy instead of memcpy for string copy and rename macro. Coverity issue: 405350 Fixes: 6cc97c9971d7 ("net/cpfl: build action mapping rules from JSON") Signed-off-by: Wenjing Qiao --- drivers/net/cpfl/cpfl_flow_parser.c | 34 +++-- drivers/net/cpfl/cpf