RE: [EXT] Re: [PATCH] mldev: disable build on Windows

2023-03-11 Thread Srikanth Yalavarthi
> -Original Message- > From: Thomas Monjalon > Sent: 11 March 2023 13:42 > To: Tyler Retzlaff ; Stephen Hemminger > > Cc: dev@dpdk.org; David Marchand ; > dev@dpdk.org; Srikanth Yalavarthi > Subject: [EXT] Re: [PATCH] mldev: disable build on Win

Re: [PATCH] mldev: disable build on Windows

2023-03-11 Thread Thomas Monjalon
10/03/2023 23:54, Stephen Hemminger: > On Fri, 10 Mar 2023 12:06:35 -0800 > Tyler Retzlaff wrote: > > > On Fri, Mar 10, 2023 at 10:07:17AM +0100, David Marchand wrote: > > > Caught by UNH lab, Windows compilation is broken because of symbol > > > exports: > > > rte_mldev_exports.def : error LNK20

Re: [PATCH] mldev: disable build on Windows

2023-03-10 Thread Tyler Retzlaff
On Fri, Mar 10, 2023 at 10:07:17AM +0100, David Marchand wrote: > Caught by UNH lab, Windows compilation is broken because of symbol > exports: > rte_mldev_exports.def : error LNK2001: unresolved external symbol > rte_ml_io_bfloat16_to_float32 > rte_mldev_exports.def : error LNK2001: unresolv

Re: [PATCH] mldev: disable build on Windows

2023-03-10 Thread David Marchand
On Fri, Mar 10, 2023 at 10:18 AM Thomas Monjalon wrote: > > The build breaks because of the weak symbols, so we can define this cause: > > Fixes: 9637de38a2e3 ("mldev: add scalar type conversion") I was not 100% sure but it seems the best one yes. > > 10/03/2023 10:07, David Marchand: > > --- a/

Re: [PATCH] mldev: disable build on Windows

2023-03-10 Thread Thomas Monjalon
The build breaks because of the weak symbols, so we can define this cause: Fixes: 9637de38a2e3 ("mldev: add scalar type conversion") 10/03/2023 10:07, David Marchand: > --- a/lib/mldev/meson.build > +++ b/lib/mldev/meson.build > +if is_windows > +subdir_done() > +endif More complete handlin

[PATCH] mldev: disable build on Windows

2023-03-10 Thread David Marchand
Caught by UNH lab, Windows compilation is broken because of symbol exports: rte_mldev_exports.def : error LNK2001: unresolved external symbol rte_ml_io_bfloat16_to_float32 rte_mldev_exports.def : error LNK2001: unresolved external symbol rte_ml_io_float16_to_float32 rte_mldev_export