Re: [PATCH] member: fix PRNG seed reset in NitroSketch mode

2023-07-06 Thread Stephen Hemminger
On Thu, 06 Jul 2023 18:20:19 +0200 Thomas Monjalon wrote: > > > > This raises a more global issue. > > rte_srand() overrides the system seed which is set during startup. > > This is a bad thing, it reduces the entropy in the random number generator. > > > > There are two possible solutions to t

Re: [PATCH] member: fix PRNG seed reset in NitroSketch mode

2023-07-06 Thread Thomas Monjalon
03/07/2023 17:54, Stephen Hemminger: > On Wed, 21 Jun 2023 00:17:20 +0300 > Dmitry Kozlyuk wrote: > > > Seeding the global PRNG at sketch creation > > does not make the sketch operation deterministic: > > it uses rte_rand() later, the PRNG may be seeded again by that point. > > On the other hand,

Re: [PATCH] member: fix PRNG seed reset in NitroSketch mode

2023-07-03 Thread Stephen Hemminger
On Wed, 21 Jun 2023 00:17:20 +0300 Dmitry Kozlyuk wrote: > Seeding the global PRNG at sketch creation > does not make the sketch operation deterministic: > it uses rte_rand() later, the PRNG may be seeded again by that point. > On the other hand, seeding the global PRNG with a hash seed, > is lik

Re: [PATCH] member: fix PRNG seed reset in NitroSketch mode

2023-07-03 Thread Thomas Monjalon
Any comment? 20/06/2023 23:17, Dmitry Kozlyuk: > Sketch creation seeded the global PRNG > using the supplied seed for hashing. > The use of this seed by SKETCH set summary was not documented. > SKETCH set summary does not require two independent hash seeds, > unlike other set summary types. > Seed

[PATCH] member: fix PRNG seed reset in NitroSketch mode

2023-06-20 Thread Dmitry Kozlyuk
Sketch creation seeded the global PRNG using the supplied seed for hashing. The use of this seed by SKETCH set summary was not documented. SKETCH set summary does not require two independent hash seeds, unlike other set summary types. Seeding the global PRNG at sketch creation does not make the ske