Re: [PATCH] lib/hash,lib/rcu: feature hidden key count in hash

2024-03-02 Thread Abdullah Ömer Yamaç
Sorry for the late reply. I understood what you mean. I will create only the reclaim API for the hash library. Thanks for the explanation. On Wed, Feb 28, 2024 at 5:51 PM Honnappa Nagarahalli < honnappa.nagaraha...@arm.com> wrote: > > > > On Feb 28, 2024, at 5:44 AM, Abdullah Ömer Yamaç > wrote:

Re: [PATCH] lib/hash,lib/rcu: feature hidden key count in hash

2024-02-28 Thread Honnappa Nagarahalli
> On Feb 28, 2024, at 5:44 AM, Abdullah Ömer Yamaç wrote: > > While I was implementing the new API, I realized one issue, and it would be > good to discuss it here. First of all rte_rcu_qsbr_dq_reclaim function checks > the state of the qsbr values. It means that all threads should report the

Re: [PATCH] lib/hash,lib/rcu: feature hidden key count in hash

2024-02-28 Thread Abdullah Ömer Yamaç
While I was implementing the new API, I realized one issue, and it would be good to discuss it here. First of all rte_rcu_qsbr_dq_reclaim function checks the state of the qsbr values. It means that all threads should report the quiescent states. It conflicts with my aim. Let's think about below sc

Re: [PATCH] lib/hash,lib/rcu: feature hidden key count in hash

2024-02-22 Thread Honnappa Nagarahalli
> On Feb 22, 2024, at 6:39 AM, Abdullah Ömer Yamaç wrote: > > As a final decision, I will add a new hash API that forces the reclaim. Is it > ok for everyone? Ack from my side > > On Thu, Feb 22, 2024 at 5:37 AM Honnappa Nagarahalli > wrote: > > > > On Feb 21, 2024, at 3:51 PM, Abdullah

Re: [PATCH] lib/hash,lib/rcu: feature hidden key count in hash

2024-02-22 Thread Abdullah Ömer Yamaç
As a final decision, I will add a new hash API that forces the reclaim. Is it ok for everyone? On Thu, Feb 22, 2024 at 5:37 AM Honnappa Nagarahalli < honnappa.nagaraha...@arm.com> wrote: > > > > On Feb 21, 2024, at 3:51 PM, Abdullah Ömer Yamaç > wrote: > > > > > > > > On Wed, Feb 21, 2024 at 6:2

Re: [PATCH] lib/hash,lib/rcu: feature hidden key count in hash

2024-02-21 Thread Honnappa Nagarahalli
> On Feb 21, 2024, at 3:51 PM, Abdullah Ömer Yamaç wrote: > > > > On Wed, Feb 21, 2024 at 6:24 AM Honnappa Nagarahalli > wrote: > > > > On Feb 20, 2024, at 12:58 PM, Abdullah Ömer Yamaç > > wrote: > > > > I appreciate that you gave me suggestions and comments. I will make changes > >

Re: [PATCH] lib/hash,lib/rcu: feature hidden key count in hash

2024-02-21 Thread Abdullah Ömer Yamaç
On Wed, Feb 21, 2024 at 6:24 AM Honnappa Nagarahalli < honnappa.nagaraha...@arm.com> wrote: > > > > On Feb 20, 2024, at 12:58 PM, Abdullah Ömer Yamaç > wrote: > > > > I appreciate that you gave me suggestions and comments. I will make > changes according to all your recommendations, but before th

Re: [PATCH] lib/hash,lib/rcu: feature hidden key count in hash

2024-02-20 Thread Honnappa Nagarahalli
> On Feb 20, 2024, at 12:58 PM, Abdullah Ömer Yamaç > wrote: > > I appreciate that you gave me suggestions and comments. I will make changes > according to all your recommendations, but before that, I want to make > everyone's minds clear. Then, I will apply modifications. > > On Tue, Feb

Re: [PATCH] lib/hash,lib/rcu: feature hidden key count in hash

2024-02-20 Thread Abdullah Ömer Yamaç
I appreciate that you gave me suggestions and comments. I will make changes according to all your recommendations, but before that, I want to make everyone's minds clear. Then, I will apply modifications. On Tue, Feb 20, 2024 at 2:35 AM Honnappa Nagarahalli < honnappa.nagaraha...@arm.com> wrote:

Re: [PATCH] lib/hash,lib/rcu: feature hidden key count in hash

2024-02-19 Thread Honnappa Nagarahalli
> On Feb 19, 2024, at 3:28 PM, Abdullah Ömer Yamaç wrote: > > Hello, > > Let me explain a use case; > > I have a hash table whose key value is IP addresses, and data (let's say the > username of the IP) is related to the IP address. The key point is matching > these data with flows. Flows a

Re: [PATCH] lib/hash,lib/rcu: feature hidden key count in hash

2024-02-19 Thread Abdullah Ömer Yamaç
Hello, Let me explain a use case; I have a hash table whose key value is IP addresses, and data (let's say the username of the IP) is related to the IP address. The key point is matching these data with flows. Flows are dynamic, and this hash table is dynamic, as well; both can change anytime. Fo

Re: [PATCH] lib/hash,lib/rcu: feature hidden key count in hash

2024-02-19 Thread Medvedkin, Vladimir
Hi Abdullah, Could you please tell more about use cases where this API may be useful? a new API to get the hidden key count in the hash table if the rcu qsbr is enabled Here in commit message and down below in doxygen comments, I think this statement should be more specific because rcu can

Re: [PATCH] lib/hash,lib/rcu: feature hidden key count in hash

2024-02-16 Thread Thomas Monjalon
Any review please? 07/02/2024 16:33, Abdullah Ömer Yamaç: > This patch introduce a new API to get the hidden key count in the hash > table if the rcu qsbr is enabled. When using rte_hash_count with rcu > qsbr enabled, it will return the number of elements that are not in the > free queue. Unless

[PATCH] lib/hash,lib/rcu: feature hidden key count in hash

2024-02-07 Thread Abdullah Ömer Yamaç
This patch introduce a new API to get the hidden key count in the hash table if the rcu qsbr is enabled. When using rte_hash_count with rcu qsbr enabled, it will return the number of elements that are not in the free queue. Unless rte_rcu_qsbr_dq_reclaim is called, the number of elements in the def