Re: [PATCH] kni: fix build with Linux 6.3

2023-04-14 Thread Ferruh Yigit
On 3/20/2023 1:01 PM, David Marchand wrote: > On Mon, Mar 20, 2023 at 1:10 PM David Marchand > wrote: >> >> On Tue, Feb 28, 2023 at 9:45 PM David Marchand >> wrote: >>> >>> On Tue, Feb 28, 2023 at 6:29 PM Ferruh Yigit wrote: KNI calls `get_user_pages_remote()` API which is using `FOLL_

Re: [EXT] Re: [PATCH] kni: fix build with Linux 6.3

2023-04-13 Thread David Marchand
On Fri, Mar 24, 2023 at 4:04 AM Vamsi Krishna Attunuru wrote: > > > So I think the dpdk commit e73831dc6c26 ("kni: support userspace VA") > > > uselessly introduced call to this flag and we can remove it. > > > Adding author and reviewers of this change. > > > > Alternatively, we could go with pas

RE: [EXT] Re: [PATCH] kni: fix build with Linux 6.3

2023-03-23 Thread Vamsi Krishna Attunuru
> -Original Message- > From: David Marchand > Sent: Monday, March 20, 2023 6:31 PM > To: Ferruh Yigit ; Vamsi Krishna Attunuru > ; Kiran Kumar Kokkilagadda > ; Jerin Jacob Kollanukkaran > > Cc: dev@dpdk.org; Thomas Monjalon > Subject: [EXT] Re: [PATCH] kn

Re: [PATCH] kni: fix build with Linux 6.3

2023-03-20 Thread David Marchand
On Mon, Mar 20, 2023 at 1:10 PM David Marchand wrote: > > On Tue, Feb 28, 2023 at 9:45 PM David Marchand > wrote: > > > > On Tue, Feb 28, 2023 at 6:29 PM Ferruh Yigit wrote: > > > > > > KNI calls `get_user_pages_remote()` API which is using `FOLL_TOUCH` > > > flag, but `FOLL_TOUCH` is no more in

Re: [PATCH] kni: fix build with Linux 6.3

2023-03-20 Thread David Marchand
On Tue, Feb 28, 2023 at 9:45 PM David Marchand wrote: > > On Tue, Feb 28, 2023 at 6:29 PM Ferruh Yigit wrote: > > > > KNI calls `get_user_pages_remote()` API which is using `FOLL_TOUCH` > > flag, but `FOLL_TOUCH` is no more in public headers since v6.3, > > causing a build error. > > Something lo

Re: [PATCH] kni: fix build with Linux 6.3

2023-02-28 Thread David Marchand
On Tue, Feb 28, 2023 at 6:29 PM Ferruh Yigit wrote: > > KNI calls `get_user_pages_remote()` API which is using `FOLL_TOUCH` > flag, but `FOLL_TOUCH` is no more in public headers since v6.3, > causing a build error. Something looks strange with what kni was doing. Looking at get_user_pages_remote

[PATCH] kni: fix build with Linux 6.3

2023-02-28 Thread Ferruh Yigit
KNI calls `get_user_pages_remote()` API which is using `FOLL_TOUCH` flag, but `FOLL_TOUCH` is no more in public headers since v6.3, causing a build error. `FOLL_*` defines in Linux kernel first moved to another header [1], later some of them moved to memory subsystem internal header [2] for 6.3 Q