Re: [PATCH] hash: make gfni stubs inline

2024-03-07 Thread Stephen Hemminger
On Thu, 7 Mar 2024 11:32:36 +0100 David Marchand wrote: > On Tue, Mar 5, 2024 at 6:53 PM Tyler Retzlaff > wrote: > > > > On Tue, Mar 05, 2024 at 11:14:45AM +0100, David Marchand wrote: > > > On Mon, Mar 4, 2024 at 7:45 PM Stephen Hemminger > > > wrote: > > > > > > > > This reverts commit 07

Re: [PATCH] hash: make gfni stubs inline

2024-03-07 Thread David Marchand
On Tue, Mar 5, 2024 at 6:53 PM Tyler Retzlaff wrote: > > On Tue, Mar 05, 2024 at 11:14:45AM +0100, David Marchand wrote: > > On Mon, Mar 4, 2024 at 7:45 PM Stephen Hemminger > > wrote: > > > > > > This reverts commit 07d836e5929d18ad6640ebae90dd2f81a2cafb71. > > > > > > Tyler found build issues w

Re: [PATCH] hash: make gfni stubs inline

2024-03-05 Thread Stephen Hemminger
On Tue, 5 Mar 2024 09:53:00 -0800 Tyler Retzlaff wrote: > On Tue, Mar 05, 2024 at 11:14:45AM +0100, David Marchand wrote: > > On Mon, Mar 4, 2024 at 7:45 PM Stephen Hemminger > > wrote: > > > > > > This reverts commit 07d836e5929d18ad6640ebae90dd2f81a2cafb71. > > > > > > Tyler found build issu

Re: [PATCH] hash: make gfni stubs inline

2024-03-05 Thread Tyler Retzlaff
On Tue, Mar 05, 2024 at 11:14:45AM +0100, David Marchand wrote: > On Mon, Mar 4, 2024 at 7:45 PM Stephen Hemminger > wrote: > > > > This reverts commit 07d836e5929d18ad6640ebae90dd2f81a2cafb71. > > > > Tyler found build issues with MSVC and the thash gfni stubs. > > The problem would be link error

Re: [PATCH] hash: make gfni stubs inline

2024-03-05 Thread David Marchand
On Mon, Mar 4, 2024 at 7:45 PM Stephen Hemminger wrote: > > This reverts commit 07d836e5929d18ad6640ebae90dd2f81a2cafb71. > > Tyler found build issues with MSVC and the thash gfni stubs. > The problem would be link errors from missing symbols. Trying to understand this link error. Does it come fr

[PATCH] hash: make gfni stubs inline

2024-03-04 Thread Stephen Hemminger
This reverts commit 07d836e5929d18ad6640ebae90dd2f81a2cafb71. Tyler found build issues with MSVC and the thash gfni stubs. The problem would be link errors from missing symbols. The purpose of the original commit was to allow local definition of RTE_LOGTYPE_HASH. Put the thash gfni back as inline