[PATCH] gro: fix gro with tcp push flag

2022-10-13 Thread Jun Qiu
TCP data packets sometimes carry a PUSH flag. Currently, only the packets that do not have PUSH flag can be GROed. The packets that have a PUSH flag cannot be GROed, the packets that cannot be processed by GRO are placed last. In this case, the received packets may be out of order. For example, the

RE: [PATCH] gro: fix gro with tcp push flag

2022-09-05 Thread Jun Qiu
ation with lro_psh_flag set by default. -Original Message- From: Hu, Jiayu Sent: Monday, September 5, 2022 12:03 PM To: Thomas Monjalon Cc: kumaraparameshwaran rathinavel ; dev@dpdk.org; Jun Qiu Subject: RE: [PATCH] gro: fix gro with tcp push flag Hi Qiu, I cannot find the original mail

RE: [PATCH] gro: fix gro with tcp push flag

2022-09-04 Thread Hu, Jiayu
: [PATCH] gro: fix gro with tcp push flag > > Sure, I will review it. > > > -Original Message- > > From: Thomas Monjalon > > Sent: Monday, August 29, 2022 6:36 PM > > To: Hu, Jiayu > > Cc: kumaraparameshwaran rathinavel ; > > dev@dpdk.org; Jun

RE: [PATCH] gro: fix gro with tcp push flag

2022-08-30 Thread Hu, Jiayu
Sure, I will review it. > -Original Message- > From: Thomas Monjalon > Sent: Monday, August 29, 2022 6:36 PM > To: Hu, Jiayu > Cc: kumaraparameshwaran rathinavel ; > dev@dpdk.org; Jun Qiu > Subject: Re: [PATCH] gro: fix gro with tcp push flag > > Jiayu, pl

Re: [PATCH] gro: fix gro with tcp push flag

2022-08-29 Thread Thomas Monjalon
ent and easy to understand, similar to how the > kernel stack is handled. > > From: kumaraparameshwaran rathinavel > Sent: Tuesday, July 26, 2022 3:08 PM > To: Jun Qiu > Cc: dev@dpdk.org; jiayu...@intel.com; sta...@dpdk.org > Subject: Re: [PATCH] gro: fix gro with tcp pu

RE: [PATCH] gro: fix gro with tcp push flag

2022-07-27 Thread Jun Qiu
rathinavel Sent: Tuesday, July 26, 2022 3:08 PM To: Jun Qiu Cc: dev@dpdk.org; jiayu...@intel.com; sta...@dpdk.org Subject: Re: [PATCH] gro: fix gro with tcp push flag We should do it for the rte_gro_reassemble as well, with timer mode it could lead to more duplicate ACKs. I had a proposal for

Re: [PATCH] gro: fix gro with tcp push flag

2022-07-26 Thread kumaraparameshwaran rathinavel
merged > > > > *发件人:* kumaraparameshwaran rathinavel > *发送时间:* 2022年7月26日 14:41 > *收件人:* Jun Qiu > *抄送:* dev@dpdk.org; jiayu...@intel.com; sta...@dpdk.org > *主题:* Re: [PATCH] gro: fix gro with tcp push flag > > > > > > > > On Tue, Jul 26, 2022 at 1

答复: [PATCH] gro: fix gro with tcp push flag

2022-07-25 Thread Jun Qiu
May be in rte_gro_reassemble_burst, where no delay is introduced, PUSH packets can be merged 发件人: kumaraparameshwaran rathinavel 发送时间: 2022年7月26日 14:41 收件人: Jun Qiu 抄送: dev@dpdk.org; jiayu...@intel.com; sta...@dpdk.org 主题: Re: [PATCH] gro: fix gro with tcp push flag On Tue, Jul 26, 2022 at

Re: [PATCH] gro: fix gro with tcp push flag

2022-07-25 Thread kumaraparameshwaran rathinavel
On Tue, Jul 26, 2022 at 11:48 AM Jun Qiu wrote: > TCP data packets sometimes carry a PUSH flag. Currently, > only the packets that do not have PUSH flag can be GROed. > The packets that have a PUSH flag cannot be GROed, the packets > that cannot be processed by GRO are placed last. > In this case

[PATCH] gro: fix gro with tcp push flag

2022-07-25 Thread Jun Qiu
TCP data packets sometimes carry a PUSH flag. Currently, only the packets that do not have PUSH flag can be GROed. The packets that have a PUSH flag cannot be GROed, the packets that cannot be processed by GRO are placed last. In this case, the received packets may be out of order. For example, the