Re: [PATCH] gpu/cuda: fix getenv related build error

2023-10-06 Thread Levend Sayar
My pleasure. Thanks for ACKing Elena. Thanks for applying David. Best, Levend > On 6 Oct 2023, at 13:07, David Marchand wrote: > > On Thu, Aug 3, 2023 at 6:25 PM Levend Sayar wrote: >> >> If gdrapi.h is available, meson sets DRIVERS_GPU_CUDA_GDRCOPY_H as 1. >> This causes gdrcopy.c build to g

Re: [PATCH] gpu/cuda: fix getenv related build error

2023-10-06 Thread David Marchand
On Thu, Aug 3, 2023 at 6:25 PM Levend Sayar wrote: > > If gdrapi.h is available, meson sets DRIVERS_GPU_CUDA_GDRCOPY_H as 1. > This causes gdrcopy.c build to give an error; > because compiler can not find signature of getenv. > stdlib.h is included for the definition of getenv function. > > Fixes:

Re: [PATCH] gpu/cuda: fix getenv related build error

2023-10-05 Thread Elena Agostini
Sounds good to me Thanks EA From: David Marchand Date: Friday, 29 September 2023 at 17:00 To: Elena Agostini Cc: dev@dpdk.org , Levend Sayar , Aaron Conole , rom...@astron.nl Subject: Re: [PATCH] gpu/cuda: fix getenv related build error External email: Use caution opening links or

Re: [PATCH] gpu/cuda: fix getenv related build error

2023-09-29 Thread David Marchand
On Thu, Aug 3, 2023 at 6:25 PM Levend Sayar wrote: > > If gdrapi.h is available, meson sets DRIVERS_GPU_CUDA_GDRCOPY_H as 1. > This causes gdrcopy.c build to give an error; > because compiler can not find signature of getenv. > stdlib.h is included for the definition of getenv function. > There w

[PATCH] gpu/cuda: fix getenv related build error

2023-08-03 Thread Levend Sayar
If gdrapi.h is available, meson sets DRIVERS_GPU_CUDA_GDRCOPY_H as 1. This causes gdrcopy.c build to give an error; because compiler can not find signature of getenv. stdlib.h is included for the definition of getenv function. Fixes: ca12f5e8a7db ("gpu/cuda: mark unused GDRCopy functions parameter