Re: [PATCH] examples/distributor: update dynamic configuration

2022-06-28 Thread Hunt, David
On 28/06/2022 13:06, Omer Yamac wrote: Hi, Here is the final version. If it is ok, I will test the code and publish. if (enable_lcore_rx_distributor){ // rx and distributor combined, 3 fixed function cores (stat, TX, at least 1 worker) min_cores = 4; num_workers = rte_lcore_count() -

Re: [PATCH] examples/distributor: update dynamic configuration

2022-06-28 Thread Omer Yamac
Hi, Here is the final version. If it is ok, I will test the code and publish. if (enable_lcore_rx_distributor){ // rx and distributor combined, 3 fixed function cores (stat, TX, at least 1 worker) min_cores = 4; num_workers = rte_lcore_count() - 3; } else{ // separate rx and d

Re: [PATCH] examples/distributor: update dynamic configuration

2022-06-28 Thread Hunt, David
On 28/06/2022 12:06, Omer Yamac wrote: Hi David, I have one more question. When I was working on new patch, I just want to make sure what we are doing. On 27.06.2022 18:51, Hunt, David wrote: Hi Ömer, I've a few comments: On 21/06/2022 21:15, Abdullah Ömer Yamaç wrote: --clipped-- @@ -3

Re: [PATCH] examples/distributor: update dynamic configuration

2022-06-28 Thread Omer Yamac
Hi David, I have one more question. When I was working on new patch, I just want to make sure what we are doing. On 27.06.2022 18:51, Hunt, David wrote: Hi Ömer, I've a few comments: On 21/06/2022 21:15, Abdullah Ömer Yamaç wrote: --clipped-- @@ -39,6 +39,7 @@ volatile uint8_t quit_signal_

Re: [PATCH] examples/distributor: update dynamic configuration

2022-06-28 Thread Hunt, David
Hi Ömer, On 27/06/2022 17:28, Omer Yamac wrote: Hi David, Thank you for your review. I have two questions. The first one is about new release. As I remember new DPDK realize will be published in a short time and my previous fix in that release. Therefore, Should I wait for that release to su

Re: [PATCH] examples/distributor: update dynamic configuration

2022-06-27 Thread Omer Yamac
Hi David, Thank you for your review. I have two questions. The first one is about new release. As I remember new DPDK realize will be published in a short time and my previous fix in that release. Therefore, Should I wait for that release to submit patch? The other question is below, On 27.

Re: [PATCH] examples/distributor: update dynamic configuration

2022-06-27 Thread Hunt, David
Hi Ömer, I've a few comments: On 21/06/2022 21:15, Abdullah Ömer Yamaç wrote: In this patch, * It is possible to switch the running mode of the distributor using the command line argument. * With "-c" parameter, you can run RX and Distributor on the same core. * Without

[PATCH] examples/distributor: update dynamic configuration

2022-06-21 Thread Abdullah Ömer Yamaç
In this patch, * It is possible to switch the running mode of the distributor using the command line argument. * With "-c" parameter, you can run RX and Distributor on the same core. * Without "-c" parameter, you can run RX and Distributor on the different core. * Sy

[PATCH] examples/distributor: update dynamic configuration

2022-06-21 Thread Abdullah Ömer Yamaç
In this patch, * It is possible to switch the running mode of the distributor using the command line argument. * With "-c" parameter, you can run RX and Distributor on the same core. * Without "-c" parameter, you can run RX and Distributor on the different core. * Sy