Re: [PATCH] ethdev: telemetry xstats support hide zero

2023-02-12 Thread fengchengwen
On 2023/2/10 19:55, Ferruh Yigit wrote: > On 2/10/2023 1:23 AM, fengchengwen wrote: >> On 2023/2/10 7:30, Ferruh Yigit wrote: >>> On 2/9/2023 3:07 AM, Chengwen Feng wrote: The number of xstats may be large, after the hide zero option is added, only non-zero values can be displayed. >

Re: [PATCH] ethdev: telemetry xstats support hide zero

2023-02-10 Thread Ferruh Yigit
On 2/10/2023 1:23 AM, fengchengwen wrote: > On 2023/2/10 7:30, Ferruh Yigit wrote: >> On 2/9/2023 3:07 AM, Chengwen Feng wrote: >>> The number of xstats may be large, after the hide zero option is added, >>> only non-zero values can be displayed. >>> >> >> Hi Chengwen, >> >> No objection on the fun

Re: [PATCH] ethdev: telemetry xstats support hide zero

2023-02-09 Thread fengchengwen
On 2023/2/10 7:30, Ferruh Yigit wrote: > On 2/9/2023 3:07 AM, Chengwen Feng wrote: >> The number of xstats may be large, after the hide zero option is added, >> only non-zero values can be displayed. >> > > Hi Chengwen, > > No objection on the functionality, we have similar config option in > tes

Re: [PATCH] ethdev: telemetry xstats support hide zero

2023-02-09 Thread Ferruh Yigit
On 2/9/2023 3:07 AM, Chengwen Feng wrote: > The number of xstats may be large, after the hide zero option is added, > only non-zero values can be displayed. > Hi Chengwen, No objection on the functionality, we have similar config option in testpmd too, but I have some question on telemetry side

[PATCH] ethdev: telemetry xstats support hide zero

2023-02-08 Thread Chengwen Feng
The number of xstats may be large, after the hide zero option is added, only non-zero values can be displayed. Signed-off-by: Chengwen Feng --- lib/ethdev/rte_ethdev.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethde