Re: [PATCH] ethdev: fix Tx queue mask endianness

2023-06-30 Thread David Marchand
On Fri, Jun 30, 2023 at 9:00 AM David Marchand wrote: > > On Thu, Jun 29, 2023 at 6:14 PM Ferruh Yigit wrote: > > > > On 6/29/2023 4:42 PM, Thomas Monjalon wrote: > > > 29/06/2023 17:40, David Marchand: > > >> On Thu, Jun 29, 2023 at 5:31 PM Thomas Monjalon > > >> wrote: > > >>> 29/06/2023 15:5

Re: [PATCH] ethdev: fix Tx queue mask endianness

2023-06-30 Thread David Marchand
On Thu, Jun 29, 2023 at 6:14 PM Ferruh Yigit wrote: > > On 6/29/2023 4:42 PM, Thomas Monjalon wrote: > > 29/06/2023 17:40, David Marchand: > >> On Thu, Jun 29, 2023 at 5:31 PM Thomas Monjalon > >> wrote: > >>> 29/06/2023 15:58, David Marchand: > - .tx_queue = RTE_BE16(0x), > +

Re: [PATCH] ethdev: fix Tx queue mask endianness

2023-06-29 Thread Ferruh Yigit
On 6/29/2023 4:42 PM, Thomas Monjalon wrote: > 29/06/2023 17:40, David Marchand: >> On Thu, Jun 29, 2023 at 5:31 PM Thomas Monjalon wrote: >>> 29/06/2023 15:58, David Marchand: - .tx_queue = RTE_BE16(0x), + .tx_queue = 0x, >>> >>> As I said in an earlier comment about the

Re: [PATCH] ethdev: fix Tx queue mask endianness

2023-06-29 Thread Thomas Monjalon
29/06/2023 17:40, David Marchand: > On Thu, Jun 29, 2023 at 5:31 PM Thomas Monjalon wrote: > > 29/06/2023 15:58, David Marchand: > > > - .tx_queue = RTE_BE16(0x), > > > + .tx_queue = 0x, > > > > As I said in an earlier comment about the same issue, > > UINT16_MAX would be better. >

Re: [PATCH] ethdev: fix Tx queue mask endianness

2023-06-29 Thread David Marchand
On Thu, Jun 29, 2023 at 5:31 PM Thomas Monjalon wrote: > > 29/06/2023 15:58, David Marchand: > > Even if harmless, this endianness tag is incorrect as the tx_queue field > > is declared as a host integer. > > Additionally, this breaks OVS compilation with sparse. > > > > Fixes: 41f6bdc7615a ("ethd

Re: [PATCH] ethdev: fix Tx queue mask endianness

2023-06-29 Thread Thomas Monjalon
29/06/2023 15:58, David Marchand: > Even if harmless, this endianness tag is incorrect as the tx_queue field > is declared as a host integer. > Additionally, this breaks OVS compilation with sparse. > > Fixes: 41f6bdc7615a ("ethdev: add Tx queue flow matching item") > > Signed-off-by: David March

Re: [PATCH] ethdev: fix Tx queue mask endianness

2023-06-29 Thread Ferruh Yigit
On 6/29/2023 2:58 PM, David Marchand wrote: > Even if harmless, this endianness tag is incorrect as the tx_queue field > is declared as a host integer. > Additionally, this breaks OVS compilation with sparse. > > Fixes: 41f6bdc7615a ("ethdev: add Tx queue flow matching item") > > Signed-off-by: D

[PATCH] ethdev: fix Tx queue mask endianness

2023-06-29 Thread David Marchand
Even if harmless, this endianness tag is incorrect as the tx_queue field is declared as a host integer. Additionally, this breaks OVS compilation with sparse. Fixes: 41f6bdc7615a ("ethdev: add Tx queue flow matching item") Signed-off-by: David Marchand --- lib/ethdev/rte_flow.h | 2 +- 1 file c