Re: [PATCH] eal: remove unnecessary use of statement expression

2024-02-14 Thread David Marchand
On Wed, Jan 31, 2024 at 1:19 AM Tyler Retzlaff wrote: > > Remove use of statement expression syntax in expansion of > MOVEUNALIGNED_LEFT47_IMM and MOVEUNALIGNED_LEFT47 macro expansions. > > There appears to be no need to use the statement expression compiler > extension a simple block should work.

Re: [PATCH] eal: remove unnecessary use of statement expression

2024-02-13 Thread David Marchand
On Tue, Feb 13, 2024 at 11:41 AM David Marchand wrote: > > On Mon, Feb 12, 2024 at 6:56 PM Tyler Retzlaff > wrote: > > > > ping > > > > could relevant maintainers take a look? > > This change comes from the old commit 5f2c68a710e1 ("lib: work around > braced-groups within expressions"). > I suspe

Re: [PATCH] eal: remove unnecessary use of statement expression

2024-02-13 Thread David Marchand
On Mon, Feb 12, 2024 at 6:56 PM Tyler Retzlaff wrote: > > ping > > could relevant maintainers take a look? This change comes from the old commit 5f2c68a710e1 ("lib: work around braced-groups within expressions"). I suspect this change breaks application compiling with pedantic, without setting a

Re: [PATCH] eal: remove unnecessary use of statement expression

2024-02-12 Thread Tyler Retzlaff
ping could relevant maintainers take a look? thank you! On Tue, Jan 30, 2024 at 04:18:49PM -0800, Tyler Retzlaff wrote: > Remove use of statement expression syntax in expansion of > MOVEUNALIGNED_LEFT47_IMM and MOVEUNALIGNED_LEFT47 macro expansions. > > There appears to be no need to use the st

[PATCH] eal: remove unnecessary use of statement expression

2024-01-30 Thread Tyler Retzlaff
Remove use of statement expression syntax in expansion of MOVEUNALIGNED_LEFT47_IMM and MOVEUNALIGNED_LEFT47 macro expansions. There appears to be no need to use the statement expression compiler extension a simple block should work. Signed-off-by: Tyler Retzlaff --- lib/eal/x86/include/rte_memc