Re: [PATCH] eal: fix cleanup on Windows

2024-11-08 Thread Thomas Monjalon
08/11/2024 16:43, Mattias Rönnblom: > On 2024-11-08 14:08, Thomas Monjalon wrote: > > The memory allocated with _aligned_malloc() > > must be released with _aligned_free() on Windows. > > > > The POSIX free() was called in eal_lcore_var_cleanup(), > > Referring to free() as a part of POSIX is tru

RE: [PATCH] eal: fix cleanup on Windows

2024-11-08 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, 8 November 2024 17.01 > > On Fri, 8 Nov 2024 14:08:21 +0100 > Thomas Monjalon wrote: > > > The memory allocated with _aligned_malloc() > > must be released with _aligned_free() on Windows. > > > > The POSIX free() was

Re: [PATCH] eal: fix cleanup on Windows

2024-11-08 Thread Stephen Hemminger
On Fri, 8 Nov 2024 14:08:21 +0100 Thomas Monjalon wrote: > The memory allocated with _aligned_malloc() > must be released with _aligned_free() on Windows. > > The POSIX free() was called in eal_lcore_var_cleanup(), > called in rte_eal_cleanup(), and triggered a heap corruption: > exit status 32

Re: [PATCH] eal: fix cleanup on Windows

2024-11-08 Thread Mattias Rönnblom
On 2024-11-08 14:08, Thomas Monjalon wrote: The memory allocated with _aligned_malloc() must be released with _aligned_free() on Windows. The POSIX free() was called in eal_lcore_var_cleanup(), Referring to free() as a part of POSIX is true, but a bit misleading, since it's also standard C.

Re: [PATCH] eal: fix cleanup on Windows

2024-11-08 Thread Dmitry Kozlyuk
2024-11-08 14:08 (UTC+0100), Thomas Monjalon: > The memory allocated with _aligned_malloc() > must be released with _aligned_free() on Windows. > > The POSIX free() was called in eal_lcore_var_cleanup(), > called in rte_eal_cleanup(), and triggered a heap corruption: > exit status 3221226356 or si

RE: [PATCH] eal: fix cleanup on Windows

2024-11-08 Thread Morten Brørup
Reviewed-by: Morten Brørup

Re: [PATCH] eal: fix cleanup on Windows

2024-11-08 Thread David Marchand
On Fri, Nov 8, 2024 at 2:08 PM Thomas Monjalon wrote: > > The memory allocated with _aligned_malloc() > must be released with _aligned_free() on Windows. > > The POSIX free() was called in eal_lcore_var_cleanup(), > called in rte_eal_cleanup(), and triggered a heap corruption: > exit status 322122

[PATCH] eal: fix cleanup on Windows

2024-11-08 Thread Thomas Monjalon
The memory allocated with _aligned_malloc() must be released with _aligned_free() on Windows. The POSIX free() was called in eal_lcore_var_cleanup(), called in rte_eal_cleanup(), and triggered a heap corruption: exit status 3221226356 or signal 3221226228 SIGinvalid with MALLOC_PERTURB_=86 Fixes: