Re: [PATCH] eal/common: fix inconsistent representation of PCI numbers

2024-10-04 Thread Stephen Hemminger
On Mon, 1 Jul 2024 23:01:17 +0300 Shani Peretz wrote: > +/** > + * General device name comparison. Will compare by using the specific bus > + * compare function or by comparing the names directly. > + * > + * @param dev > + * Device handle. > + * @param name > + * Name to compare against. > +

Re: [PATCH] eal/common: fix inconsistent representation of PCI numbers

2024-07-01 Thread Stephen Hemminger
On Mon, 1 Jul 2024 23:01:17 +0300 Shani Peretz wrote: > --- a/drivers/bus/pci/pci_common.c > +++ b/drivers/bus/pci/pci_common.c > @@ -501,6 +501,15 @@ rte_pci_dump(FILE *f) > pci_dump_one_device(f, dev); > } > } > +static int > +pci_cmp_name(const struct rte_device *dev1, con

[PATCH] eal/common: fix inconsistent representation of PCI numbers

2024-07-01 Thread Shani Peretz
DPDK allows for two ways to specify PCI device numbers: a full version (":08:00.0") and a short version ("08:00.0"). The problem arises when the application uses one format (e.g., full) when running testpmd, but then tries to use the other format (e.g., short) in a subsequent command, leading t