Re: [PATCH] drivers: remove compile-time option for IEEE 1588

2024-10-03 Thread Ferruh Yigit
On 10/3/2024 8:12 PM, Stephen Hemminger wrote: > On Wed, 17 Apr 2024 14:24:00 +0100 > Ferruh Yigit wrote: > >>> :) remove compile flag in 24.11 LTS. >>> >>> But we may end up in same situation in 24.11, some drivers not being >>> ready, so we should merge this patch very early in the 24.11 to giv

Re: [PATCH] drivers: remove compile-time option for IEEE 1588

2024-10-03 Thread Stephen Hemminger
On Wed, 17 Apr 2024 14:24:00 +0100 Ferruh Yigit wrote: > > :) remove compile flag in 24.11 LTS. > > > > But we may end up in same situation in 24.11, some drivers not being > > ready, so we should merge this patch very early in the 24.11 to give > > time to drivers to fix if they were not ready

Re: [PATCH] drivers: remove compile-time option for IEEE 1588

2024-04-17 Thread Ferruh Yigit
On 11/3/2023 12:08 AM, Ferruh Yigit wrote: > On 11/2/2023 10:17 PM, Thomas Monjalon wrote: >> 02/11/2023 22:21, Ajit Khaparde: >>> On Thu, Nov 2, 2023 at 2:13 PM Ferruh Yigit wrote: On 6/25/2023 4:45 PM, Thomas Monjalon wrote: > 23/06/2023 16:00, Ferruh Yigit: >> On 2/3/2023 1:28 PM,

Re: [PATCH] drivers: remove compile-time option for IEEE 1588

2023-11-02 Thread Ferruh Yigit
On 11/2/2023 10:17 PM, Thomas Monjalon wrote: > 02/11/2023 22:21, Ajit Khaparde: >> On Thu, Nov 2, 2023 at 2:13 PM Ferruh Yigit wrote: >>> On 6/25/2023 4:45 PM, Thomas Monjalon wrote: 23/06/2023 16:00, Ferruh Yigit: > On 2/3/2023 1:28 PM, Thomas Monjalon wrote: >> The option RTE_LIBRT

Re: [PATCH] drivers: remove compile-time option for IEEE 1588

2023-11-02 Thread Thomas Monjalon
02/11/2023 22:21, Ajit Khaparde: > On Thu, Nov 2, 2023 at 2:13 PM Ferruh Yigit wrote: > > On 6/25/2023 4:45 PM, Thomas Monjalon wrote: > > > 23/06/2023 16:00, Ferruh Yigit: > > >> On 2/3/2023 1:28 PM, Thomas Monjalon wrote: > > >>> The option RTE_LIBRTE_IEEE1588 has no effect on any library > > >>

Re: [PATCH] drivers: remove compile-time option for IEEE 1588

2023-11-02 Thread Ajit Khaparde
On Thu, Nov 2, 2023 at 2:13 PM Ferruh Yigit wrote: > > On 6/25/2023 4:45 PM, Thomas Monjalon wrote: > > 23/06/2023 16:00, Ferruh Yigit: > >> On 2/3/2023 1:28 PM, Thomas Monjalon wrote: > >>> The option RTE_LIBRTE_IEEE1588 has no effect on any library > >>> unlike its name. > >>> > >>> Also we are

Re: [PATCH] drivers: remove compile-time option for IEEE 1588

2023-11-02 Thread Ferruh Yigit
On 6/25/2023 4:45 PM, Thomas Monjalon wrote: > 23/06/2023 16:00, Ferruh Yigit: >> On 2/3/2023 1:28 PM, Thomas Monjalon wrote: >>> The option RTE_LIBRTE_IEEE1588 has no effect on any library >>> unlike its name. >>> >>> Also we are suppose to enable/disable features dynamically, >>> not at compilati

Re: [PATCH] drivers: remove compile-time option for IEEE 1588

2023-06-25 Thread Thomas Monjalon
23/06/2023 16:00, Ferruh Yigit: > On 2/3/2023 1:28 PM, Thomas Monjalon wrote: > > The option RTE_LIBRTE_IEEE1588 has no effect on any library > > unlike its name. > > > > Also we are suppose to enable/disable features dynamically, > > not at compilation time. > > > > And the best is that this mac

Re: [PATCH] drivers: remove compile-time option for IEEE 1588

2023-06-23 Thread Ferruh Yigit
On 2/3/2023 1:28 PM, Thomas Monjalon wrote: > The option RTE_LIBRTE_IEEE1588 has no effect on any library > unlike its name. > > Also we are suppose to enable/disable features dynamically, > not at compilation time. > > And the best is that this macro is neither documented, > nor in rte_config.h.

[PATCH] drivers: remove compile-time option for IEEE 1588

2023-02-03 Thread Thomas Monjalon
The option RTE_LIBRTE_IEEE1588 has no effect on any library unlike its name. Also we are suppose to enable/disable features dynamically, not at compilation time. And the best is that this macro is neither documented, nor in rte_config.h. It looks to be a mistake keeping this flag, so it is remov