Re: [PATCH] config: remove explicit undef of unset values

2022-06-15 Thread David Marchand
On Thu, Dec 16, 2021 at 12:15 PM Bruce Richardson wrote: > > Rather than explicitly clearing any setting of undefined values in our > rte_config.h file, it's better to instead just add a comment that the > value is not set. Using a comment allows the user to set the value using > CFLAGS or similar

Re: [PATCH] config: remove explicit undef of unset values

2022-06-13 Thread Bruce Richardson
On Mon, Jun 13, 2022 at 04:20:04PM +0200, David Marchand wrote: > On Mon, Jun 13, 2022 at 2:37 PM Bruce Richardson > wrote: > > > I'd like a check like (below), to avoid new additions: > > > > > > diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh > > > index 34a2e43845..8dae47165e 1

Re: [PATCH] config: remove explicit undef of unset values

2022-06-13 Thread Tyler Retzlaff
On Mon, Jun 13, 2022 at 10:54:33AM +0100, Bruce Richardson wrote: > On Thu, Dec 16, 2021 at 11:14:30AM +, Bruce Richardson wrote: > > Rather than explicitly clearing any setting of undefined values in our > > rte_config.h file, it's better to instead just add a comment that the > > value is not

Re: [PATCH] config: remove explicit undef of unset values

2022-06-13 Thread David Marchand
On Mon, Jun 13, 2022 at 2:37 PM Bruce Richardson wrote: > > I'd like a check like (below), to avoid new additions: > > > > diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh > > index 34a2e43845..8dae47165e 100755 > > --- a/devtools/checkpatches.sh > > +++ b/devtools/checkpatches.sh

Re: [PATCH] config: remove explicit undef of unset values

2022-06-13 Thread Bruce Richardson
On Mon, Jun 13, 2022 at 02:26:14PM +0200, David Marchand wrote: > On Mon, Jun 13, 2022 at 11:54 AM Bruce Richardson > wrote: > > On Thu, Dec 16, 2021 at 11:14:30AM +, Bruce Richardson wrote: > > > Rather than explicitly clearing any setting of undefined values in our > > > rte_config.h file, i

Re: [PATCH] config: remove explicit undef of unset values

2022-06-13 Thread David Marchand
On Mon, Jun 13, 2022 at 11:54 AM Bruce Richardson wrote: > On Thu, Dec 16, 2021 at 11:14:30AM +, Bruce Richardson wrote: > > Rather than explicitly clearing any setting of undefined values in our > > rte_config.h file, it's better to instead just add a comment that the > > value is not set. Us

RE: [PATCH] config: remove explicit undef of unset values

2022-06-13 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Monday, 13 June 2022 11.55 > To: dev@dpdk.org > Cc: david.march...@redhat.com; junx.d...@intel.com > Subject: Re: [PATCH] config: remove explicit undef of unset values > > On Thu, Dec 16, 2021 at 11

Re: [PATCH] config: remove explicit undef of unset values

2022-06-13 Thread Bruce Richardson
On Thu, Dec 16, 2021 at 11:14:30AM +, Bruce Richardson wrote: > Rather than explicitly clearing any setting of undefined values in our > rte_config.h file, it's better to instead just add a comment that the > value is not set. Using a comment allows the user to set the value using > CFLAGS or s

[PATCH] config: remove explicit undef of unset values

2021-12-16 Thread Bruce Richardson
Rather than explicitly clearing any setting of undefined values in our rte_config.h file, it's better to instead just add a comment that the value is not set. Using a comment allows the user to set the value using CFLAGS or similar mechanism without the config file clearing the value again. The te