Re: [PATCH] common/sfc: replace out of bounds condition with static_assert

2024-02-12 Thread Andrew Rybchenko
On 1/19/24 02:05, Morten Brørup wrote: From: Stephen Hemminger [mailto:step...@networkplumber.org] Sent: Thursday, 18 January 2024 21.18 The sfc base code had its own definition of static assertions using the out of bound array access hack. Replace it with a static_assert like rte_common.h. Fix

[PATCH] common/sfc: replace out of bounds condition with static_assert

2024-02-11 Thread Stephen Hemminger
The sfc base code had its own definition of static assertions using the out of bound array access hack. This method does not force the condition to be const and can have false negatives. Better to use static_assert() like other places in DPDK. Fixes: f67e4719147d ("net/sfc/base: fix coding style"

RE: [PATCH] common/sfc: replace out of bounds condition with static_assert

2024-01-18 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, 18 January 2024 21.18 > > The sfc base code had its own definition of static assertions > using the out of bound array access hack. Replace it with a > static_assert like rte_common.h. > > Fixes: f67e4719147d ("net/sf

[PATCH] common/sfc: replace out of bounds condition with static_assert

2024-01-18 Thread Stephen Hemminger
The sfc base code had its own definition of static assertions using the out of bound array access hack. Replace it with a static_assert like rte_common.h. Fixes: f67e4719147d ("net/sfc/base: fix coding style") Signed-off-by: Stephen Hemminger --- drivers/common/sfc_efx/base/efx.h | 4 ++-- 1 fil