Re: [PATCH] cfgfile: increase value length

2024-02-01 Thread Varghese, Vipin
On 2/1/2024 4:02 PM, David Marchand wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. On Wed, Dec 6, 2023 at 12:31 PM Vipin Varghese wrote: The default value for CFG_VALUE_LEN is set to 256 character

Re: [PATCH] cfgfile: increase value length

2024-02-01 Thread David Marchand
On Wed, Dec 6, 2023 at 12:31 PM Vipin Varghese wrote: > > The default value for CFG_VALUE_LEN is set to 256 characters. > This limits the parsing for longer strings in configuration file. > Setting the default to 2048 characters increases the value array > size in `struct rte_cfgfile_entry`. > > F

Re: [PATCH] cfgfile: increase value length

2023-12-06 Thread Varghese, Vipin
[AMD Official Use Only - General] From: Bruce Richardson Sent: 06 December 2023 21:20 To: Varghese, Vipin Cc: Dumitrescu, Cristian ; dev@dpdk.org ; Yigit, Ferruh ; Parikh, Neerav Subject: Re: [PATCH] cfgfile: increase value length Caution: This message originated from an External Source

Re: [PATCH] cfgfile: increase value length

2023-12-06 Thread Bruce Richardson
On Wed, Dec 06, 2023 at 03:22:41PM +, Varghese, Vipin wrote: >[AMD Official Use Only - General] > >Thanks Bruce & Cristian for the comments. >An increase seems ok to me, but is an 8x increase really necessary? If >lines in the config files are over 1k in size, then it implies t

Re: [PATCH] cfgfile: increase value length

2023-12-06 Thread Varghese, Vipin
se > Cc: dev@dpdk.org; Dumitrescu, Cristian ; > Ferruh Yigit > Subject: Re: [PATCH] cfgfile: increase value length > > On Wed, Dec 06, 2023 at 04:59:52PM +0530, Vipin Varghese wrote: > > The default value for CFG_VALUE_LEN is set to 256 characters. > > This limits the

RE: [PATCH] cfgfile: increase value length

2023-12-06 Thread Dumitrescu, Cristian
> -Original Message- > From: Richardson, Bruce > Sent: Wednesday, December 6, 2023 1:22 PM > To: Vipin Varghese > Cc: dev@dpdk.org; Dumitrescu, Cristian ; > Ferruh Yigit > Subject: Re: [PATCH] cfgfile: increase value length > > On Wed, Dec 06, 2023

Re: [PATCH] cfgfile: increase value length

2023-12-06 Thread Bruce Richardson
On Wed, Dec 06, 2023 at 04:59:52PM +0530, Vipin Varghese wrote: > The default value for CFG_VALUE_LEN is set to 256 characters. > This limits the parsing for longer strings in configuration file. > Setting the default to 2048 characters increases the value array > size in `struct rte_cfgfile_entry`

[PATCH] cfgfile: increase value length

2023-12-06 Thread Vipin Varghese
The default value for CFG_VALUE_LEN is set to 256 characters. This limits the parsing for longer strings in configuration file. Setting the default to 2048 characters increases the value array size in `struct rte_cfgfile_entry`. Files using cfgfile library are 1. drivers/net/mvpp2/ 2. app/test-dma