Re: [PATCH] bitops: fix issue in parallel atomic tests

2024-10-14 Thread Mattias Rönnblom
On 2024-10-14 16:16, David Marchand wrote: On Sun, Oct 13, 2024 at 5:37 PM Morten Brørup wrote: I'm far from sure it's a compiler bug. Just look at the base rate: how often does the code you just wrote fail because of a bug in your code, and how often is the root cause to be found in the compi

Re: [PATCH] bitops: fix issue in parallel atomic tests

2024-10-14 Thread David Marchand
On Sun, Oct 13, 2024 at 5:37 PM Morten Brørup wrote: > > I'm far from sure it's a compiler bug. Just look at the base rate: how > > often does the code you just wrote fail because of a bug in your code, > > and how often is the root cause to be found in the compiler or the > > standard libraries.

Re: [PATCH] bitops: fix issue in parallel atomic tests

2024-10-14 Thread David Marchand
On Sun, Oct 13, 2024 at 2:06 PM Mattias Rönnblom wrote: > > The macros generating the parallel test for atomic test-and- > [set|clear|flip] functions used a 64-bit reference word when assuring > no neighbouring bits were modified, even when generating code for the > 32-bit version of the test. > >

RE: [PATCH] bitops: fix issue in parallel atomic tests

2024-10-13 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Sunday, 13 October 2024 17.20 > > On 2024-10-13 15:37, Morten Brørup wrote: > >> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > >> Sent: Sunday, 13 October 2024 13.57 > >> > >> The macros generating the parallel test

Re: [PATCH] bitops: fix issue in parallel atomic tests

2024-10-13 Thread Mattias Rönnblom
On 2024-10-13 15:37, Morten Brørup wrote: From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] Sent: Sunday, 13 October 2024 13.57 The macros generating the parallel test for atomic test-and- [set|clear|flip] functions used a 64-bit reference word when assuring no neighbouring bits were

RE: [PATCH] bitops: fix issue in parallel atomic tests

2024-10-13 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Sunday, 13 October 2024 13.57 > > The macros generating the parallel test for atomic test-and- > [set|clear|flip] functions used a 64-bit reference word when assuring > no neighbouring bits were modified, even when generating

[PATCH] bitops: fix issue in parallel atomic tests

2024-10-13 Thread Mattias Rönnblom
The macros generating the parallel test for atomic test-and- [set|clear|flip] functions used a 64-bit reference word when assuring no neighbouring bits were modified, even when generating code for the 32-bit version of the test. This issue causes spurious test failures on GCC 12.2.0 (the default c