Re: [PATCH] app/testpmd: skip stopped queues when forwarding

21/02/2022 09:58, Dmitry Kozlyuk: > Andrew, Ferruh, Thomas, which behavior does ethdev assume (see below)? For the whole device stop, this is the documentation: " The transmit and receive functions should not be invoked when the device is stopped. " There is also this comment on rte_eth_dev_r

RE: [PATCH] app/testpmd: skip stopped queues when forwarding

Andrew, Ferruh, Thomas, which behavior does ethdev assume (see below)? > This patch was created with the assumption > that stopped queues may not be used for Rx/Tx. > No-op behavior of rte_eth_rx/tx_burst() > for a stopped queue is not documented. > Yes, at least some PMDs implement it this way. >

RE: [PATCH] app/testpmd: skip stopped queues when forwarding

- jing.d.c...@intel.com (invalid address?), +ethdev maintainers > From: Li, Xiaoyun > [...] > Sorry to be direct, but I don't think this patch makes sense. > I need the code to clarify the problems so I'll use this thread not > the one you're answering. Thank you for explaining the issues in gr

RE: [PATCH] app/testpmd: skip stopped queues when forwarding

: Singh, Aman Deep ; Dmitry Kozlyuk > ; dev@dpdk.org > Cc: Li, Xiaoyun ; jing.d.c...@intel.com; > sta...@dpdk.org; Raslan Darawsheh > Subject: RE: [PATCH] app/testpmd: skip stopped queues when forwarding > > Hi Dmitry, > > > -Original Message- > > From: Si

RE: [PATCH] app/testpmd: skip stopped queues when forwarding

Hi Aman, Yuying, You share some concerns, so I'm answering in one thread. > From: Zhang, Yuying > Sent: Wednesday, February 9, 2022 12:00 PM [...] > > > +2225,20 @@ run_pkt_fwd_on_lcore(struct fwd_lcore *fc, > packet_fwd_t > > pkt_fwd) > > > static int > > > start_pkt_forward_on_core(void *f

RE: [PATCH] app/testpmd: skip stopped queues when forwarding

Hi Dmitry, > -Original Message- > From: Singh, Aman Deep > Sent: Thursday, February 3, 2022 9:52 PM > To: Dmitry Kozlyuk ; dev@dpdk.org > Cc: Li, Xiaoyun ; Zhang, Yuying > ; jing.d.c...@intel.com; sta...@dpdk.org; Raslan > Darawsheh > Subject: Re: [PATCH] a

Re: [PATCH] app/testpmd: skip stopped queues when forwarding

Hi Dmitry, Thanks for the patch. On 1/13/2022 2:51 PM, Dmitry Kozlyuk wrote: After "port rxq|txq stop" the stopped queue was used in forwarding nonetheless, which may cause undefined behavior in the PMD. Record the configured queue state and account for it when launching forwarding as follow

RE: [PATCH] app/testpmd: skip stopped queues when forwarding

> From: Dmitry Kozlyuk > Sent: Thursday, January 13, 2022 12:21 PM Hi Aman, Xiaoyun, Yuying, Any comments on the proposed behavior or the code?

[PATCH] app/testpmd: skip stopped queues when forwarding

After "port rxq|txq stop" the stopped queue was used in forwarding nonetheless, which may cause undefined behavior in the PMD. Record the configured queue state and account for it when launching forwarding as follows: ++-+-+---+ |RxQ |TxQ |Con