Re: [PATCH] app/testpmd: remove useless pointer checks

2022-05-12 Thread David Marchand
On Tue, Mar 29, 2022 at 11:26 AM Thomas Monjalon wrote: > > 24/03/2022 17:15, David Marchand: > > Parameters to this static helper can't be NULL. > > str has already been dereferenced in caller. > > dst and size point to variable in stack. > > The same function is copy/pasted in several places. >

Re: [PATCH] app/testpmd: remove useless pointer checks

2022-03-29 Thread Thomas Monjalon
24/03/2022 17:15, David Marchand: > Parameters to this static helper can't be NULL. > str has already been dereferenced in caller. > dst and size point to variable in stack. The same function is copy/pasted in several places. Why simplifying only this one? because of its static nature? Shouldn't

[PATCH] app/testpmd: remove useless pointer checks

2022-03-24 Thread David Marchand
Parameters to this static helper can't be NULL. str has already been dereferenced in caller. dst and size point to variable in stack. Fixes: 169a9fed1f4c ("app/testpmd: fix hex string parser support for flow API") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- app/test-pmd/cmdline_flow.c