Re: [PATCH] app/testpmd: fix indirect action list parameters parsing

2023-11-10 Thread Etelson, Gregory
Hello Ferruh, About the fault root cause. There were 2 uncoupled resources in that case: static token size and variable size passed to parse_int(). parse_int() caller must provide a buffer large enough for token size. Otherwise parse_int() will corrupt memory outside the input buffer. As you

Re: [PATCH] app/testpmd: fix indirect action list parameters parsing

2023-11-10 Thread Ferruh Yigit
On 11/10/2023 5:41 PM, Etelson, Gregory wrote: > Hello Ferruh, > > [:snip:] > >>> *** stack smashing detected ***: terminated >>> >>> The corruption occurred in `parse_int()` called from >>> `parse_indlst_id2ptr()`. >>> >>> Inside `parse_int()` the arg parameter referenced 8 bytes of memory >>> w

Re: [PATCH] app/testpmd: fix indirect action list parameters parsing

2023-11-10 Thread Etelson, Gregory
Hello Ferruh, [:snip:] *** stack smashing detected ***: terminated The corruption occurred in `parse_int()` called from `parse_indlst_id2ptr()`. Inside `parse_int()` the arg parameter referenced 8 bytes of memory while the target buffer was 4 bytes allocated on caller optimized stack: (gdb)

Re: [PATCH] app/testpmd: fix indirect action list parameters parsing

2023-11-10 Thread Ferruh Yigit
On 11/9/2023 7:57 PM, Etelson, Gregory wrote: > Hello Ferruh, > > Indirect actions list arguments parser was configured to place target > number into 64bit value, while the code provided 32bits memory. > Hi Gregory, Can you please give more details why 'id' needs to

Re: [PATCH] app/testpmd: fix indirect action list parameters parsing

2023-11-09 Thread Etelson, Gregory
Hello Ferruh, Indirect actions list arguments parser was configured to place target number into 64bit value, while the code provided 32bits memory. Hi Gregory, Can you please give more details why 'id' needs to be 64 bits, with callstack or usecase etc? And please describe what is the observ

Re: [PATCH] app/testpmd: fix indirect action list parameters parsing

2023-11-09 Thread Ferruh Yigit
On 11/9/2023 6:22 PM, Etelson, Gregory wrote: > Hello Ferruh, > >>> Indirect actions list arguments parser was configured to place target >>> number into 64bit value, while the code provided 32bits memory. >>> >> >> Hi Gregory, >> >> Can you please give more details why 'id' needs to be 64 bits, w

Re: [PATCH] app/testpmd: fix indirect action list parameters parsing

2023-11-09 Thread Etelson, Gregory
Hello Ferruh, Indirect actions list arguments parser was configured to place target number into 64bit value, while the code provided 32bits memory. Hi Gregory, Can you please give more details why 'id' needs to be 64 bits, with callstack or usecase etc? And please describe what is the observ

Re: [PATCH] app/testpmd: fix indirect action list parameters parsing

2023-11-09 Thread Ferruh Yigit
On 11/8/2023 4:34 PM, Gregory Etelson wrote: > Indirect actions list arguments parser was configured to place target > number into 64bit value, while the code provided 32bits memory. > Hi Gregory, Can you please give more details why 'id' needs to be 64 bits, with callstack or usecase etc? And p

[PATCH] app/testpmd: fix indirect action list parameters parsing

2023-11-08 Thread Gregory Etelson
Indirect actions list arguments parser was configured to place target number into 64bit value, while the code provided 32bits memory. The patch updated variable size for translation results. Fixes: 72a3dec7126f ("ethdev: add indirect flow list action") Signed-off-by: Gregory Etelson --- app/tes