Re: [PATCH] app/testpmd: fix crash on cleanup

2023-02-17 Thread Ferruh Yigit
On 2/17/2023 7:14 AM, Singh, Aman Deep wrote: > > On 2/6/2023 9:19 PM, David Marchand wrote: >> If allocating the ports[] array fails, a crash will occur when shutting >> down testpmd since ethdev emits RTE_ETH_EVENT_DESTROY events. >> Move init_port() before registering ethdev event handler. > >

Re: [PATCH] app/testpmd: fix crash on cleanup

2023-02-16 Thread Singh, Aman Deep
On 2/6/2023 9:19 PM, David Marchand wrote: If allocating the ports[] array fails, a crash will occur when shutting down testpmd since ethdev emits RTE_ETH_EVENT_DESTROY events. Move init_port() before registering ethdev event handler. Looks ok to me. Avoids seg_fault, due to Null pointer acce

[PATCH] app/testpmd: fix crash on cleanup

2023-02-06 Thread David Marchand
If allocating the ports[] array fails, a crash will occur when shutting down testpmd since ethdev emits RTE_ETH_EVENT_DESTROY events. Move init_port() before registering ethdev event handler. Fixes: 85c6571c9103 ("app/testpmd: reset port status on close notification") Cc: sta...@dpdk.org Signed-o