Re: [PATCH] app/testpmd: fix auto completion for indirect list action

2024-03-23 Thread Gregory Etelson
Hello Ferruh, > But I guess it won't catch this issue, as it uses full flow commands. > This issue is related to the testpmd command parsing code. I wonder if > we can find a way to verify testpmd parsing code? What if flow command validation program breaks a tested command into tokens and then

Re: [PATCH] app/testpmd: fix auto completion for indirect list action

2024-03-20 Thread Patrick Robb
On Wed, Mar 20, 2024 at 6:08 AM Ferruh Yigit wrote: > > On 3/20/2024 6:06 AM, Gregory Etelson wrote: > > Hello Ferruh, > > > >>BUT overall how can we catch issues like this in the feature, we don't > >>have a good way to test testpmd flow commands. > >>@Ori, @Gregory, do you have any idea? > >>cc'

Re: [PATCH] app/testpmd: fix auto completion for indirect list action

2024-03-20 Thread Ferruh Yigit
On 3/20/2024 6:06 AM, Gregory Etelson wrote: > Hello Ferruh, > >>BUT overall how can we catch issues like this in the feature, we don't >>have a good way to test testpmd flow commands. >>@Ori, @Gregory, do you have any idea? >>cc'ed CI mail list too. > > We have a tool for unit tests based on the

Re: [PATCH] app/testpmd: fix auto completion for indirect list action

2024-03-19 Thread Gregory Etelson
Hello Ferruh, >BUT overall how can we catch issues like this in the feature, we don't >have a good way to test testpmd flow commands. >@Ori, @Gregory, do you have any idea? >cc'ed CI mail list too. We have a tool for unit tests based on the testpmd. The tool details are here: https://drive.goog

Re: [PATCH] app/testpmd: fix auto completion for indirect list action

2024-03-19 Thread Ferruh Yigit
On 3/19/2024 3:29 PM, Ferruh Yigit wrote: > On 3/19/2024 2:51 PM, Ferruh Yigit wrote: >> On 3/18/2024 9:21 AM, Shani Peretz wrote: >>> In the process of auto completion of a command in testpmd, >>> the parser splits the command into tokens, where each token >>> represents an argument and defines a

Re: [PATCH] app/testpmd: fix auto completion for indirect list action

2024-03-19 Thread Ferruh Yigit
On 3/19/2024 2:51 PM, Ferruh Yigit wrote: > On 3/18/2024 9:21 AM, Shani Peretz wrote: >> In the process of auto completion of a command in testpmd, >> the parser splits the command into tokens, where each token >> represents an argument and defines a parsing function. >> The parsing function of the

Re: [PATCH] app/testpmd: fix auto completion for indirect list action

2024-03-19 Thread Ferruh Yigit
On 3/18/2024 9:21 AM, Shani Peretz wrote: > In the process of auto completion of a command in testpmd, > the parser splits the command into tokens, where each token > represents an argument and defines a parsing function. > The parsing function of the indirect_list action argument was returning > b

[PATCH] app/testpmd: fix auto completion for indirect list action

2024-03-18 Thread Shani Peretz
In the process of auto completion of a command in testpmd, the parser splits the command into tokens, where each token represents an argument and defines a parsing function. The parsing function of the indirect_list action argument was returning before having the opportunity to handle the argument.