RE: [PATCH] app/testpmd: fix VLAN header parsing

2025-03-29 Thread Morten Brørup
> From: Raslan Darawsheh [mailto:rasl...@nvidia.com] > Sent: Sunday, 23 March 2025 13.28 > > Updated the `get_ethertype_by_ptype` function to correctly parse VLAN > headers. > > Fixes: 76730c7b9b5a ("app/testpmd: use packet type parsing API") > Cc: haij...@huawei.com > > Signed-off-by: Raslan Da

Re: [PATCH] app/testpmd: fix VLAN header parsing

2025-03-24 Thread Thomas Monjalon
23/03/2025 13:28, Raslan Darawsheh: > Updated the `get_ethertype_by_ptype` function to correctly parse VLAN > headers. You should describe what is broken and how. > Fixes: 76730c7b9b5a ("app/testpmd: use packet type parsing API") > Cc: haij...@huawei.com Do you think it is critical for the relea

RE: [PATCH] app/testpmd: fix VLAN header parsing

2025-03-24 Thread Morten Brørup
Answer inline below. From: Raslan Darawsheh [mailto:rasl...@nvidia.com] Sent: Monday, 24 March 2025 09.32 Comment inline below. From: Raslan Darawsheh [mailto:rasl...@nvidia.com] Sent: Monday, 24 March 2025 08.35 >> From: Raslan Darawsheh [mailto:rasl...@nvidia.com] >> Sent: Sunday

Re: [PATCH] app/testpmd: fix VLAN header parsing

2025-03-24 Thread Raslan Darawsheh
>> Updated the `get_ethertype_by_ptype` function to correctly parse VLAN >> headers. >You should describe what is broken and how. I’ll handle in v2 >> Fixes: 76730c7b9b5a ("app/testpmd: use packet type parsing API") >> Cc: haij...@huawei.com >Do you think it is critical for the release? Yes, as

Re: [PATCH] app/testpmd: fix VLAN header parsing

2025-03-24 Thread Raslan Darawsheh
Comment inline below. From: Raslan Darawsheh [mailto:rasl...@nvidia.com] Sent: Monday, 24 March 2025 08.35 >> From: Raslan Darawsheh [mailto:rasl...@nvidia.com] >> Sent: Sunday, 23 March 2025 13.28 >> >> Updated the `get_ethertype_by_ptype` function to correctly parse VLAN >> headers. >> >> Fixes

Re: [PATCH] app/testpmd: fix VLAN header parsing

2025-03-24 Thread Raslan Darawsheh
>> From: Raslan Darawsheh [mailto:rasl...@nvidia.com] >> Sent: Sunday, 23 March 2025 13.28 >> >> Updated the `get_ethertype_by_ptype` function to correctly parse VLAN >> headers. >> >> Fixes: 76730c7b9b5a ("app/testpmd: use packet type parsing API") >> Cc: haij...@huawei.com >> >>> Signed-off-by: R

RE: [PATCH] app/testpmd: fix VLAN header parsing

2025-03-24 Thread Morten Brørup
Comment inline below. From: Raslan Darawsheh [mailto:rasl...@nvidia.com] Sent: Monday, 24 March 2025 08.35 >> From: Raslan Darawsheh [mailto:rasl...@nvidia.com] >> Sent: Sunday, 23 March 2025 13.28 >> >> Updated the `get_ethertype_by_ptype` function to correctly parse VLAN >> headers. >>

Recall: [PATCH] app/testpmd: fix VLAN header parsing

2025-03-24 Thread Morten Brørup
Morten Brørup would like to recall the message, "[PATCH] app/testpmd: fix VLAN header parsing".

RE: [PATCH] app/testpmd: fix VLAN header parsing

2025-03-24 Thread Morten Brørup
Comment inline below. From: Raslan Darawsheh [mailto:rasl...@nvidia.com] Sent: Monday, 24 March 2025 08.35 >> From: Raslan Darawsheh [mailto:rasl...@nvidia.com] >> Sent: Sunday, 23 March 2025 13.28 >> >> Updated the `get_ethertype_by_ptype` function to correctly parse VLAN >> headers. >

Re: [PATCH] app/testpmd: fix VLAN header parsing

2025-03-24 Thread Raslan Darawsheh
>> Signed-off-by: Raslan Darawsheh >> --- >> app/test-pmd/csumonly.c | 8 +--- >> 1 file changed, 5 insertions(+), 3 deletions(-) >> >> diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c >> index 5b906eaa53..302cc4cc66 100644 >> --- a/app/test-pmd/csumonly.c >> +++ b/app/test-pmd

Re: [PATCH] app/testpmd: fix VLAN header parsing

2025-03-23 Thread Stephen Hemminger
On Sun, 23 Mar 2025 14:28:22 +0200 Raslan Darawsheh wrote: > Signed-off-by: Raslan Darawsheh > --- > app/test-pmd/csumonly.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c > index 5b906eaa53..302cc4cc66 100644

[PATCH] app/testpmd: fix VLAN header parsing

2025-03-23 Thread Raslan Darawsheh
Updated the `get_ethertype_by_ptype` function to correctly parse VLAN headers. Fixes: 76730c7b9b5a ("app/testpmd: use packet type parsing API") Cc: haij...@huawei.com Signed-off-by: Raslan Darawsheh --- app/test-pmd/csumonly.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff