Matz, Olivier ; De Lara Guarch, Pablo
>
> Subject: Re: [PATCH] app/test-pmd: fix L4 checksum with padding data
>
> On 11/20/2023 9:21 AM, Deng, KaiwenX wrote:
> >
> >
> >> -Original Message-
> >> From: Ferruh Yigit
> >> Sent: Friday, N
On 11/17/2023 4:22 PM, Stephen Hemminger wrote:
> On Fri, 17 Nov 2023 09:29:41 +
> Ferruh Yigit wrote:
>
I agree using 'l3_len' instead is correct fix.
But this requires ABI/API change,
plus do we have any reason to keep the padding, discarding it as this
patch does i
X
>> ; Singh, Aman Deep ;
>> Zhang, Yuying ; Matz, Olivier
>> ; De Lara Guarch, Pablo
>>
>> Subject: Re: [PATCH] app/test-pmd: fix L4 checksum with padding data
>>
>> On 11/16/2023 10:58 PM, Stephen Hemminger wrote:
>>> On Thu, 2 Nov 2023 19:20:
Subject: Re: [PATCH] app/test-pmd: fix L4 checksum with padding data
>
> On 8/4/2023 9:28 AM, Kaiwen Deng wrote:
> > IEEE 802 packets may have a minimum size limit. The data fields should
> > be padded when necessary. In some cases, the padding data is not zero.
> > Testpm
Guarch, Pablo
>
> Subject: Re: [PATCH] app/test-pmd: fix L4 checksum with padding data
>
> On 11/16/2023 10:58 PM, Stephen Hemminger wrote:
> > On Thu, 2 Nov 2023 19:20:07 +
> > Ferruh Yigit wrote:
> >
> >> On 8/4/2023 9:28 AM, Kaiwen Deng wrote:
>
On Fri, 17 Nov 2023 13:11:50 +0100
Morten Brørup wrote:
> > rte_ipv4_udptcp_cksum_mbuf() and rte_ipv6_udptcp_cksum_mbuf() are
> > inline
> > functions, unfortunately we can't version them.
> >
> > But those functions already gets IP header as parameter, can't we use
> > IP
> > header to get the
On Fri, 17 Nov 2023 09:29:41 +
Ferruh Yigit wrote:
> >> I agree using 'l3_len' instead is correct fix.
> >>
> >> But this requires ABI/API change,
> >> plus do we have any reason to keep the padding, discarding it as this
> >> patch does is also simpler alternative.
> >
> >
> > Possibly a
> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com]
> Sent: Friday, 17 November 2023 10.30
>
> On 11/17/2023 3:28 AM, Stephen Hemminger wrote:
> > On Fri, 17 Nov 2023 00:50:16 +
> > Ferruh Yigit wrote:
> >
> Hi Kaiwen,
>
> I am trying to understand the problem, what is the testc
On 11/17/2023 3:28 AM, Stephen Hemminger wrote:
> On Fri, 17 Nov 2023 00:50:16 +
> Ferruh Yigit wrote:
>
Hi Kaiwen,
I am trying to understand the problem, what is the testcase that has
checksum error?
Are the received mbuf data_len & pkt_len wrong? Instead of try
On Fri, 17 Nov 2023 00:50:16 +
Ferruh Yigit wrote:
> >> Hi Kaiwen,
> >>
> >> I am trying to understand the problem, what is the testcase that has
> >> checksum error?
> >>
> >> Are the received mbuf data_len & pkt_len wrong? Instead of trying to fix
> >> the mbuf during forwarding, can we fix
On 8/4/2023 9:28 AM, Kaiwen Deng wrote:
> IEEE 802 packets may have a minimum size limit. The data fields
> should be padded when necessary. In some cases, the padding data
> is not zero. Testpmd does not trim these IP packets to the true
> length of the frame, so errors will occur when calculating
On 11/16/2023 10:58 PM, Stephen Hemminger wrote:
> On Thu, 2 Nov 2023 19:20:07 +
> Ferruh Yigit wrote:
>
>> On 8/4/2023 9:28 AM, Kaiwen Deng wrote:
>>> IEEE 802 packets may have a minimum size limit. The data fields
>>> should be padded when necessary. In some cases, the padding data
>>> is n
On Thu, 2 Nov 2023 19:20:07 +
Ferruh Yigit wrote:
> On 8/4/2023 9:28 AM, Kaiwen Deng wrote:
> > IEEE 802 packets may have a minimum size limit. The data fields
> > should be padded when necessary. In some cases, the padding data
> > is not zero. Testpmd does not trim these IP packets to the t
, KaiwenX ; dev@dpdk.org
> >> Cc: sta...@dpdk.org; Yang, Qiming ; Zhou,
> >> YidingX ; Singh, Aman Deep
> >> ; Zhang, Yuying ;
> >> Matz, Olivier ; De Lara Guarch, Pablo
> >>
> >> Subject: Re: [PATCH] app/test-pmd: fix L4 checksum with
an Deep ;
>> Zhang, Yuying ; Matz, Olivier
>> ; De Lara Guarch, Pablo
>>
>> Subject: Re: [PATCH] app/test-pmd: fix L4 checksum with padding data
>>
>> On 11/3/2023 2:49 AM, Deng, KaiwenX wrote:
>>>
>>>
>>>> -Original Message-
>&g
, KaiwenX ; dev@dpdk.org
> >> Cc: sta...@dpdk.org; Yang, Qiming ; Zhou,
> >> YidingX ; Singh, Aman Deep
> >> ; Zhang, Yuying ;
> >> Matz, Olivier ; De Lara Guarch, Pablo
> >>
> >> Subject: Re: [PATCH] app/test-pmd: fix L4 checksum with padding da
;
>> Zhang, Yuying ; Matz, Olivier
>> ; De Lara Guarch, Pablo
>>
>> Subject: Re: [PATCH] app/test-pmd: fix L4 checksum with padding data
>>
>> On 8/4/2023 9:28 AM, Kaiwen Deng wrote:
>>> IEEE 802 packets may have a minimum size limit. The data
Subject: Re: [PATCH] app/test-pmd: fix L4 checksum with padding data
>
> On 8/4/2023 9:28 AM, Kaiwen Deng wrote:
> > IEEE 802 packets may have a minimum size limit. The data fields should
> > be padded when necessary. In some cases, the padding data is not zero.
> > Testpm
On 8/4/2023 9:28 AM, Kaiwen Deng wrote:
> IEEE 802 packets may have a minimum size limit. The data fields
> should be padded when necessary. In some cases, the padding data
> is not zero. Testpmd does not trim these IP packets to the true
> length of the frame, so errors will occur when calculating
IEEE 802 packets may have a minimum size limit. The data fields
should be padded when necessary. In some cases, the padding data
is not zero. Testpmd does not trim these IP packets to the true
length of the frame, so errors will occur when calculating TCP
or UDP checksum.
This commit fixes this is
20 matches
Mail list logo
