Re: [PATCH] acl: fix trie splitting

2023-02-08 Thread Arthur Leung
Hi Konstantin Thanks for the explanation and examples, I see I've misunderstood "node limit for tree split" to mean "the limit of the total number of nodes in a tree", rather than the intended logic of "the limit of new nodes that can be created in a trie as a result of merging". Sorry for the bo

Re: [PATCH] acl: fix trie splitting

2023-02-05 Thread Konstantin Ananyev
It is not really clear to me what is the actual problem and what are you trying to fix here... When using a large number of ACL rules, the trie is supposed to split when there are over 2048 nodes. What do you mean by 'there'? As I remember, it decided to split set of rules, when trie start

[PATCH] acl: fix trie splitting

2023-02-01 Thread Arthur Leung
When using a large number of ACL rules, the trie is supposed to split when there are over 2048 nodes. However, node_count is negative, so node_count > context->cur_node_max never actually runs, so all the nodes created from the rules end up being in one trie. Original PR with sample files and te