Re: [PATCH] RFC: use C11 alignas instead of GCC attribute aligned

2024-01-31 Thread Mattias Rönnblom
On 2024-01-30 18:39, Tyler Retzlaff wrote: On Tue, Jan 30, 2024 at 09:08:21AM +0100, Mattias Rönnblom wrote: On 2024-01-29 20:43, Tyler Retzlaff wrote: On Sun, Jan 28, 2024 at 11:00:31AM +0100, Mattias Rönnblom wrote: On 2024-01-28 09:57, Morten Brørup wrote: From: Mattias Rönnblom [mailto:ho

Re: [PATCH] RFC: use C11 alignas instead of GCC attribute aligned

2024-01-30 Thread Mattias Rönnblom
On 2024-01-30 18:59, Bruce Richardson wrote: On Tue, Jan 30, 2024 at 09:39:28AM -0800, Tyler Retzlaff wrote: On Tue, Jan 30, 2024 at 09:08:21AM +0100, Mattias Rönnblom wrote: Sorry if I've missed some discussion on the list, but the current pattern of putting __rte_aligned(X) at the end does

Re: [PATCH] RFC: use C11 alignas instead of GCC attribute aligned

2024-01-30 Thread Tyler Retzlaff
On Tue, Jan 30, 2024 at 05:59:25PM +, Bruce Richardson wrote: > On Tue, Jan 30, 2024 at 09:39:28AM -0800, Tyler Retzlaff wrote: > > On Tue, Jan 30, 2024 at 09:08:21AM +0100, Mattias Rönnblom wrote: > > > > > > > Sorry if I've missed some discussion on the list, but the current > > > pattern o

Re: [PATCH] RFC: use C11 alignas instead of GCC attribute aligned

2024-01-30 Thread Bruce Richardson
On Tue, Jan 30, 2024 at 05:59:25PM +, Bruce Richardson wrote: > On Tue, Jan 30, 2024 at 09:39:28AM -0800, Tyler Retzlaff wrote: > > On Tue, Jan 30, 2024 at 09:08:21AM +0100, Mattias Rönnblom wrote: > > > > > > > Sorry if I've missed some discussion on the list, but the current > > > pattern o

Re: [PATCH] RFC: use C11 alignas instead of GCC attribute aligned

2024-01-30 Thread Bruce Richardson
On Tue, Jan 30, 2024 at 09:39:28AM -0800, Tyler Retzlaff wrote: > On Tue, Jan 30, 2024 at 09:08:21AM +0100, Mattias Rönnblom wrote: > > > > Sorry if I've missed some discussion on the list, but the current > > pattern of putting __rte_aligned(X) at the end doesn't work with MSVC, > > or why are w

Re: [PATCH] RFC: use C11 alignas instead of GCC attribute aligned

2024-01-30 Thread Tyler Retzlaff
On Tue, Jan 30, 2024 at 09:09:20AM +0100, Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Monday, 29 January 2024 20.44 > > > > On Sun, Jan 28, 2024 at 11:00:31AM +0100, Mattias Rönnblom wrote: > > > On 2024-01-28 09:57, Morten Brørup wrote: > > > >>Fr

Re: [PATCH] RFC: use C11 alignas instead of GCC attribute aligned

2024-01-30 Thread Tyler Retzlaff
On Tue, Jan 30, 2024 at 09:08:21AM +0100, Mattias Rönnblom wrote: > On 2024-01-29 20:43, Tyler Retzlaff wrote: > >On Sun, Jan 28, 2024 at 11:00:31AM +0100, Mattias Rönnblom wrote: > >>On 2024-01-28 09:57, Morten Brørup wrote: > From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: S

RE: [PATCH] RFC: use C11 alignas instead of GCC attribute aligned

2024-01-30 Thread Morten Brørup
> From: Morten Brørup [mailto:m...@smartsharesystems.com] > Sent: Tuesday, 30 January 2024 11.17 > > > From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > > Sent: Tuesday, 30 January 2024 10.28 > > > > On 2024-01-30 09:09, Morten Brørup wrote: > > >> From: Tyler Retzlaff [mailto:roret...@linux

RE: [PATCH] RFC: use C11 alignas instead of GCC attribute aligned

2024-01-30 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Tuesday, 30 January 2024 10.28 > > On 2024-01-30 09:09, Morten Brørup wrote: > >> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > >> Sent: Monday, 29 January 2024 20.44 > >> > >> On Sun, Jan 28, 2024 at 11:00:31AM +0100,

Re: [PATCH] RFC: use C11 alignas instead of GCC attribute aligned

2024-01-30 Thread Mattias Rönnblom
On 2024-01-30 09:09, Morten Brørup wrote: From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] Sent: Monday, 29 January 2024 20.44 On Sun, Jan 28, 2024 at 11:00:31AM +0100, Mattias Rönnblom wrote: On 2024-01-28 09:57, Morten Brørup wrote: From: Mattias Rönnblom [mailto:hof...@lysator.liu

RE: [PATCH] RFC: use C11 alignas instead of GCC attribute aligned

2024-01-30 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Monday, 29 January 2024 20.44 > > On Sun, Jan 28, 2024 at 11:00:31AM +0100, Mattias Rönnblom wrote: > > On 2024-01-28 09:57, Morten Brørup wrote: > > >>From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > > >>Sent: Saturday, 2

Re: [PATCH] RFC: use C11 alignas instead of GCC attribute aligned

2024-01-30 Thread Mattias Rönnblom
On 2024-01-29 20:43, Tyler Retzlaff wrote: On Sun, Jan 28, 2024 at 11:00:31AM +0100, Mattias Rönnblom wrote: On 2024-01-28 09:57, Morten Brørup wrote: From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] Sent: Saturday, 27 January 2024 20.15 On 2024-01-26 11:18, Morten Brørup wrote: From: Ma

Re: [PATCH] RFC: use C11 alignas instead of GCC attribute aligned

2024-01-29 Thread Tyler Retzlaff
On Sun, Jan 28, 2024 at 11:00:31AM +0100, Mattias Rönnblom wrote: > On 2024-01-28 09:57, Morten Brørup wrote: > >>From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > >>Sent: Saturday, 27 January 2024 20.15 > >> > >>On 2024-01-26 11:18, Morten Brørup wrote: > From: Mattias Rönnblom [mailto:h

Re: [PATCH] RFC: use C11 alignas instead of GCC attribute aligned

2024-01-28 Thread Mattias Rönnblom
On 2024-01-28 09:57, Morten Brørup wrote: From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] Sent: Saturday, 27 January 2024 20.15 On 2024-01-26 11:18, Morten Brørup wrote: From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] Sent: Friday, 26 January 2024 11.05 On 2024-01-25 23:53, Morten

RE: [PATCH] RFC: use C11 alignas instead of GCC attribute aligned

2024-01-28 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Saturday, 27 January 2024 20.15 > > On 2024-01-26 11:18, Morten Brørup wrote: > >> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > >> Sent: Friday, 26 January 2024 11.05 > >> > >> On 2024-01-25 23:53, Morten Brørup wrote: > >>

Re: [PATCH] RFC: use C11 alignas instead of GCC attribute aligned

2024-01-27 Thread Mattias Rönnblom
On 2024-01-26 11:18, Morten Brørup wrote: From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] Sent: Friday, 26 January 2024 11.05 On 2024-01-25 23:53, Morten Brørup wrote: From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] Sent: Thursday, 25 January 2024 19.37 ping. Please review th

RE: [PATCH] RFC: use C11 alignas instead of GCC attribute aligned

2024-01-26 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Friday, 26 January 2024 11.05 > > On 2024-01-25 23:53, Morten Brørup wrote: > >> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > >> Sent: Thursday, 25 January 2024 19.37 > >> > >> ping. > >> > >> Please review this thread

Re: [PATCH] RFC: use C11 alignas instead of GCC attribute aligned

2024-01-26 Thread Mattias Rönnblom
On 2024-01-25 23:53, Morten Brørup wrote: From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] Sent: Thursday, 25 January 2024 19.37 ping. Please review this thread if you have time, the main point of discussion I would like to receive consensus on the following questions. 1. Should we c

Re: [PATCH] RFC: use C11 alignas instead of GCC attribute aligned

2024-01-25 Thread Tyler Retzlaff
On Thu, Jan 25, 2024 at 11:53:04PM +0100, Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Thursday, 25 January 2024 19.37 > > > > ping. > > > > Please review this thread if you have time, the main point of > > discussion > > I would like to receive co

RE: [PATCH] RFC: use C11 alignas instead of GCC attribute aligned

2024-01-25 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Thursday, 25 January 2024 19.37 > > ping. > > Please review this thread if you have time, the main point of > discussion > I would like to receive consensus on the following questions. > > 1. Should we continue to expand common

Re: [PATCH] RFC: use C11 alignas instead of GCC attribute aligned

2024-01-25 Thread Tyler Retzlaff
ping. Please review this thread if you have time, the main point of discussion I would like to receive consensus on the following questions. 1. Should we continue to expand common alignments behind an __rte_macro i.e. what do we prefer to appear in code alignas(RTE_CACHE_LINE_MIN_SIZE) -

[PATCH] RFC: use C11 alignas instead of GCC attribute aligned

2023-11-15 Thread Tyler Retzlaff
Now that we require a C11 conformant toolchain we are able to improve portability by further adoption of C11 features. Adapt EAL to use C11 alignas replacing __rte_cache_aligned and __rte_aligned(a) that expand to __attribute__((__aligned__(a))). Note: it appears that use of alignas has exposed a