Re: [EXT] Re: [PATCH v2] lib/dmadev: get DMA device using device ID

2024-02-09 Thread Thomas Monjalon
09/02/2024 12:30, Amit Prakash Shukla: > > > > > > > > > > invoke (*dev->dev_ops->dma_adapter_vchan_add)(dev, dma_dev_id, > > > > vchan, event), > > > > > > > > at cnxk driver, this ops will check whether the DMA is > > > > cnxk_dmadev_pci_driver. > > > > > > > > I think this is because the cnxk'

RE: [EXT] Re: [PATCH v2] lib/dmadev: get DMA device using device ID

2024-02-09 Thread Amit Prakash Shukla
> > > > > > invoke (*dev->dev_ops->dma_adapter_vchan_add)(dev, dma_dev_id, > > > vchan, event), > > > > > > at cnxk driver, this ops will check whether the DMA is > > > cnxk_dmadev_pci_driver. > > > > > > I think this is because the cnxk's event-and-dma implement has deep > > > coupling > > > >

Re: [EXT] Re: [PATCH v2] lib/dmadev: get DMA device using device ID

2024-02-09 Thread Thomas Monjalon
09/02/2024 12:05, Amit Prakash Shukla: > > On 2024/2/9 0:25, Thomas Monjalon wrote: > > > 19/12/2023 12:00, Amit Prakash Shukla: > > >> +struct rte_dma_dev * > > >> +rte_dma_pmd_get_dev_by_id(const int dev_id) > > > const does not make sense here for an int parameter. > > > > > > I think it could

RE: [EXT] Re: [PATCH v2] lib/dmadev: get DMA device using device ID

2024-02-09 Thread Amit Prakash Shukla
Hi Thomas and Chengwen, Thank you for the review and feedback. Please find my comment in-line. Thanks, Amit Shukla > -- > Hi Thomas, > > > On 2024/2/9 0:25, Thomas Monjalon wrote: > > 19/12/2023 12:00, Amit Prakash Shukla: > >