Re: [[PATCH v1] 4/8] net/rnp: add mbx basic api feature

2023-08-01 Thread Stephen Hemminger
On Wed, 2 Aug 2023 09:41:29 +0800 "11" wrote: > Hi Stephen, > > Thanks for your comment, as your advice that I need to define the virtual > function pointers > As the below type ? No, keep the struct the same, but make it const where used. You also do a copy of the ops struct so the one you ini

RE: [[PATCH v1] 4/8] net/rnp: add mbx basic api feature

2023-08-01 Thread 11
ephen Hemminger Sent: 2023年8月1日 23:26 To: Wenbo Cao Cc: dev@dpdk.org Subject: Re: [[PATCH v1] 4/8] net/rnp: add mbx basic api feature On Tue, 1 Aug 2023 07:22:07 + Wenbo Cao wrote: > +struct rnp_mbx_api { > + void (*init_mbx)(struct rnp_hw *hw); > + int32_t (*read)(str

Re: [[PATCH v1] 4/8] net/rnp: add mbx basic api feature

2023-08-01 Thread Stephen Hemminger
On Tue, 1 Aug 2023 07:22:07 + Wenbo Cao wrote: > +struct rnp_mbx_api { > + void (*init_mbx)(struct rnp_hw *hw); > + int32_t (*read)(struct rnp_hw *hw, > + uint32_t *msg, > + uint16_t size, > + enum MBX_ID); > + int32_t (

[[PATCH v1] 4/8] net/rnp: add mbx basic api feature

2023-08-01 Thread Wenbo Cao
mbx base code is for communicate with the firmware Signed-off-by: Wenbo Cao --- drivers/net/rnp/base/rnp_hw.h | 107 ++- drivers/net/rnp/meson.build | 1 + drivers/net/rnp/rnp.h | 35 +++ drivers/net/rnp/rnp_ethdev.c | 68 + drivers/net/rnp/rnp_logs.h| 9 + drivers/n

[[PATCH v1] 4/8] net/rnp: add mbx basic api feature

2023-08-01 Thread Wenbo Cao
mbx base code is for communicate with the firmware Signed-off-by: Wenbo Cao --- drivers/net/rnp/base/rnp_hw.h | 107 ++- drivers/net/rnp/meson.build | 1 + drivers/net/rnp/rnp.h | 35 +++ drivers/net/rnp/rnp_ethdev.c | 68 + drivers/net/rnp/rnp_logs.h| 9 + drivers/n