RE: [PATCH v2 1/1] vhost: fix a double fetch when dequeue offloading

2025-02-13 Thread Wangyunjian(wangyunjian,TongTu)
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Saturday, December 21, 2024 1:11 AM > To: Wangyunjian(wangyunjian,TongTu) > Cc: dev@dpdk.org; maxime.coque...@redhat.com; chen...@nvidia.com; > Lilijun (Jerry) ; xiawei (H) ; &g

RE: [PATCH 1/1] vhost: fix a double fetch when dequeue offloading

2024-12-22 Thread Wangyunjian(wangyunjian,TongTu)
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Saturday, December 21, 2024 12:36 AM > To: Wangyunjian(wangyunjian,TongTu) > Cc: dev@dpdk.org; maxime.coque...@redhat.com; chen...@nvidia.com; > Lilijun (Jerry) ; xiawei (H

RE: [PATCH 1/1] vhost: fix a double fetch when dequeue offloading

2024-12-19 Thread Wangyunjian(wangyunjian,TongTu)
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, December 20, 2024 12:16 AM > To: Wangyunjian(wangyunjian,TongTu) > Cc: dev@dpdk.org; maxime.coque...@redhat.com; chen...@nvidia.com; > Lilijun (Jerry) ; xiawei (H) ; &g

RE: [PATCH 1/1] vhost: fix a double fetch when dequeue offloading

2024-12-19 Thread Wangyunjian(wangyunjian,TongTu)
> -Original Message- > From: David Marchand [mailto:david.march...@redhat.com] > Sent: Thursday, December 19, 2024 4:24 PM > To: Wangyunjian(wangyunjian,TongTu) ; > maxime.coque...@redhat.com > Cc: dev@dpdk.org; chen...@nvidia.com; Lilijun (Jerry) > ; xiawei (H) ;

RE: [PATCH] net/virtio: fix Rx checksum calculation

2024-12-17 Thread Wangyunjian(wangyunjian,TongTu)
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Tuesday, December 17, 2024 11:33 PM > To: dev@dpdk.org > Cc: Olivier Matz ; Maxime Gouin > ; Maxime Coquelin > > Subject: [PATCH] net/virtio: fix Rx checksum calculation > > From: Olivier Matz > > I

RE: txgbe: vlan offload setting errors

2024-12-09 Thread Wangyunjian(wangyunjian,TongTu)
> -Original Message- > From: Jiawen Wu [mailto:jiawe...@trustnetic.com] > Sent: Tuesday, December 10, 2024 10:00 AM > To: Wangyunjian(wangyunjian,TongTu) ; > dev@dpdk.org > Cc: liwei (DT) ; xiawei (H) > Subject: RE: txgbe: vlan offload setting errors > &

txgbe: vlan offload setting errors

2024-12-09 Thread Wangyunjian(wangyunjian,TongTu)
Hello everyone, I recently added a txgbe port and enabled vlan offload. However, when I checked the dpdk logs, I noticed the following error: "2024-12-09T10:32:26.420709+08:00 txgbe_vlan_offload_set(): Please stop port first." Upon reviewing the txgbe pmd driver code, I discovered that the va

RE: [PATCH] net/af_xdp: fix resources leak when xsk configure fails

2024-02-22 Thread wangyunjian
> -Original Message- > From: Loftus, Ciara [mailto:ciara.lof...@intel.com] > Sent: Thursday, February 22, 2024 7:06 PM > To: Tahhan, Maryam ; wangyunjian > > Cc: dev@dpdk.org; ferruh.yi...@amd.com; sta...@dpdk.org > Subject: RE: [PATCH] net/af_xdp: fix resources le

RE: [dpdk-dev] [PATCH] net/af_xdp: fix memzone leak in error path

2023-12-05 Thread wangyunjian
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > Sent: Tuesday, December 5, 2023 5:42 PM > To: wangyunjian ; dev@dpdk.org > Cc: ciara.lof...@intel.com; qi.z.zh...@intel.com; xudingke > ; Lilijun (Jerry) ; > sta...@dpdk.org > Subject: Re

RE: [dpdk-dev] [PATCH] net/af_xdp: fix memzone leak in error path

2023-12-04 Thread wangyunjian
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > Sent: Monday, December 4, 2023 10:10 PM > To: wangyunjian ; dev@dpdk.org > Cc: ciara.lof...@intel.com; qi.z.zh...@intel.com; xudingke > ; Lilijun (Jerry) ; > sta...@dpdk.org > Subject: Re

RE: [dpdk-dev] [PATCH 1/1] eal: fix error log in rte_dev_probe

2023-05-24 Thread wangyunjian
> -Original Message- > From: David Marchand [mailto:david.march...@redhat.com] > Sent: Thursday, January 5, 2023 4:34 PM > To: wangyunjian ; Thomas Monjalon > > Cc: dev@dpdk.org; qi.z.zh...@intel.com; anatoly.bura...@intel.com; > Huangshaozhang ; sta...@dpdk.org; &g

RE: [dpdk-dev] [PATCH v2] ring: fix use after free in ring release

2023-05-04 Thread wangyunjian
> -Original Message- > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Thursday, May 4, 2023 7:46 AM > To: Konstantin Ananyev ; wangyunjian > > Cc: dev@dpdk.org; luyicai ; sta...@dpdk.org; nd > ; nd > Subject: RE: [dpdk-dev] [PATCH v2]

RE: [dpdk-dev] [PATCH] ring: fix use after free in ring release

2023-04-19 Thread wangyunjian
> -Original Message- > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Thursday, April 20, 2023 5:44 AM > To: wangyunjian ; dev@dpdk.org > Cc: konstantin.v.anan...@yandex.ru; luyicai ; > sta...@dpdk.org; nd ; nd > Subject: RE: [dpdk-dev]

RE: [dpdk-dev] [PATCH] ring: fix use after free in ring release

2023-04-19 Thread wangyunjian
> -Original Message- > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Wednesday, April 19, 2023 7:53 AM > To: wangyunjian ; dev@dpdk.org > Cc: konstantin.v.anan...@yandex.ru; luyicai ; > sta...@dpdk.org; nd ; Honnappa Nagarahalli > ; nd

The link status of the 82599 NIC cannot be setted to down

2022-12-16 Thread wangyunjian
Hi All, It is expected that the ixgbe_dev_set_link_down function is called to make the link status of the NIC down. However, the invoking is successful, but link status is still up. Anyone have some good ideas? dpdk version:DPDK 21.11 firmware-version:0x86d5 NIC:Intel Corporation 82599 10 G

RE: [dpdk-dev] [PATCH v2 2/2] net/mlx5: fix resource leak when releasing a drop action

2022-09-28 Thread wangyunjian
I agree with you. Can you fix it? Thanks Yunjian > -Original Message- > From: Slava Ovsiienko [mailto:viachesl...@nvidia.com] > Sent: Tuesday, September 27, 2022 3:36 AM > To: wangyunjian ; dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Dmitry Kozlyuk

RE: [dpdk-dev] [PATCH v2 2/2] net/mlx5: fix resource leak when releasing a drop action

2022-09-23 Thread wangyunjian
Friendly ping. > -Original Message- > From: wangyunjian > Sent: Tuesday, August 23, 2022 2:46 PM > To: dev@dpdk.org > Cc: ma...@nvidia.com; rasl...@nvidia.com; viachesl...@nvidia.com; > dkozl...@nvidia.com; Huangshaozhang ; > wangyunjian ; sta...@dpdk.org > Subject

RE: [dpdk-dev] [PATCH v2 1/2] net/mlx5: fix use after free when releasing tx queues

2022-09-23 Thread wangyunjian
Friendly ping. > -Original Message- > From: wangyunjian > Sent: Tuesday, August 23, 2022 2:46 PM > To: dev@dpdk.org > Cc: ma...@nvidia.com; rasl...@nvidia.com; viachesl...@nvidia.com; > dkozl...@nvidia.com; Huangshaozhang ; > wangyunjian ; sta...@dpdk.org > Subject

[dpdk-dev] Questions about dpdk-kmods version release?

2021-11-07 Thread wangyunjian
Hi all, The igb_uio.ko is moved to the dpdk-kmods repository snice DPDK 20.11, but the dpdk-kmods does not currently have any stable version. Is there any release stable versions or LTS versions planned for dpdk-kmods to publish? Thanks, Yunjian

Re: [dpdk-dev] [PATCH v2 4/4] net/ixgbe: delete HW rings when releasing queues

2021-09-22 Thread wangyunjian
> -Original Message- > From: Wang, Haiyue [mailto:haiyue.w...@intel.com] > Sent: Wednesday, September 22, 2021 3:05 PM > To: wangyunjian ; dev@dpdk.org > Cc: Xing, Beilei ; Yang, Qiming > ; Zhang, Qi Z ; dingxiaoxiong > > Subject: RE: [dpdk-dev] [PATCH v2 4

Re: [dpdk-dev] [PATCH v2 4/4] net/ixgbe: delete HW rings when releasing queues

2021-09-21 Thread wangyunjian
> -Original Message- > From: Wang, Haiyue [mailto:haiyue.w...@intel.com] > Sent: Wednesday, September 22, 2021 2:23 PM > To: wangyunjian ; dev@dpdk.org > Cc: Xing, Beilei ; Yang, Qiming > ; Zhang, Qi Z ; dingxiaoxiong > > Subject: RE: [dpdk-dev] [PATCH v2 4/4] ne

Re: [dpdk-dev] [PATCH 4/4] net/ixgbe: delete HW rings when releasing queues

2021-09-17 Thread wangyunjian
> -Original Message- > From: Wang, Haiyue [mailto:haiyue.w...@intel.com] > Sent: Friday, September 17, 2021 11:47 PM > To: wangyunjian ; dev@dpdk.org > Cc: Xing, Beilei ; Yang, Qiming > ; Zhang, Qi Z ; dingxiaoxiong > > Subject: RE: [dpdk-dev] [PATCH 4/4] net/ixg

[dpdk-dev] [PATCH] net/mlx5: fix use after free in mlx5_dma_unmap

2021-07-10 Thread wangyunjian
From: Yunjian Wang This patch fixes the use-after-free bug which was reported by Coverity Scan in the mlx5_dma_unmap function. Coverity issue: 371679 Fixes: 992e6df3dafe ("common/mlx5: free MR resource on device DMA unmap") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- drivers/net/mlx5/

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] kni: fix mbuf allocation for alloc FIFO

2021-06-23 Thread wangyunjian
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, June 23, 2021 4:46 AM > To: wangyunjian ; liucheng (J) > > Cc: dev@dpdk.org; sta...@dpdk.org; ferruh.yi...@intel.com; > gowrishanka...@linux.vnet.ibm.com; dingxiao

[dpdk-dev] [PATCH v3] kni: fix mbuf allocation for alloc FIFO

2021-06-22 Thread wangyunjian
From: Yunjian Wang In kni_allocate_mbufs(), we alloc mbuf for alloc_q as this code. allocq_free = (kni->alloc_q->read - kni->alloc_q->write - 1) \ & (MAX_MBUF_BURST_NUM - 1); The value of allocq_free maybe zero, for example : The ring size is 1024. After init, write = read = 0. Th

Re: [dpdk-dev] [PATCH v2] kni: fix wrong mbuf alloc count in kni_allocate_mbufs

2021-06-22 Thread wangyunjian
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Tuesday, June 22, 2021 8:28 PM > To: wangyunjian ; dev@dpdk.org > Cc: tho...@monjalon.net; gowrishanka...@linux.vnet.ibm.com; > dingxiaoxiong ; sta...@dpdk.org; liucheng (J) > > Sub

[dpdk-dev] [PATCH v2] kni: fix wrong mbuf alloc count in kni_allocate_mbufs

2021-06-22 Thread wangyunjian
From: Yunjian Wang In kni_allocate_mbufs(), we alloc mbuf for alloc_q as this code. allocq_free = (kni->alloc_q->read - kni->alloc_q->write - 1) \ & (MAX_MBUF_BURST_NUM - 1); The value of allocq_free maybe zero, for example : The ring size is 1024. After init, write = read = 0. Th

Re: [dpdk-dev] [PATCH] kni: fix wrong mbuf alloc count in kni_allocate_mbufs

2021-06-22 Thread wangyunjian
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Monday, June 21, 2021 7:26 PM > To: wangyunjian ; dev@dpdk.org > Cc: liucheng (J) ; dingxiaoxiong > > Subject: Re: [dpdk-dev] [PATCH] kni: fix wrong mbuf alloc count in > kni_allocate

Re: [dpdk-dev] [PATCH] kni: fix wrong mbuf alloc count in kni_allocate_mbufs

2021-06-20 Thread wangyunjian
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Friday, June 18, 2021 9:37 PM > To: wangyunjian ; dev@dpdk.org > Cc: liucheng (J) ; dingxiaoxiong > > Subject: Re: [dpdk-dev] [PATCH] kni: fix wrong mbuf alloc count in > kni_allocate

[dpdk-dev] [PATCH] kni: fix wrong mbuf alloc count in kni_allocate_mbufs

2021-05-31 Thread wangyunjian
From: Yunjian Wang In kni_allocate_mbufs(), we alloc mbuf for alloc_q as this code. allocq_free = (kni->alloc_q->read - kni->alloc_q->write - 1) \ & (MAX_MBUF_BURST_NUM - 1); The value of allocq_free maybe zero (e.g 32 & (32 - 1) = 0), and it will not fill the alloc_q. When the al

[dpdk-dev] [PATCH v2 2/2] net/mlx5: fix mem leak when a device configured repeatedly

2021-05-12 Thread wangyunjian
From: Yunjian Wang Currently, configuring a mlx device, it will allocate its own process private in mlx5_proc_priv_init() and only frees it when closing the device. This will lead to a memory leak, when a device is configured repeatedly. For example: for(...) do rte_eth_dev_configure rte

[dpdk-dev] [PATCH v2 1/2] net/mlx4: fix mem leak when a device configured repeatedly

2021-05-12 Thread wangyunjian
From: Yunjian Wang Currently, configuring a mlx device, it will allocate its own process private in mlx5_proc_priv_init() and only frees it when closing the device. This will lead to a memory leak, when a device is configured repeatedly. For example: for(...) do rte_eth_dev_configure rte

[dpdk-dev] [PATCH v2 0/2] fixes for mlx4/mlx5

2021-05-12 Thread wangyunjian
From: Yunjian Wang This series include two fixes patches for mlx4/mlx5. --- v2: * remove redundant empty line Yunjian Wang (2): net/mlx4: fix mem leak when a device configured repeatedly net/mlx5: fix mem leak when a device configured repeatedly drivers/net/mlx4/mlx4.c | 1 + drivers/n

Re: [dpdk-dev] [PATCH 1/2] net/mlx4: fix mem leak when a device configured repeatedly

2021-05-12 Thread wangyunjian
> -Original Message- > From: Slava Ovsiienko [mailto:viachesl...@nvidia.com] > Sent: Wednesday, May 12, 2021 10:05 PM > To: wangyunjian ; dev@dpdk.org > Cc: Matan Azrad ; Shahaf Shuler ; > dingxiaoxiong ; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 1/2] net/ml

[dpdk-dev] [PATCH 1/2] net/mlx4: fix mem leak when a device configured repeatedly

2021-05-12 Thread wangyunjian
From: Yunjian Wang Currently, configuring a mlx device, it will allocate its own process private in mlx5_proc_priv_init() and only frees it when closing the device. This will lead to a memory leak, when a device is configured repeatedly. For example: for(...) do rte_eth_dev_configure

[dpdk-dev] [PATCH 2/2] net/mlx5: fix mem leak when a device configured repeatedly

2021-05-12 Thread wangyunjian
From: Yunjian Wang Currently, configuring a mlx device, it will allocate its own process private in mlx5_proc_priv_init() and only frees it when closing the device. This will lead to a memory leak, when a device is configured repeatedly. For example: for(...) do rte_eth_dev_configure

[dpdk-dev] [PATCH 0/2] fixes for mlx4/mlx5

2021-05-12 Thread wangyunjian
From: Yunjian Wang This series include two fixes patches for mlx4/mlx5. Yunjian Wang (2): net/mlx4: fix mem leak when a device configured repeatedly net/mlx5: fix mem leak when a device configured repeatedly drivers/net/mlx4/mlx4.c | 2 ++ drivers/net/mlx5/mlx5.c | 2 ++ 2 files changed, 4

[dpdk-dev] LACP negotiation fails when LACP dedicated queue Is enabled for the X710 NIC

2021-04-29 Thread wangyunjian
Hello, When I tried to use the x710 NIC whose driver is i40e to enable LACP dedicated queue, the LACP negotiation fails. GDB debugging shows that the current packet sending function type is VECTOR. After I forcibly change the packet sending function to another type, LACP negotiation succeeds

[dpdk-dev] [PATCH v5] eal: fix create user mem map repeatedly when it exists

2021-04-10 Thread wangyunjian
From: Yunjian Wang Currently, new user mem maps are checked if they are adjacent to an existing mem map and if so, the mem map entries are merged. It doesn't check for duplicate mem maps, so if the API is called with the same mem map multiple times, they will occupy multiple mem map entries. Thi

Re: [dpdk-dev] [PATCH] vhost: fix accessing uninitialized variables

2021-03-27 Thread wangyunjian
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Maxime Coquelin > Sent: Wednesday, March 24, 2021 5:55 PM > To: Marvin Liu ; chenbo@intel.com > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] vhost: fix accessing uninitialized variables >

[dpdk-dev] [PATCH v2] net/mlx5: fix using flow tunnel before null check

2021-03-26 Thread wangyunjian
From: Yunjian Wang Coverity flags that 'ctx->tunnel' variable is used before it's checked for NULL. This patch fixes this issue. Coverity issue: 366201 Fixes: 868d2e342cf3 ("net/mlx5: fix tunnel offload hub multi-thread protection") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang Acked-by: Via

Re: [dpdk-dev] [PATCH] net/mlx5: fix using flow tunnel before null check

2021-03-26 Thread wangyunjian
> -Original Message- > From: Slava Ovsiienko [mailto:viachesl...@nvidia.com] > Sent: Friday, March 26, 2021 9:24 PM > To: wangyunjian ; dev@dpdk.org > Cc: Matan Azrad ; Shahaf Shuler ; > Lilijun (Jerry) ; chenchanghu > > Subject: RE: [dpdk-dev] [PATCH] net/mlx

[dpdk-dev] [PATCH] net/mlx5: fix using flow tunnel before null check

2021-03-26 Thread wangyunjian
From: Yunjian Wang Coverity flags that 'ctx->tunnel' variable is used before it's checked for NULL. This patch fixes this issue. Coverity issue: 366201 Fixes: 868d2e342cf3 ("net/mlx5: fix tunnel offload hub multi-thread protection") Signed-off-by: Yunjian Wang --- drivers/net/mlx5/mlx5_flow.c

Re: [dpdk-dev] [PATCH v4] eal: fix create user mem map repeatedly when it exists

2021-03-25 Thread wangyunjian
Friendly ping. > -Original Message- > From: wangyunjian > Sent: Monday, December 7, 2020 7:09 PM > To: dev@dpdk.org > Cc: david.march...@redhat.com; tho...@monjalon.net; > anatoly.bura...@intel.com; Lilijun (Jerry) ; > xudingke > ; wangyunjian ; > sta...@dp

Re: [dpdk-dev] [EXT] [PATCH] net/mvneta: check allocation in rx queue flush

2020-12-07 Thread wangyunjian
> -Original Message- > From: Liron Himi [mailto:lir...@marvell.com] > Sent: Monday, December 7, 2020 8:38 PM > To: wangyunjian ; dev@dpdk.org > Cc: z...@semihalf.com; Lilijun (Jerry) ; xudingke > ; sta...@dpdk.org; Liron Himi > Subject: RE: [EXT] [dpdk-dev] [PAT

[dpdk-dev] [PATCH] net/mvneta: check allocation in rx queue flush

2020-12-07 Thread wangyunjian
From: Yunjian Wang The function rte_malloc() could return NULL, the return value need to be checked. Fixes: ce7ea764597e ("net/mvneta: support Rx/Tx") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- drivers/net/mvneta/mvneta_rxtx.c | 10 ++ 1 file changed, 10 insertions(+) diff -

[dpdk-dev] [PATCH v4] eal: fix create user mem map repeatedly when it exists

2020-12-07 Thread wangyunjian
From: Yunjian Wang Currently, user mem maps will check if the newly mapped area is adjacent to any existing mapping, but will not check if the mapping is identical because it assumes that the API will never get called with the same mapping twice. This will result in duplicate entries in the user

[dpdk-dev] [PATCH] net/bnxt: fix memory leak when mapping failure

2020-11-30 Thread wangyunjian
From: Yunjian Wang We allocated memory for the 'buf' when sending message to HWRM, but we don't free it when mapping the address to IO address fails. It will lead to memory leak. Fixes: 19e6af01bb36 ("net/bnxt: support get/set EEPROM") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- drive

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] eal: fix create user mem map repeatedly when it exists

2020-11-22 Thread wangyunjian
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, November 23, 2020 2:20 AM > To: anatoly.bura...@intel.com; wangyunjian > Cc: sta...@dpdk.org; dev@dpdk.org; david.march...@redhat.com; Lilijun > (Jerry) ; xudingke ; > bruce

Re: [dpdk-dev] [PATCH] net/mlx5: remove unnecessary NULL check

2020-11-17 Thread wangyunjian
OK, please reject this patch. Thanks, Yunjian > -Original Message- > From: Suanming Mou [mailto:suanmi...@nvidia.com] > Sent: Wednesday, November 18, 2020 10:16 AM > To: wangyunjian ; dev@dpdk.org > Cc: ma...@mellanox.com; shah...@mellanox.com; > viachesl...@mellanox.c

Re: [dpdk-dev] [PATCH] malloc: cleanup coding style

2020-11-12 Thread wangyunjian
> -Original Message- > From: Burakov, Anatoly [mailto:anatoly.bura...@intel.com] > Sent: Thursday, November 12, 2020 7:40 PM > To: wangyunjian ; dev@dpdk.org > Cc: rsanfo...@gmail.com; Lilijun (Jerry) ; xudingke > ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] m

[dpdk-dev] [PATCH] malloc: cleanup coding style

2020-11-12 Thread wangyunjian
From: Yunjian Wang Cleanup code style issue reported by kernel checkpatch. As follows: * ERROR:CODE_INDENT: code indent should use tabs where possible * ERROR:SPACING: spaces required around that '?' (ctx:VxE) * WARNING:INDENTED_LABEL: labels should not be indented Fixes: b0489e7bca2f ("ma

[dpdk-dev] [PATCH v4] ethdev: fix data type for port id

2020-11-03 Thread wangyunjian
From: Yunjian Wang The ethdev port id is 16 bits now. This patch fixes the data type of the variable for 'pid', which changing from uint32_t to uint16_t. RTE_MAX_ETHPORTS is the maximum number of ports, which customized by the user. To avoid 16-bit unsigned integer overflow, the valid value of R

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] ethdev: fix data type for port id

2020-11-03 Thread wangyunjian
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, November 4, 2020 2:44 AM > To: wangyunjian > Cc: dev@dpdk.org; ferruh.yi...@intel.com; andrew.rybche...@oktetlabs.ru; > Lilijun (Jerry) ; xudingke ; > sta...@dpdk.org > S

[dpdk-dev] [PATCH v2] ethdev: fix check of rx configure

2020-11-03 Thread wangyunjian
From: Yunjian Wang Coverity flags that 'rx_conf' variable is used before it's checked for NULL. This patch fixes this issue. Coverity issue: 363570 Fixes: 4ff702b5dfa9 ("ethdev: introduce Rx buffer split") Signed-off-by: Yunjian Wang --- v2: fix code styles suggested by Ferruh Yigit --- l

Re: [dpdk-dev] [PATCH] ethdev: fix check of rx configure

2020-11-03 Thread wangyunjian
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Tuesday, November 3, 2020 9:58 PM > To: wangyunjian ; dev@dpdk.org > Cc: tho...@monjalon.net; andrew.rybche...@oktetlabs.ru; Lilijun (Jerry) > ; xudingke > Subject: Re: [dpdk-dev] [PAT

[dpdk-dev] [PATCH] ethdev: fix check of rx configure

2020-11-03 Thread wangyunjian
From: Yunjian Wang Coverity flags that 'rx_conf' variable is used before it's checked for NULL. This patch fixes this issue. Coverity issue: 363570 Fixes: 4ff702b5dfa9 ("ethdev: introduce Rx buffer split") Signed-off-by: Yunjian Wang --- lib/librte_ethdev/rte_ethdev.c | 9 + 1 file ch

[dpdk-dev] [PATCH] compress/isal: check allocation in qp setup

2020-11-02 Thread wangyunjian
From: Yunjian Wang The function rte_zmalloc() could return NULL, the return value need to be checked. Fixes: dc49e6aa4879 ("compress/isal: add ISA-L compression functionality") Fixes: 7bf4f0630af6 ("compress/isal: add ISA-L decomp functionality") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang

[dpdk-dev] [PATCH v3] ethdev: fix data type for port id

2020-11-02 Thread wangyunjian
From: Yunjian Wang The ethdev port id is 16 bits now. This patch fixes the data type of the variable for 'pid', which changing from uint32_t to uint16_t. RTE_MAX_ETHPORTS is the maximum number of ports, which customized by the user. To avoid 16-bit unsigned integer overflow, the valid value of R

Re: [dpdk-dev] [EXT] RE: [PATCH 1/1] eal/linux: fix event set error for rte_epoll_event

2020-11-01 Thread wangyunjian
> -Original Message- > From: wangyunjian > Sent: Tuesday, September 22, 2020 8:06 PM > To: 'Harman Kalra' > Cc: dev@dpdk.org; david.march...@redhat.com; ferruh.yi...@intel.com; > Thomas Monjalon ; Lilijun (Jerry) > ; xudingke ; > sta...@dpdk.org > Sub

Re: [dpdk-dev] [PATCH v2] ethdev: fix data type for port id

2020-10-29 Thread wangyunjian
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, October 27, 2020 10:29 PM > To: wangyunjian > Cc: dev@dpdk.org; ferruh.yi...@intel.com; andrew.rybche...@oktetlabs.ru; > Lilijun (Jerry) ; xudingke ; > wangyunjian ; sta...@d

[dpdk-dev] [PATCH v2] ethdev: fix data type for port id

2020-10-27 Thread wangyunjian
From: Yunjian Wang The ethdev port id should be 16 bits now. This patch fixes the data type of the variable for 'pid', changing from uint32_t to uint16_t. We also need use RTE_BUILD_BUG_ON() to ensure that RTE_MAX_ETHPORTS is less or equal to UINT16_MAX. Fixes: 5b7ba31148a8 ("ethdev: add port o

[dpdk-dev] [PATCH] hash: fix dereference before null check

2020-10-27 Thread wangyunjian
From: Yunjian Wang Coverity flags that 'h' variable is used before it's checked for NULL. This patch fixes this issue. Coverity issue: 363625 Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- lib/librte_hash/rte_cuckoo_hash.c

Re: [dpdk-dev] [PATCH] ethdev: fix data type for port id

2020-10-26 Thread wangyunjian
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, October 26, 2020 8:34 PM > To: Andrew Rybchenko > Cc: wangyunjian ; dev@dpdk.org; > ferruh.yi...@intel.com; Lilijun (Jerry) ; xudingke > ; ma...@nvidia.com > Subject: Re: [

[dpdk-dev] [PATCH] ethdev: fix data type for port id

2020-10-26 Thread wangyunjian
From: Yunjian Wang The ethdev port id should be 16 bits now. This patch fixes the data type of the variable for 'pid', changing from uint32_t to uint16_t. Fixes: 5b7ba31148a8 ("ethdev: add port ownership") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- lib/librte_ethdev/rte_ethdev.c | 2

Re: [dpdk-dev] [PATCH v5 3/3] eal: fix a wrong returned value when callback exists

2020-10-23 Thread wangyunjian
> -Original Message- > From: David Marchand [mailto:david.march...@redhat.com] > Sent: Thursday, October 22, 2020 8:55 PM > To: wangyunjian > Cc: dev ; Jeff Guo ; Jerin Jacob > Kollanukkaran ; Lilijun (Jerry) > ; > xudingke ; dpdk stable ; Kevin > Traynor ; L

Re: [dpdk-dev] [PATCH v5 2/3] eal: return error code when failure

2020-10-23 Thread wangyunjian
> -Original Message- > From: David Marchand [mailto:david.march...@redhat.com] > Sent: Thursday, October 22, 2020 8:52 PM > To: wangyunjian > Cc: dev ; Jeff Guo ; Jerin Jacob > Kollanukkaran ; Lilijun (Jerry) > ; > xudingke ; dpdk stable ; Kevin > Traynor ; L

[dpdk-dev] [PATCH] net/mvpp2: fix memory leak in error path

2020-10-21 Thread wangyunjian
From: Yunjian Wang In mrvl_create() allocated memory for 'mtr', we don't free it when profile get fails and it will lead to memory leak. We can get profile at the beginning of the function to fix it, before calling mtr = rte_zmalloc_socket(). Fixes: cdb53f8da628 ("net/mvpp2: support metering")

[dpdk-dev] [PATCH v5 2/3] eal: return error code when failure

2020-10-21 Thread wangyunjian
From: Yunjian Wang Fix return value, using -EAGAIN instead of 0 when the callback is busy and using -ENOENT instead of 0 when the callback is not found. Fixes: a753e53d517b ("eal: add device event monitor framework") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang Acked-by: Jeff Guo --- lib/

[dpdk-dev] [PATCH v5 3/3] eal: fix a wrong returned value when callback exists

2020-10-21 Thread wangyunjian
From: Yunjian Wang We should return an error value, when the callback is already exist. Fixes: a753e53d517b ("eal: add device event monitor framework") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang Suggested-by: David Marchand --- lib/librte_eal/common/eal_common_dev.c | 2 ++ 1 file chang

[dpdk-dev] [PATCH v5 1/3] eal: fix memory leak when removing event_cb

2020-10-21 Thread wangyunjian
From: Yunjian Wang The event_cb->dev_name is not freed when freeing event_cb, and this causes a memory leak. Fixes: a753e53d517b ("eal: add device event monitor framework") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang Acked-by: Jeff Guo --- lib/librte_eal/common/eal_common_dev.c | 1 + 1

[dpdk-dev] [PATCH v5 0/3] fixes for device event

2020-10-21 Thread wangyunjian
From: Yunjian Wang This series include three fixes patches for device event. --- v5: * update patch 3/3 code styles suggested by David Marchand v4: * add fix a wrong returned value * remove redundant check suggested by David Marchand v3: * modified the format. Yunjian Wang (3): eal: fix

[dpdk-dev] [PATCH] net/thunderx: fix memory leak when allocate rbdr desc ring fails

2020-10-20 Thread wangyunjian
From: Yunjian Wang In nicvf_qset_rbdr_alloc(), we allocate memory for the 'rbdr' structure but not released when allocate 'rbdr desc ring' fails. Fixes: 7413feee662d ("net/thunderx: add device start/stop and close") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- drivers/net/thunderx/nicv

Re: [dpdk-dev] [dpdk-stable] [PATCH v4 3/3] eal: fix a wrong returned value when callback exists

2020-10-20 Thread wangyunjian
> -Original Message- > From: David Marchand [mailto:david.march...@redhat.com] > Sent: Tuesday, October 20, 2020 9:19 PM > To: wangyunjian ; Jeff Guo > Cc: dev ; Lilijun (Jerry) ; xudingke > ; dpdk stable > Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v4 3/3] eal:

Re: [dpdk-dev] [PATCH v2] eal/linux: do not create user mem map repeatedly when it exists

2020-10-16 Thread wangyunjian
> -Original Message- > From: David Marchand [mailto:david.march...@redhat.com] > Sent: Thursday, October 15, 2020 8:54 PM > To: wangyunjian > Cc: dev@dpdk.org; Burakov, Anatoly ; Lilijun > (Jerry) ; xudingke ; > sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2]

[dpdk-dev] [PATCH v3] eal: fix create user mem map repeatedly when it exists

2020-10-16 Thread wangyunjian
From: Yunjian Wang Currently, a issue that a container has many devices and the application will map the same memory many times. The kernel driver returns EEXIST as long as there are overlapping memory areas. As a result, we repeatedly create new user mem map entry for the same memory segment and

[dpdk-dev] [PATCH v2] baseband/turbo_sw: fix memory leak in error path

2020-10-15 Thread wangyunjian
From: Yunjian Wang In q_setup() allocated memory for the queue data, we should free it when error happens, otherwise it will lead to memory leak. Fixes: b8cfe2c9aed2 ("bb/turbo_sw: add software turbo driver") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- v2: fix code styles Chautru Ni

Re: [dpdk-dev] [PATCH] baseband/turbo_sw: fix memory leak in error path

2020-10-15 Thread wangyunjian
> -Original Message- > From: Chautru, Nicolas [mailto:nicolas.chau...@intel.com] > Sent: Thursday, October 8, 2020 7:45 AM > To: wangyunjian ; dev@dpdk.org > Cc: Lilijun (Jerry) ; xudingke > ; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] baseband/turbo_sw: fix

Re: [dpdk-dev] [PATCH v2] eal/linux: do not create user mem map repeatedly when it exists

2020-10-15 Thread wangyunjian
Hi David, Can this patch be merged before RC1? Thanks, Yunjian > -Original Message- > From: Burakov, Anatoly [mailto:anatoly.bura...@intel.com] > Sent: Thursday, September 17, 2020 7:35 PM > To: wangyunjian ; dev@dpdk.org; > david.march...@redhat.com > Cc: Lilijun

[dpdk-dev] [PATCH v2] eal: fix dereference after null check

2020-10-15 Thread wangyunjian
From: Yunjian Wang This patch fixes (dereference after null check) coverity issue. For this reason, we should add null check at the beginning of the function and return error directly if the 'intr_handle' is null. Coverity issue: 357695, 357751 Fixes: 05c4105738d8 ("trace: add interrupt tracepoi

Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix dereference before null check

2020-10-14 Thread wangyunjian
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, October 15, 2020 1:03 AM > To: wangyunjian ; dev@dpdk.org > Cc: david.march...@redhat.com; jer...@marvell.com; hka...@marvell.com; > Lilijun (Jerry) ; xudingke ; > sta...@d

[dpdk-dev] [PATCH v2] net/octeontx2: remove logically dead code

2020-10-09 Thread wangyunjian
From: Yunjian Wang The glibc free allows free(NULL) as null operation, so remove this useless null checks. Coverity issue: 357719 Fixes: da138cd47e06 ("net/octeontx2: handle port reconfigure") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- v2: fix code styles suggested by Stephen Hemmi

[dpdk-dev] [PATCH] baseband/turbo_sw: fix memory leak in error path

2020-10-07 Thread wangyunjian
From: Yunjian Wang In q_setup() allocated memory for the queue data, we should free it when error happens, otherwise it will lead to memory leak. Fixes: b8cfe2c9aed2 ("bb/turbo_sw: add software turbo driver") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- drivers/baseband/turbo_sw/bbdev_

[dpdk-dev] [PATCH] net/fm10k: fix memory leak when Tx thresh check fails

2020-10-07 Thread wangyunjian
From: Yunjian Wang In fm10k_tx_queue_setup(), we allocate memory for the queue structure but not released when Tx thresh check fails. Fixes: 98068e0e044e ("fm10k: add Tx queue setup/release") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- drivers/net/fm10k/fm10k_ethdev.c | 4 +++- 1 file

[dpdk-dev] [PATCH v2] net/netvsc: fix txq leak in error path

2020-10-06 Thread wangyunjian
From: Yunjian Wang In hn_dev_tx_queue_setup() allocated memory for txq, we don't free it when error happens and it will lead to memory leak. We can check for tx_free_thresh at the beginning of the function to fix it, before calling txq = rte_zmalloc_socket(). Fixes: cc0251813277 ("net/netvsc: s

Re: [dpdk-dev] [PATCH] net/octeontx2: remove logically dead code

2020-09-30 Thread wangyunjian
> -Original Message- > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > Sent: Wednesday, September 30, 2020 2:15 AM > To: wangyunjian > Cc: dpdk-dev ; Jerin Jacob ; Nithin > Dabilpuram ; Kiran Kumar K > ; Lilijun (Jerry) ; > xudingke ; dpdk stable > Subject:

Re: [dpdk-dev] [PATCH v3 20/29] net/tap: release port upon close

2020-09-30 Thread wangyunjian
I have checked and tested it, no issue found. Thanks, Yunjian > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, September 29, 2020 7:14 AM > To: dev@dpdk.org > Cc: ferruh.yi...@intel.com; arybche...@solarflare.com; wangyunjian

Re: [dpdk-dev] [PATCH v2] net/tap: release port upon close

2020-09-29 Thread wangyunjian
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Wednesday, September 30, 2020 12:56 AM > To: wangyunjian ; dev@dpdk.org > Cc: keith.wi...@intel.com; tho...@monjalon.net; Lilijun (Jerry) > ; xudingke > Subject: Re: [dpdk-dev] [PATCH

[dpdk-dev] [PATCH] eventdev: fix adapter leak in error path

2020-09-29 Thread wangyunjian
From: Yunjian Wang In rte_event_crypto_adapter_create_ext() allocated memory for adapter, we should free it when error happens, otherwise it will lead to memory leak. Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- lib/li

[dpdk-dev] [PATCH] net/netvsc: fix txq leak in error path

2020-09-29 Thread wangyunjian
From: Yunjian Wang In hn_dev_tx_queue_setup() allocated memory for txq, we should free it when error happens, otherwise it will lead to memory leak. Fixes: cc0251813277 ("net/netvsc: split send buffers from Tx descriptors") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- drivers/net/netvs

[dpdk-dev] [PATCH] efd: fix tailq entry leak in error path

2020-09-28 Thread wangyunjian
From: Yunjian Wang In rte_efd_create() allocated memory for tailq entry, we should free it when error happens, otherwise it will lead to memory leak. Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- lib/librte_efd/rte_efd.c

Re: [dpdk-dev] [PATCH] net: check that seg is valid before dereference

2020-09-28 Thread wangyunjian
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Chas Williams > Sent: Monday, September 28, 2020 11:32 PM > To: dev@dpdk.org > Cc: olivier.m...@6wind.com; Chas Williams <3ch...@gmail.com> > Subject: [dpdk-dev] [PATCH] net: check that seg is valid before dereferen

[dpdk-dev] [PATCH] net/fm10k: fix memory leak when thresh check fails

2020-09-28 Thread wangyunjian
From: Yunjian Wang In fm10k_rx_queue_setup(), we allocate memory for the queue structure but not released when thresh check fails. Fixes: 6cfe8969c969 ("fm10k: add Rx queue setup/release") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- drivers/net/fm10k/fm10k_ethdev.c | 5 +++-- 1 file c

[dpdk-dev] [PATCH] examples/vhost_blk: fix unchecked return value

2020-09-25 Thread wangyunjian
From: Yunjian Wang This checks the return value from the function rte_vhost_driver_start. Coverity issue: 362027 Fixes: c19beb3f38cd ("examples/vhost_blk: introduce vhost storage sample") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- examples/vhost_blk/vhost_blk.c | 6 +- 1 file cha

[dpdk-dev] [PATCH] stack: fix possible uninitialized success variable

2020-09-24 Thread wangyunjian
From: Yunjian Wang This patch fixes an issue that uninitialized 'success' is used to be compared with '0'. Coverity issue: 337676 Fixes: 3340202f5954 ("stack: add lock-free implementation") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- lib/librte_stack/rte_stack_lf_generic.h | 2 +- 1 f

Re: [dpdk-dev] [EXT] RE: [PATCH 1/1] eal/linux: fix event set error for rte_epoll_event

2020-09-22 Thread wangyunjian
> -Original Message- > From: Harman Kalra [mailto:hka...@marvell.com] > Sent: Tuesday, September 22, 2020 6:32 PM > To: wangyunjian > Cc: dev@dpdk.org; david.march...@redhat.com; ferruh.yi...@intel.com; > Thomas Monjalon ; Lilijun (Jerry) > ; xudingke ; > sta..

Re: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for rte_epoll_event

2020-09-21 Thread wangyunjian
> -Original Message- > From: David Marchand [mailto:david.march...@redhat.com] > Sent: Monday, September 21, 2020 4:05 PM > To: wangyunjian > Cc: dev@dpdk.org; hka...@marvell.com; ferruh.yi...@intel.com; Thomas > Monjalon ; Lilijun (Jerry) ; > xudingke ; sta...@d

Re: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for rte_epoll_event

2020-09-19 Thread wangyunjian
Friendly ping. > -Original Message- > From: wangyunjian > Sent: Wednesday, August 26, 2020 6:56 PM > To: dev@dpdk.org; hka...@marvell.com; david.march...@redhat.com > Cc: 'ferruh.yi...@intel.com' ; 'Thomas Monjalon' > ; Lilijun (Jerry) ; xudingke &g

[dpdk-dev] [PATCH] eal: fix dereference before null check

2020-09-19 Thread wangyunjian
From: Yunjian Wang This patch fixes (dereference after null check) coverity issue. The intr_handle may be a null pointer which led to this issue. Coverity issue: 357695, 357751 Fixes: 05c4105738d8 ("trace: add interrupt tracepoints") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- lib/lib

Re: [dpdk-dev] [PATCH 2/2] bus/fslmc: fix check for vfio_group_fd

2020-09-17 Thread wangyunjian
> -Original Message- > From: Burakov, Anatoly [mailto:anatoly.bura...@intel.com] > Sent: Thursday, September 17, 2020 8:56 PM > To: wangyunjian ; dev@dpdk.org > Cc: hemant.agra...@nxp.com; sachin.sax...@nxp.com; Lilijun (Jerry) > ; xudingke ; > sta...@dpdk.org >

  1   2   3   >