ointer 'rxq' used after 'rte_free'
> >
> > It is fixed by moving the assignment before freeing the parent pointer.
> >
> > Fixes: 80da7efbb4c4 ("eal: annotate allocation functions")
> >
> > Signed-off-by: Thomas Monjalon
> Reviewed-by: David Marchand
>
>
Acked-by: Martin Spinler
Tested-by: Martin Spinler
Acked-by: Martin Spinler
On Fri, 2023-12-22 at 09:11 -0800, Stephen Hemminger wrote:
> All drivers should be using dynamic logtype.
>
> Fixes: 6435f9a0ac22 ("net/nfb: add new netcope driver")
> Signed-off-by: Stephen Hemminger
> ---
Tested-by: Martin Spinler
Acked-by: Martin Spinler
---
Hi! Thanks for the cleanup. I've tested that patchset and works fine.
I'm just not sure, if the "net/nfb: use dynamic logtype" patch merges
with the "Remove uses of PMD logtype" series as they slightly diffe
On Thu, 2023-12-07 at 10:56 -0800, Stephen Hemminger wrote:
> All drivers should be using dynamic logtype.
>
> Fixes: 6435f9a0ac22 ("net/nfb: add new netcope driver")
> Signed-off-by: Stephen Hemminger
Tested-by: Martin Spinler
Thanks for patch! There are some issues.
On Wed, 2023-12-06 at 09:51 -0800, Stephen Hemminger wrote:
>
> diff --git a/drivers/net/nfb/nfb_log.h b/drivers/net/nfb/nfb_log.h
> new file mode 100644
> index ..fac66a38d4b3
> --- /dev/null
> +++ b/drivers/net/nfb/nfb_log.h
> @@ -0,0 +1,13 @
Thank you for the review!
On Tue, 2022-02-15 at 13:55 +, Ferruh Yigit wrote:
> On 2/15/2022 12:55 PM, spin...@cesnet.cz wrote:
> > From: Martin Spinler
> >
> > This series introduces standard RX timestamp offload flag support
> > together with multiple MAC addres
On Mon, 2022-02-14 at 17:54 +, Ferruh Yigit wrote:
> > > > @@ -530,7 +577,7 @@ nfb_eth_dev_init(struct rte_eth_dev *dev)
> > > > eth_addr_init.addr_bytes[1] = eth_addr.addr_bytes[1];
> > > > eth_addr_init.addr_bytes[2] = eth_addr.addr_bytes[2];
> > > >
> > > > - nfb_e
From: Martin Spinler
Extend the eth_dev_ops by add/remove MAC address functions.
Signed-off-by: Martin Spinler
---
drivers/net/nfb/nfb_ethdev.c | 90 ++--
1 file changed, 77 insertions(+), 13 deletions(-)
diff --git a/drivers/net/nfb/nfb_ethdev.c b/drivers/net
From: Martin Spinler
In the firmware, the promisc mode overrides the multicast mode.
So when the promisc mode is turned off, driver must check if the
multicast mode was active before and conditionally reactivate it.
Fixes: 6435f9a0ac22 ("net/nfb: add new netcope driver")
Cc: cer...@n
From: Martin Spinler
Rewrite the RX timestamp setup code to use standard offload flag.
Signed-off-by: Martin Spinler
---
doc/guides/nics/nfb.rst | 8 ++
drivers/net/nfb/nfb.h| 3 +-
drivers/net/nfb/nfb_ethdev.c | 19 -
drivers/net/nfb/nfb_rx.c | 53
From: Martin Spinler
Zero-sized TX burst floods the log no more.
Signed-off-by: Martin Spinler
---
drivers/net/nfb/nfb_tx.h | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/nfb/nfb_tx.h b/drivers/net/nfb/nfb_tx.h
index d3cbe3e6b3..910020e9e9 100644
--- a
From: Martin Spinler
The indexes in the for cycle were wrongly used and
the code accessed outside of the rxmac/txmac array.
Fixes: 6435f9a0ac22 ("net/nfb: add new netcope driver")
Cc: cer...@netcope.com
Cc: sta...@dpdk.org
Signed-off-by: Martin Spinler
---
drivers/net/nfb/nfb_eth
From: Martin Spinler
This series introduces standard RX timestamp offload flag support
together with multiple MAC addresses support for NFB devices.
Also fixes a promisc/multicast switch issue and minor annoyances.
---
v2:
* Removed libfdt dependency patch from series, is needless.
* Added
On Mon, 2022-02-14 at 13:37 +, Ferruh Yigit wrote:
> On 2/14/2022 11:25 AM, spin...@cesnet.cz wrote:
> > From: Martin Spinler
> >
> > Extend the eth_dev_ops by add/remove MAC address functions.
> >
> > Signed-off-by: Martin Spinler
> > ---
On Mon, 2022-02-14 at 13:36 +, Ferruh Yigit wrote:
> On 2/14/2022 11:25 AM, spin...@cesnet.cz wrote:
> > From: Martin Spinler
> >
> > In the firmware, the promisc mode overrides the multicast mode.
> > So when the promisc mode is turned off, driver must check if
On Mon, 2022-02-14 at 13:36 +, Ferruh Yigit wrote:
> On 2/14/2022 11:25 AM, spin...@cesnet.cz wrote:
> > From: Martin Spinler
> >
> > The driver uses some FDT manipulation functions from libfdt.
> > Let the build system check for libfdt package.
> >
>
On Mon, 2022-02-14 at 13:35 +, Ferruh Yigit wrote:
> On 2/14/2022 11:25 AM, spin...@cesnet.cz wrote:
> > From: Martin Spinler
> >
> > Zero-sized TX burst floods the log no more.
> >
>
> If you want this patch to be backported, you can update
> commit lo
Hi Ferruh,
thanks for all comments in this series.
On Mon, 2022-02-14 at 13:34 +, Ferruh Yigit wrote:
> On 2/14/2022 11:25 AM, spin...@cesnet.cz wrote:
> > From: Martin Spinler
> >
> > The indexes in the for cycle were wrongly used and
> > the code accessed outsi
From: Martin Spinler
Extend the eth_dev_ops by add/remove MAC address functions.
Signed-off-by: Martin Spinler
---
drivers/net/nfb/nfb_ethdev.c | 69 ++--
1 file changed, 58 insertions(+), 11 deletions(-)
diff --git a/drivers/net/nfb/nfb_ethdev.c b/drivers/net
From: Martin Spinler
In the firmware, the promisc mode overrides the multicast mode.
So when the promisc mode is turned off, driver must check if the
multicast mode was active before and conditionally reactivate it.
Signed-off-by: Martin Spinler
---
drivers/net/nfb/nfb.h| 4
From: Martin Spinler
Rewrite the RX timestamp setup code to use standard offload flag.
Signed-off-by: Martin Spinler
---
drivers/net/nfb/nfb.h| 3 +-
drivers/net/nfb/nfb_ethdev.c | 19 -
drivers/net/nfb/nfb_rx.c | 53
drivers/net
From: Martin Spinler
Zero-sized TX burst floods the log no more.
Signed-off-by: Martin Spinler
---
drivers/net/nfb/nfb_tx.h | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/nfb/nfb_tx.h b/drivers/net/nfb/nfb_tx.h
index d3cbe3e6b3..910020e9e9 100644
--- a
From: Martin Spinler
The indexes in the for cycle were wrongly used and
the code accessed outside of the rxmac/txmac array.
Signed-off-by: Martin Spinler
---
drivers/net/nfb/nfb_ethdev.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/net/nfb
From: Martin Spinler
The driver uses some FDT manipulation functions from libfdt.
Let the build system check for libfdt package.
Signed-off-by: Martin Spinler
---
drivers/net/nfb/meson.build | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/nfb/meson.build b/drivers/net
On Wed, 2021-11-10 at 16:08 +, Ferruh Yigit wrote:
> On 11/10/2021 3:39 PM, Martin Spinler wrote:
> > Remove the szedata2 device driver as the platform is no longer
> > supported.
> >
> > Signed-off-by: Martin Spinler
>
> Thanks Martin for the update.
>
On Wed, 2021-11-10 at 16:12 +, Ferruh Yigit wrote:
> On 11/10/2021 3:39 PM, Martin Spinler wrote:
> > Update the software dependency link because of website shutdown.
> >
> > Netcope Technologies was recently renamed to Magmio and no longer
> > provides packages and
and cooperates on the development of high
speed network FPGA cards as well.
Signed-off-by: Martin Spinler
---
doc/guides/nics/nfb.rst | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/doc/guides/nics/nfb.rst b/doc/guides/nics/nfb.rst
index 790fc48311..14560d38e4 100644
Remove the szedata2 device driver as the platform is no longer
supported.
Signed-off-by: Martin Spinler
---
MAINTAINERS |6 -
doc/guides/nics/features/szedata2.ini | 18 -
.../img/szedata2_nfb200g_architecture.svg | 214 --
doc/guides/nics
and cooperates on the development of high
speed network FPGA cards as well.
Signed-off-by: Martin Spinler
---
doc/guides/nics/nfb.rst | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/doc/guides/nics/nfb.rst b/doc/guides/nics/nfb.rst
index 790fc48311..14560d38e4 100644
Removing the szedata2 device driver as the platform is no longer
supported.
Signed-off-by: Martin Spinler
---
MAINTAINERS |6 -
doc/guides/nics/features/szedata2.ini | 18 -
.../img/szedata2_nfb200g_architecture.svg | 214 --
doc/guides/nics
30 matches
Mail list logo
