Re: [dpdk-dev] [PATCH v2] regex/mlx5: add dynamic memory registration to datapath

2020-10-06 Thread Yuval Avnery
Fixed in version 3 From: Thomas Monjalon Sent: Sunday, October 4, 2020 10:38 PM To: Yuval Avnery Cc: Ori Kam ; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] regex/mlx5: add dynamic memory registration to datapath Hi Yuval, > From: Yuval Avn

[dpdk-dev] [PATCH v3] regex/mlx5: add dynamic memory registration to datapath

2020-10-05 Thread Yuval Avnery
From: Yuval Avnery Currently job data is being copied to pre-registered buffer. To avoid memcpy on the datapath, use dynamic memory registration. This change will reduce latency when sending regex jobs. The first few jobs may have high latency due to registration, but assuming all following

[dpdk-dev] [PATCH v2] regex/mlx5: add dynamic memory registration to datapath

2020-09-24 Thread Yuval Avnery
From: Yuval Avnery Currently job data is being copied to pre-registered buffer. To avoid memcpy on the datapath, use dynamic memory registration. This change will reduce latency when sending regex jobs. The first few jobs may have high latency due to registration, but assuming all following

[dpdk-dev] [PATCH v1] regex/mlx5: add dynamic memroy registration to datapath

2020-09-24 Thread Yuval Avnery
From: Yuval Avnery Currently job data is being copied to pre-registered buffer. To avoid memcpy on the datapath, use dynamic memory registration. This change will reduce latency when sending regex jobs. The first few jobs may have high latency due to registration, but assuming all following

[dpdk-dev] [PATCH v2] regex/mlx5: add teardown flow to fastpath buffers

2020-09-02 Thread Yuval Avnery
From: Yuval Avnery Added missing code to free Input/Output buffers and memory registration. Also added calls to this code in case of error in the qp setup procedure. The rollback code itself did not handle rollback properly and did not check return value from the fastpath setup. Signed-off-by

[dpdk-dev] [PATCH v1] regex/mlx5: add teardown flow to fastpath buffers

2020-08-26 Thread Yuval Avnery
From: Yuval Avnery Added missing teardown flow to fastpath buffers, and fixed rollback code on control setup. Signed-off-by: Yuval Avnery Acked-by: Ori Kam --- drivers/regex/mlx5/mlx5_regex.h | 1 + drivers/regex/mlx5/mlx5_regex_control.c | 20 --- drivers/regex

[dpdk-dev] [PATCH v2] regex/mlx5: fix sq free check on enqueue

2020-07-28 Thread Yuval Avnery
Free sq check had a bug, causing jobs to overwrite. Fixes: 8740ba5fe57f ("regex/mlx5: add enqueue implementation") Signed-off-by: Yuval Avnery Acked-by: Ori Kam --- drivers/regex/mlx5/mlx5_regex_fastpath.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/dri

Re: [dpdk-dev] [PATCH v1] regex/mlx5: fix sq free check on enqueue

2020-07-28 Thread Yuval Avnery
There is a bug here, will send another version > -Original Message- > From: Yuval Avnery > Sent: Tuesday, July 28, 2020 10:55 AM > To: Ori Kam > Cc: Thomas Monjalon ; dev@dpdk.org; Yuval > Avnery > Subject: [PATCH v1] regex/mlx5: fix sq free check on enqueue >

[dpdk-dev] [PATCH v1] regex/mlx5: fix sq free check on enqueue

2020-07-28 Thread Yuval Avnery
Free sq check had a bug, causing jobs to overwrite. Fixes: 8740ba5fe57f ("regex/mlx5: add enqueue implementation") Signed-off-by: Yuval Avnery Acked-by: Ori Kam --- drivers/regex/mlx5/mlx5_regex_fastpath.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/dri

[dpdk-dev] [PATCH v1] common/mlx5: fix set regex register layout

2020-07-28 Thread Yuval Avnery
Reserved field should be 0x60 instead of 0x40. Will fail FW check otherwise. Fixes: be4f4a8b8e3b ("regex/mlx5: add engine status check") Signed-off-by: Yuval Avnery Acked-by: Ori Kam --- drivers/common/mlx5/mlx5_prm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git