[dpdk-dev] [PATCH] maintainers: update for Mellanox mlx5 PMD

2019-08-21 Thread Yongseok Koh
Matan thankfully accepted to replace myself as maintainer for mlx5 PMD. Good luck! Signed-off-by: Yongseok Koh --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4100260861..30dbb8be55 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[dpdk-dev] [PATCH] net/mlx5: fix TSO flag check

2019-08-20 Thread Yongseok Koh
Fix some mistakes in Tx bursts in regard to TSO flag check. Fixes: 18a1c20044c0 ("net/mlx5: implement Tx burst template") Cc: viachesl...@mellanox.com Cc: sta...@dpdk.org Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_rxtx.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[dpdk-dev] 17.11.7-rc1 (LTS) patches review and test

2019-08-15 Thread Yongseok Koh
packet type Xiao Wang (1): net/fm10k: fix VLAN strip offload flag Yipeng Wang (1): hash: fix doc about thread/process safety Yongseok Koh (4): net/mlx5: fix instruction hotspot on replenishing Rx buffer net/mlx5: check Tx queue size overflow net/mlx5: fix max number of

Re: [dpdk-dev] [PATCH v4 6/8] net/mlx5: introduce Tx burst routine template

2019-07-22 Thread Yongseok Koh
> On Jul 22, 2019, at 9:45 AM, Ferruh Yigit wrote: > > On 7/22/2019 2:07 PM, Slava Ovsiienko wrote: >>> -Original Message- >>> From: Ferruh Yigit >>> Sent: Monday, July 22, 2019 14:53 >>> To: Slava Ovsiienko ; dev@dpdk.org >>> Cc:

Re: [dpdk-dev] [PATCH v2 1/2] net/mlx5: cache the associated network device ifindex

2019-07-21 Thread Yongseok Koh
and use the cached value further > instead of doing actual Netlink request. > > Reported-by: Stephen Hemminger > Signed-off-by: Viacheslav Ovsiienko > --- Acked-by: Yongseok Koh > drivers/net/mlx5/mlx5.c| 7 +++ > drivers/net/mlx5/mlx5.h| 1 + > drivers/

Re: [dpdk-dev] [PATCH v2 2/2] Revert "net/mlx5: fix master device Netlink socket sharing"

2019-07-21 Thread Yongseok Koh
28111ac9864 ("net/mlx5: fix master device Netlink socket sharing") > --- Acked-by: Yongseok Koh > drivers/net/mlx5/mlx5.h| 6 --- > drivers/net/mlx5/mlx5_ethdev.c | 109 ++--- > 2 files changed, 3 insertions(+), 112 deletions(-) >

Re: [dpdk-dev] [PATCH v4 8/8] net/mlx5: report supported max number of mbuf segments

2019-07-21 Thread Yongseok Koh
> taken into account in conservative way. > > Signed-off-by: Viacheslav Ovsiienko > --- Acked-by: Yongseok Koh > drivers/net/mlx5/mlx5_ethdev.c | 37 + > 1 file changed, 37 insertions(+) > > diff --git a/drivers/net/mlx5/mlx5_ethd

Re: [dpdk-dev] [PATCH v4 7/8] net/mlx5: implement Tx burst template

2019-07-21 Thread Yongseok Koh
igned-off-by: Viacheslav Ovsiienko > --- Acked-by: Yongseok Koh > drivers/net/mlx5/mlx5_rxtx.c | 2958 +- > drivers/net/mlx5/mlx5_rxtx.h |5 +- > 2 files changed, 2934 insertions(+), 29 deletions(-) > > diff --git a/drivers/net/mlx5/mlx5_rxt

Re: [dpdk-dev] [PATCH v4 4/8] net/mlx5: extend NIC attributes query via DevX

2019-07-21 Thread Yongseok Koh
e. > > Signed-off-by: Viacheslav Ovsiienko > --- Acked-by: Yongseok Koh > drivers/net/mlx5/mlx5.h | 5 ++ > drivers/net/mlx5/mlx5_defs.h | 18 ++ > drivers/net/mlx5/mlx5_devx_cmds.c | 102 ++- &g

Re: [dpdk-dev] [PATCH v4 5/8] net/mlx5: add Tx datapath configuration and setup

2019-07-21 Thread Yongseok Koh
> On Jul 21, 2019, at 7:24 AM, Viacheslav Ovsiienko > wrote: > > This patch updates the Tx datapath control and configuration > structures and code for mananging Tx datapath settings. > > Signed-off-by: Viacheslav Ovsiienko > --- Acked-by: Yongseok Koh &

Re: [dpdk-dev] [PATCH v4 6/8] net/mlx5: introduce Tx burst routine template

2019-07-21 Thread Yongseok Koh
t; the multiple specially tuned tx_burst routines. > > Signed-off-by: Viacheslav Ovsiienko > --- Acked-by: Yongseok Koh > drivers/net/mlx5/mlx5_rxtx.c | 520 ++- > 1 file changed, 516 insertions(+), 4 deletions(-) > > diff --git a

Re: [dpdk-dev] [PATCH v4 2/8] net/mlx5: add Tx datapath related devargs

2019-07-21 Thread Yongseok Koh
anced MPW method. > > Driver documentation is also updated. > > Signed-off-by: Viacheslav Ovsiienko > --- Acked-by: Yongseok Koh > doc/guides/nics/mlx5.rst | 155 +++-- > doc/guides/rel_notes/release_19_08.rst | 2 + > drivers/net/mlx

Re: [dpdk-dev] [PATCH v4 3/8] net/mlx5: update Tx datapath definitions

2019-07-21 Thread Yongseok Koh
priate way. This is a preparation step before introducing > the new Tx datapath implementation. > > Signed-off-by: Viacheslav Ovsiienko > --- Acked-by: Yongseok Koh > drivers/net/mlx5/mlx5_defs.h | 2 +- > drivers/net/mlx5/mlx5_prm.h | 164 ++

Re: [dpdk-dev] [PATCH v4 1/8] net/mlx5: remove Tx datapath implementation

2019-07-21 Thread Yongseok Koh
gnized by PMD > and ignored/converted to the new ones in order not > to block device probing. > > Signed-off-by: Viacheslav Ovsiienko Acked-by: Yongseok Koh > --- > doc/guides/nics/mlx5.rst | 34 +- > drivers/net/mlx5/mlx5.c | 39 +- > driver

Re: [dpdk-dev] [PATCH] ethdev: add flow tag

2019-07-10 Thread Yongseok Koh
On Tue, Jul 09, 2019 at 10:38:06AM +0200, Adrien Mazarguil wrote: > On Fri, Jul 05, 2019 at 06:05:50PM +0000, Yongseok Koh wrote: > > > On Jul 5, 2019, at 6:54 AM, Adrien Mazarguil > > > wrote: > > > > > > On Thu, Jul 04, 2019 at 04:23:02PM -0700, Yongseok

Re: [dpdk-dev] [PATCH] ethdev: extend flow metadata

2019-07-10 Thread Yongseok Koh
11:31:56AM +0200, Olivier Matz wrote: >>>>> On Thu, Jul 04, 2019 at 04:21:22PM -0700, Yongseok Koh wrote: >>>>>> Currently, metadata can be set on egress path via mbuf tx_meatadata field >>>>>> with PKT_TX_METADATA flag and RTE_FLOW_ITEM

Re: [dpdk-dev] [PATCH] ethdev: add flow tag

2019-07-08 Thread Yongseok Koh
> On Jul 5, 2019, at 11:05 AM, Yongseok Koh wrote: > > > >> On Jul 5, 2019, at 6:54 AM, Adrien Mazarguil >> wrote: >> >> On Thu, Jul 04, 2019 at 04:23:02PM -0700, Yongseok Koh wrote: >>> A tag is a transient data which can be used during fl

Re: [dpdk-dev] [PATCH] ethdev: add flow tag

2019-07-05 Thread Yongseok Koh
> On Jul 5, 2019, at 6:54 AM, Adrien Mazarguil > wrote: > > On Thu, Jul 04, 2019 at 04:23:02PM -0700, Yongseok Koh wrote: >> A tag is a transient data which can be used during flow match. This can be >> used to store match result from a previous table so that the sam

[dpdk-dev] [PATCH] ethdev: add flow tag

2019-07-04 Thread Yongseok Koh
: Yongseok Koh --- app/test-pmd/cmdline_flow.c| 75 ++ doc/guides/prog_guide/rte_flow.rst | 50 + doc/guides/rel_notes/release_19_08.rst | 4 ++ lib/librte_ethdev/rte_flow.h | 54 +++ 4 files changed, 183 insertions

[dpdk-dev] [PATCH] ethdev: extend flow metadata

2019-07-04 Thread Yongseok Koh
to the other path depending on HW capability. Signed-off-by: Yongseok Koh --- app/test-pmd/cmdline_flow.c| 35 app/test-pmd/util.c| 2 +- doc/guides/prog_guide/rte_flow.rst | 73 ++ doc/guides/rel_notes/release_19_08.rst | 10

Re: [dpdk-dev] [PATCH v2 02/14] drivers: use new memory locking API

2019-06-28 Thread Yongseok Koh
gt; drivers/net/mlx4/mlx4_mr.c | 11 +-- > drivers/net/mlx5/mlx5_mr.c | 11 +-- For mlx4/5 PMDs, Acked-by: Yongseok Koh > drivers/net/virtio/virtio_user/virtio_user_dev.c | 7 +++ > 4 files changed, 16 insertions(+), 21 deletions

Re: [dpdk-dev] [PATCH] net/mlx5: fix 32b compilation

2019-06-12 Thread Yongseok Koh
> On Jun 11, 2019, at 10:32 PM, Shahaf Shuler wrote: > > 32b Compilation output the below error: > > drivers/net/mlx5/mlx5_txq.c: In function 'mlx5_txq_ibv_new': > error: format '%lx' expects argument of type 'long unsigned int', but > argument 8 has type 'off_t' [-Werror=format=] > DRV_LOG(D

[dpdk-dev] warning on remapping memory

2019-06-11 Thread Yongseok Koh
Hi Anatoly, There's a report that remap fails on a specific x86 host. We can silence this warning by specifying '--base-virtaddr', but wondering if you know in which case it could happen. Log attached. Thanks, Yongseok EAL: Detected lcore 0 as core 0 on socket 0 EAL: Detected lcore 1 as core

Re: [dpdk-dev] [RFC 1/3] ethdev: extend flow metadata

2019-06-10 Thread Yongseok Koh
On Mon, Jun 10, 2019 at 10:20:28AM +0300, Andrew Rybchenko wrote: > On 6/10/19 6:19 AM, Wang, Haiyue wrote: > > > -Original Message- > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andrew Rybchenko > > > Sent: Sunday, June 9, 2019 22:24

Re: [dpdk-dev] Please revert mlx IOVA VA mode patch

2019-06-07 Thread Yongseok Koh
144, count:2730 > (hung) > > The problem does not occur without SRIOV (or if MLX driver is not > compiled in). > > Doing bisect the problem is caused by: > > commit 69c06d0e357ed0064b498d510d169603cf7308cd > Author: Yongseok Koh > Date: Thu May 2 02:07:54 2019 -07

Re: [dpdk-dev] [RFC 2/3] ethdev: add flow modify mark action

2019-06-06 Thread Yongseok Koh
> On Jun 6, 2019, at 3:35 AM, Jerin Jacob Kollanukkaran > wrote: > >> -Original Message- >> From: dev On Behalf Of Yongseok Koh >> Sent: Tuesday, June 4, 2019 3:03 AM >> To: shah...@mellanox.com; tho...@monjalon.net; ferruh.yi...@intel.com; >> a

Re: [dpdk-dev] [RFC] ethdev: enhance metadata as flow rule criteria

2019-06-03 Thread Yongseok Koh
This has been overridden by another RFC. http://patches.dpdk.org/project/dpdk/list/?series=4875 Thanks, Yongseok > On May 16, 2019, at 8:31 AM, Moti Haimovsky wrote: > > Current implementation of rte_flow metadata match sets metadata only > for egress traffic leaving the need for such feature

[dpdk-dev] [RFC 3/3] ethdev: add flow tag

2019-06-03 Thread Yongseok Koh
: Yongseok Koh --- doc/guides/prog_guide/rte_flow.rst | 50 +++ lib/librte_ethdev/rte_flow.h | 54 ++ 2 files changed, 104 insertions(+) diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst index 2907edfff4

[dpdk-dev] [RFC 1/3] ethdev: extend flow metadata

2019-06-03 Thread Yongseok Koh
to the other path depending on HW capability. Signed-off-by: Yongseok Koh --- app/test-pmd/util.c | 2 +- doc/guides/prog_guide/rte_flow.rst| 73 +++ drivers/net/mlx5/mlx5_rxtx.c | 12 ++--- drivers/net/mlx5/mlx5_rxtx_vec.c | 4 +-

[dpdk-dev] [RFC 2/3] ethdev: add flow modify mark action

2019-06-03 Thread Yongseok Koh
Mark ID can be modified when supporting multiple tables. Partial bit alteration is supported to preserve some bit-fields set by previous match. Signed-off-by: Yongseok Koh --- doc/guides/prog_guide/rte_flow.rst | 21 + lib/librte_ethdev/rte_flow.h | 24

[dpdk-dev] [dpdk-announce] DPDK 17.11.6 released

2019-05-22 Thread Yongseok Koh
Hi all, Here is a new stable release: https://fast.dpdk.org/rel/dpdk-17.11.6.tar.xz The git tree is at: https://dpdk.org/browse/dpdk-stable/?h=17.11 Please note that the list of missing patches is attached at the end. Thanks, Yongseok --- app/test-pmd/cmdline_tm.c

Re: [dpdk-dev] [PATCH] net/mlx5: fix device removal handler for multiport device

2019-05-10 Thread Yongseok Koh
> On May 10, 2019, at 7:36 AM, Viacheslav Ovsiienko > wrote: > > IBV_EVENT_DEVICE_FATAL event is generated by the driver once for > the entire multiport Infiniband device, not for each existing ports. > The port index is zero and it causes dropping the device removal > event. We should invoke

Re: [dpdk-dev] [PATCH] doc: update release notes for Mellanox drivers

2019-05-09 Thread Yongseok Koh
> On May 9, 2019, at 2:31 PM, Thomas Monjalon wrote: > > 09/05/2019 23:11, Yongseok Koh: >> --- a/doc/guides/rel_notes/release_19_05.rst >> +++ b/doc/guides/rel_notes/release_19_05.rst >> -* **Updated Mellanox drivers.** >> +* **Updated Mellanox mlx4

[dpdk-dev] [PATCH] doc: update release notes for Mellanox drivers

2019-05-09 Thread Yongseok Koh
mlx4/mlx5 release note for v19.05 Signed-off-by: Yongseok Koh --- doc/guides/rel_notes/release_19_05.rst | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/doc/guides/rel_notes/release_19_05.rst b/doc/guides/rel_notes/release_19_05.rst index

[dpdk-dev] [PATCH v2] doc: add Mellanox BlueField platform guide

2019-05-08 Thread Yongseok Koh
Platform specific guide for Mellanox BlueField SoC is added. Signed-off-by: Yongseok Koh --- v2: * remove release note update * cosmetic changes * make contents clearer .../linux_gsg/cross_build_dpdk_for_arm64.rst | 2 + doc/guides/platform/bluefield.rst | 147

Re: [dpdk-dev] [PATCH] doc: add Mellanox BlueField platform guide

2019-05-08 Thread Yongseok Koh
> On May 8, 2019, at 1:27 AM, Thomas Monjalon wrote: > > 08/05/2019 04:04, Yongseok Koh: >> --- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst >> +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst >> +.. _getting_the_prerequisite_library: > > The n

[dpdk-dev] [PATCH] doc: fix typo in mlx5 guide

2019-05-08 Thread Yongseok Koh
Fixes: 43e9d9794cde ("net/mlx5: support upstream rdma-core") Cc: sta...@dpdk.org Signed-off-by: Yongseok Koh --- doc/guides/nics/mlx5.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index af1e408ead..325e9f6

[dpdk-dev] [PATCH] doc: add Mellanox BlueField platform guide

2019-05-07 Thread Yongseok Koh
Platform specific guide for Mellanox BlueField SoC is added. Signed-off-by: Yongseok Koh --- .../linux_gsg/cross_build_dpdk_for_arm64.rst | 2 + doc/guides/platform/bluefield.rst | 141 ++ doc/guides/platform/index.rst | 1 + doc/guides/rel_notes

[dpdk-dev] [PATCH v3] build: disable armv8 crypto extension

2019-05-07 Thread Yongseok Koh
PDK, armv8 cryptodev is the only one which requires the crypto support. As it even uses external library of Marvell which is compiled out of DPDK with crypto support and there's run-time check for required cpuflags, crypto support can be disabled in DPDK. Cc: sta...@dpdk.org Signed-off

[dpdk-dev] [PATCH] net/mlx5: fix Multi-Packet RQ mempool name

2019-05-06 Thread Yongseok Koh
866b8 ("net/mlx5: add Multi-Packet Rx support") Cc: sta...@dpdk.org Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_rxq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index 0a4c02e71e..85e6f29188 100

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] build: disable armv8 crypto extension

2019-05-06 Thread Yongseok Koh
> On May 3, 2019, at 10:50 AM, Yongseok Koh wrote: > >> I think this change might have an impact on the existing users. Does this >> change need to be documented somewhere (at least in the release notes)? > > Practically, there would be no impact. Even if user&#

Re: [dpdk-dev] [PATCH v2] build: disable armv8 crypto extension

2019-05-06 Thread Yongseok Koh
xapp-gcc’, > at the end of the build process it said 'Build complete > [arm64-armv8a-linuxapp-gcc]’ The BlueField config stems from armv8a. Unlike Cavium hosts, RTE_MACHINE is still armv8a. Looks it is same for Broadcom's Stingray. > Tested-by: Dharmik Thakkar > &g

Re: [dpdk-dev] [PATCH v2] build: disable armv8 crypto extension

2019-05-03 Thread Yongseok Koh
A%2F%2Fdoc.dpdk.org%2Fguides-19.02%2Fcryptodevs%2Farmv8.html&data=02%7C01%7Cyskoh%40mellanox.com%7C4d6fc9819e4e4a5b1ba508d6cfe1e91d%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636924966530971290&sdata=r3VFKjX44T1g4ORlibYCuCpCDQl1BPQyhzfEe%2BGz%2Fy8%3D&reserved=0 > > > > > -Or

[dpdk-dev] [PATCH v2] build: disable armv8 crypto extension

2019-05-03 Thread Yongseok Koh
PDK, armv8 cryptodev is the only one which requires the crypto support. As it even uses external library of Marvell which is compiled out of DPDK with crypto support and there's run-time check for required cpuflags, crypto support can be disabled in DPDK. Cc: sta...@dpdk.org Signed-off-by

Re: [dpdk-dev] [PATCH 1/2] build: add option for armv8 crypto extension

2019-05-03 Thread Yongseok Koh
we should consider it as bug. You may probably know, cpu w/o crypto is related to the export licenses. Sometimes, vendor has to disable it when exporting in certain conditions. And as BlueField is still in early stage, we don't mind much existing distro packages not being able to run on

Re: [dpdk-dev] [EXT] [PATCH 5/6] build: add option for armv8 crypto extension

2019-05-03 Thread Yongseok Koh
On Fri, May 03, 2019 at 03:54:09AM +, Honnappa Nagarahalli wrote: > > >>> On Apr 15, 2019, at 1:13 PM, Honnappa Nagarahalli > > >>> wrote: > > >>> > > >>> Subject: [EXT] [PATCH 5/6] build: add option for armv8 crypto > > >>> extension > > >>> > > >>> CONFIG_RTE_MACHINE="armv8a"

Re: [dpdk-dev] [EXT] [PATCH 5/6] build: add option for armv8 crypto extension

2019-05-02 Thread Yongseok Koh
> On May 2, 2019, at 4:08 PM, Yongseok Koh wrote: > >> >> On May 2, 2019, at 3:13 AM, Jerin Jacob Kollanukkaran >> wrote: >> >>> -Original Message- >>> From: Honnappa Nagarahalli >>> Sent: Tuesday, April 30, 2019 9:04 AM >

Re: [dpdk-dev] [EXT] [PATCH 5/6] build: add option for armv8 crypto extension

2019-05-02 Thread Yongseok Koh
> On May 2, 2019, at 3:13 AM, Jerin Jacob Kollanukkaran > wrote: > >> -Original Message- >> From: Honnappa Nagarahalli >> Sent: Tuesday, April 30, 2019 9:04 AM >> To: ys...@mellanox.com >> Cc: Jerin Jacob Kollanukkaran ; >> bruce.richard...@intel.com; Pavan Nikhilesh Bhagavatula >> ;

Re: [dpdk-dev] [PATCH v2 4/4] net/mlx5: move locally used functions to static

2019-05-02 Thread Yongseok Koh
ons. > Some functions implementation was copied higher in the file to > precede the functions calls. > > Signed-off-by: Dekel Peled > --- Acked-by: Yongseok Koh > drivers/net/mlx5/mlx5_rxq.c | 185 +-- > drivers/net/mlx5/mlx5_rxtx.h | 16 ---

Re: [dpdk-dev] [PATCH v2 3/4] net/mlx5: fix description of function return value

2019-05-02 Thread Yongseok Koh
es: a6d83b6a9209 ("net/mlx5: standardize on negative errno values") > cc: sta...@dpdk.org > > Signed-off-by: Dekel Peled > --- Acked-by: Yongseok Koh > drivers/net/mlx5/mlx5_rxq.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/

Re: [dpdk-dev] [PATCH v2 1/4] net/mlx5: remove unused functions

2019-05-02 Thread Yongseok Koh
ves these functions from code and header file. > > Signed-off-by: Dekel Peled > --- Acked-by: Yongseok Koh > drivers/net/mlx5/mlx5_rxq.c | 31 --- > drivers/net/mlx5/mlx5_rxtx.h | 4 > drivers/net/mlx5/mlx5_txq.c | 13 - > 3 files

Re: [dpdk-dev] [PATCH v2 2/4] net/mlx5: fix missing validation of null pointer

2019-05-02 Thread Yongseok Koh
d with mlx5_rxq_ibv_release() This would need a separate patch. 2) In mlx5_rx_intr_vec_disable() Please fix the comment having the old name - priv_rx_intr_vec_enable(). This should be mlx5_rx_intr_vec_enable() No need to have a separate patch. You can fix it in this patch. With the change, Acked-by: Yongseok Koh > } > free: > rte_intr_free_epoll_fd(intr_handle); > -- > 1.8.3.1 >

[dpdk-dev] [PATCH v3 2/2] net/mlx: support IOVA VA mode

2019-05-02 Thread Yongseok Koh
Set RTE_PCI_DRV_IOVA_AS_VA to driver's drv_flags as device's IOMMU takes virtual address. Cc: sta...@dpdk.org Signed-off-by: Yongseok Koh --- v3: * no change v2: * add RTE_KDRV_NIC_MLX drivers/net/mlx4/mlx4.c | 4 ++-- drivers/net/mlx5/mlx5.c | 4 ++-- 2 files changed, 4 insert

[dpdk-dev] [PATCH v3 1/2] bus/pci: add Mellanox kernel driver type

2019-05-02 Thread Yongseok Koh
h the existing kernel driver, which is mlx4_core/mlx5_core. In order to make RTE_PCI_DRV_IOVA_AS_VA effective for mlx4/mlx5 PMD, a new kernel driver type has to be introduced. Cc: sta...@dpdk.org Signed-off-by: Yongseok Koh --- v3: * make commit log more explanatory v2: * add RTE_KDRV_NIC_MLX driver

[dpdk-dev] [PATCH v2 2/2] net/mlx: support IOVA VA mode

2019-05-02 Thread Yongseok Koh
Set RTE_PCI_DRV_IOVA_AS_VA to driver's drv_flags as device's IOMMU takes virtual address. Cc: sta...@dpdk.org Signed-off-by: Yongseok Koh --- v2: * add RTE_KDRV_NIC_MLX drivers/net/mlx4/mlx4.c | 4 ++-- drivers/net/mlx5/mlx5.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletion

[dpdk-dev] [PATCH v2 1/2] bus/pci: add Mellanox kernel driver type

2019-05-02 Thread Yongseok Koh
Mellanox mlx4/5 PMD doesn't need to be detached from kernel driver and attached to VFIO/UIO. Control path still goes through the existing kernel drivers, which is mlx4_core/mlx5_core. Cc: sta...@dpdk.org Signed-off-by: Yongseok Koh --- v2: * add RTE_KDRV_NIC_MLX drivers/bus/pci/linux/

Re: [dpdk-dev] [PATCH] net/mlx: support IOVA VA mode

2019-05-02 Thread Yongseok Koh
> On May 1, 2019, at 6:44 PM, Yongseok Koh wrote: > > Set RTE_PCI_DRV_IOVA_AS_VA to driver's drv_flags as device's IOMMU takes > virtual address. > > Cc: sta...@dpdk.org > Cc: Davide Caratti > > Signed-off-by: Yongseok Koh > --- Self n

Re: [dpdk-dev] [PATCH 1/2] build: add option for armv8 crypto extension

2019-05-01 Thread Yongseok Koh
e enabled in specific target machine configs. I make it enabled by default simply because I don't want to change the current behavior, no breakage. I also want to hear from others. Jerin, Thomas? >> >> Signed-off-by: Yongseok Koh >> --- >> config/arm/meson.build

Re: [dpdk-dev] [PATCH 2/2] mk: disable armv8 crypto extension for Mellanox BlueField

2019-05-01 Thread Yongseok Koh
ity across multiple variants, it is disabled by default and >> can >> be enabled for crypto enabled parts. >> >> Signed-off-by: Yongseok Koh >> --- >> config/defconfig_arm64-bluefield-linuxapp-gcc | 6 ++ >> 1 file changed, 6 insertions(+) >>

[dpdk-dev] [PATCH 2/2] mk: disable armv8 crypto extension for Mellanox BlueField

2019-05-01 Thread Yongseok Koh
Mellanox BlueField has a variant which doesn't have armv8 crypto extension. If crypto enabled binary runs on such a pltform, rte_eal_init() fails. To have binary compatibility across multiple variants, it is disabled by default and can be enabled for crypto enabled parts. Signed-off-by: Yon

[dpdk-dev] [PATCH 1/2] build: add option for armv8 crypto extension

2019-05-01 Thread Yongseok Koh
re, an option to control this feature is necessary. It is still enabled by default but can be selectively disabled by vendors. Signed-off-by: Yongseok Koh --- config/arm/meson.build| 16 +--- config/common_armv8a_linux| 1 + drivers/crypto/armv8/Makefile | 4 meson_opt

Re: [dpdk-dev] [EXT] [PATCH 5/6] build: add option for armv8 crypto extension

2019-05-01 Thread Yongseok Koh
> On Apr 29, 2019, at 8:33 PM, Honnappa Nagarahalli > wrote: > >> On Apr 15, 2019, at 1:13 PM, Honnappa Nagarahalli >> wrote: >> >> Subject: [EXT] [PATCH 5/6] build: add option for armv8 crypto >> extension >> >> CONFIG_RTE_MACHINE="armv8a" >> +CONFIG_RTE_ENABLE_ARMV8_CR

[dpdk-dev] [PATCH] net/mlx: support IOVA VA mode

2019-05-01 Thread Yongseok Koh
Set RTE_PCI_DRV_IOVA_AS_VA to driver's drv_flags as device's IOMMU takes virtual address. Cc: sta...@dpdk.org Cc: Davide Caratti Signed-off-by: Yongseok Koh --- drivers/net/mlx4/mlx4.c | 4 ++-- drivers/net/mlx5/mlx5.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) di

[dpdk-dev] [PATCH] net/mlx5: fix max number of queues for NEON Tx

2019-04-30 Thread Yongseok Koh
make vectorized Tx threshold configurable") Cc: sta...@dpdk.org Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_defs.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_defs.h b/drivers/net/mlx5/mlx5_defs.h index 69b6960e94..13801a5c2d 10

Re: [dpdk-dev] [PATCH v2] net/mlx5: check Tx queue size overflow

2019-04-30 Thread Yongseok Koh
> On Apr 30, 2019, at 6:01 PM, Yongseok Koh wrote: > > If Tx packet inlining is enabled, rdma-core library should allocate large > Tx WQ enough to support it. It is better for PMD to calculate the size of > WQ based on the parameters and return error with appropriate message

[dpdk-dev] [PATCH v2] net/mlx5: check Tx queue size overflow

2019-04-30 Thread Yongseok Koh
If Tx packet inlining is enabled, rdma-core library should allocate large Tx WQ enough to support it. It is better for PMD to calculate the size of WQ based on the parameters and return error with appropriate message if it exceeds the device capability. Cc:sta...@dpdk.org Signed-off-by: Yongseok

Re: [dpdk-dev] [PATCH] net/mlx5: check Tx queue size overflow

2019-04-30 Thread Yongseok Koh
> On Apr 30, 2019, at 5:43 PM, Yongseok Koh wrote: > >> >> On Apr 30, 2019, at 1:46 PM, Stephen Hemminger >> wrote: >> >> On Tue, 30 Apr 2019 12:04:26 -0700 >> Yongseok Koh wrote: >> >>> + priv->sh->d

Re: [dpdk-dev] [PATCH] net/mlx5: check Tx queue size overflow

2019-04-30 Thread Yongseok Koh
> On Apr 30, 2019, at 1:46 PM, Stephen Hemminger > wrote: > > On Tue, 30 Apr 2019 12:04:26 -0700 > Yongseok Koh wrote: > >> +priv->sh->device_attr.orig_attr.max_qp_wr) { >> +DRV_LOG(DEBUG, >> +&qu

[dpdk-dev] [PATCH] net/mlx5: check Tx queue size overflow

2019-04-30 Thread Yongseok Koh
If Tx packet inlining is enabled, rdma-core library should allocate large Tx WQ enough to support it. It is better for PMD to calculate the size of WQ based on the parameters and return error with appropriate message if it exceeds the device capability. Signed-off-by: Yongseok Koh --- drivers

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] examples/multi_process: fix buffer underrun

2019-04-30 Thread Yongseok Koh
> On Apr 11, 2019, at 12:18 AM, Yongseok Koh wrote: > >> On Apr 10, 2019, at 12:41 PM, Yongseok Koh wrote: >> >> For client_server_mp, the total number of buffers for the mbuf mempool >> should be correctly calculated. Otherwise, having more clients will

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix E-Switch flow without port item

2019-04-25 Thread Yongseok Koh
urce port. > > Fixes: 822fb3195348 ("net/mlx5: add port id item to Direct Verbs") > > Signed-off-by: Ori Kam > --- Acked-by: Yongseok Koh > drivers/net/mlx5/mlx5_flow_dv.c | 30 +++--- > 1 file changed, 15 insertions(+), 15 deletions(-)

Re: [dpdk-dev] [PATCH] net/mlx5: fix E-Switch flow without port item

2019-04-25 Thread Yongseok Koh
> On Apr 25, 2019, at 12:02 AM, Ori Kam wrote: > > Hi Yongseok, > PSB, > > Ori > >> -Original Message- >> From: Yongseok Koh >> Sent: Wednesday, April 24, 2019 12:03 AM >> To: Ori Kam >> Cc: Shahaf Shuler ; Matan Azrad >> ; de

Re: [dpdk-dev] [PATCH v2] net/mlx5: share Memory Regions for multiport device

2019-04-24 Thread Yongseok Koh
iniban device. > The datapath of mlx5 uses the layered cache subsystem for > allocating/releasing Memory Regions, only the lowest layer L3 > is subject to share due to performance issues. > > [1] http://patches.dpdk.org/cover/51800/ > > Signed-off-by: Viacheslav Ovsiienk

[dpdk-dev] [PATCH] net/mlx5: fix flow action destroy

2019-04-23 Thread Yongseok Koh
ibv_destroy_flow_action() refers to QP. QP must not be freed until corresponding action is destroyed. Fixes: 3eb004431072 ("net/mlx5: fix release of jump to queue action") Cc: or...@mellanox.com Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_rxq.c | 8 1 file

Re: [dpdk-dev] [PATCH] net/mlx5: fix E-Switch flow without port item

2019-04-23 Thread Yongseok Koh
On Tue, Apr 23, 2019 at 11:19:16AM +, Ori Kam wrote: > When creating a flow rule without the port_id pattern item, always the > PF was selected. > > This commit fixes this issue, if no port_id pattern item is available > then we use the port that the flow was created on as source port. > > Fi

Re: [dpdk-dev] [PATCH v2 7/8] ipc: fix net/mlx4 memleak

2019-04-23 Thread Yongseok Koh
9b8e9655 ("net/mlx4: enable secondary process to register DMA > memory") > Cc: ys...@mellanox.com > Signed-off-by: Herakliusz Lipiec > --- Acked-by: Yongseok Koh > drivers/net/mlx4/mlx4_mp.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --

Re: [dpdk-dev] [PATCH v2 8/8] ipc: fix net/mlx5 memleak

2019-04-23 Thread Yongseok Koh
29b84d3 ("net/mlx5: replace IPC socket with EAL API") > Fixes: c18cf501a7af ("net/mlx5: enable secondary process to register DMA > memory") > Cc: ys...@mellanox.com > Signed-off-by: Herakliusz Lipiec > --- Acked-by: Yongseok Koh > drivers/net/mlx5

Re: [dpdk-dev] [PATCH 8/8] ipc: fix net/mlx5 memleak

2019-04-23 Thread Yongseok Koh
> On Apr 23, 2019, at 1:09 AM, Burakov, Anatoly > wrote: > > On 22-Apr-19 6:51 PM, Yongseok Koh wrote: >>> On Apr 17, 2019, at 7:44 AM, Herakliusz Lipiec >>> wrote: >>> >>> When sending multiple requests, rte_mp_request_sync >>&

Re: [dpdk-dev] [PATCH 8/8] ipc: fix net/mlx5 memleak

2019-04-22 Thread Yongseok Koh
> On Apr 17, 2019, at 7:44 AM, Herakliusz Lipiec > wrote: > > When sending multiple requests, rte_mp_request_sync > can succeed sending a few of those requests, but then > fail on a later one and in the end return with rc=-1. > The upper layers - e.g. device hotplug - currently > handles this

[dpdk-dev] [PATCH] net/mlx5: fix Direct Rules build

2019-04-19 Thread Yongseok Koh
All the library calls must be called via the glue layer. Fixes: b2177648b8de ("net/mlx5: add Direct Rules flow data alloc/free routines") Fixes: 79e35d0d5979 ("net/mlx5: share Direct Rules/Verbs flow related structures") Cc: viachesl...@mellanox.com Signed-off-by: Yongseok K

Re: [dpdk-dev] [PATCH v2 1/1] test/compress: add max mbuf size test case

2019-04-18 Thread Yongseok Koh
Hi, I'm seeing compile error. Isn't it due to this patch? $ gcc --version gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28) [1484/1523] Compiling C object 'app/test/app@test@@dpdk-test@exe/test_compressdev.c.o'. FAILED: app/test/app@test@@dpdk-test@exe/test_compressdev.c.o cc -Iapp/test/app@test@@dp

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix modify header action position

2019-04-18 Thread Yongseok Koh
he position of the first modify > action, and then adds to this position the pointer to the modify action. > > Fixes: 4bb14c83df95 ("net/mlx5: support modify header using Direct Verbs") > Cc: dek...@mellanox.com > Cc: sta...@dpdk.org > > Signed-off-by: Ori Kam > ---

Re: [dpdk-dev] [PATCH v3 9/9] net/mlx5: add drop action to Direct Verbs E-Switch

2019-04-18 Thread Yongseok Koh
> On Apr 18, 2019, at 6:16 AM, Ori Kam wrote: > > This commit adds support for drop action when creating E-Switch flow > using DV. > > Signed-off-by: Ori Kam > Acked-by: Yongseok Koh > --- > drivers/net/mlx5/mlx5.c | 9 + > drivers/net/mlx5/mlx5.

Re: [dpdk-dev] [PATCH v2 9/9] net/mlx5: add drop action to Direct Verbs E-Switch

2019-04-18 Thread Yongseok Koh
On Thu, Apr 18, 2019 at 11:28:50AM +, Ori Kam wrote: > This commit adds support for drop action when creating E-Switch flow > using DV. > > Signed-off-by: Ori Kam > --- > v2: > * Address ML comments. > --- > drivers/net/mlx5/mlx5.c | 9 + > drivers/net/mlx5/mlx5.h |

Re: [dpdk-dev] [PATCH v2 8/9] net/mlx5: add Forward Database table type

2019-04-18 Thread Yongseok Koh
m > --- Acked-by: Yongseok Koh > v2: > * Address ML comments. > --- > drivers/net/mlx5/mlx5_flow_dv.c | 56 > + > 1 file changed, 40 insertions(+), 16 deletions(-) > > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drive

Re: [dpdk-dev] [PATCH v2 7/9] net/mlx5: add E-Switch port ID action to Direct Verbs

2019-04-18 Thread Yongseok Koh
On Thu, Apr 18, 2019 at 11:28:48AM +, Ori Kam wrote: > This commits adds matching on source port, using DV API. > > Signed-off-by: Ori Kam > --- Acked-by: Yongseok Koh > v2: > * Address ML comments. > --- > drivers/net/mlx5/mlx5.h | 2 + > drivers/ne

Re: [dpdk-dev] [PATCH v2 6/9] net/mlx5: add transfer attribute to matcher

2019-04-18 Thread Yongseok Koh
On Thu, Apr 18, 2019 at 11:28:47AM +, Ori Kam wrote: > In current implementation the DV steering supported only NIC steering. > This commit adds the transfer attribute in order to create a matcher > on the FDB tabels. > > Signed-off-by: Ori Kam > --- Acked-by: Y

Re: [dpdk-dev] [PATCH v2 5/9] net/mlx5: add port ID item to Direct Verbs

2019-04-18 Thread Yongseok Koh
On Thu, Apr 18, 2019 at 11:28:46AM +, Ori Kam wrote: > Adds the port ID item to the DV steering code. > > Signed-off-by: Ori Kam > --- Acked-by: Yongseok Koh > v2: > * Address ML comments. > --- > drivers/net/mlx5/mlx5_flow_dv.c | 84 >

Re: [dpdk-dev] [PATCH v2 4/9] net/mlx5: add validation for Direct Rule E-Switch

2019-04-18 Thread Yongseok Koh
On Thu, Apr 18, 2019 at 11:28:45AM +, Ori Kam wrote: > Add validation logic for E-Switch using Direct Rules. > > Signed-off-by: Ori Kam > --- Acked-by: Yongseok Koh > v2: > * Address ML comments. > --- > drivers/net/mlx5/mlx5.h | 2 + > drivers/ne

Re: [dpdk-dev] [PATCH v2 3/9] net/mlx5: add Direct Rules E-Switch support

2019-04-18 Thread Yongseok Koh
ne minor nit below. With the fix, Acked-by: Yongseok Koh > v2: > * Address ML comments. > --- > drivers/net/mlx5/Makefile | 5 + > drivers/net/mlx5/meson.build | 2 + > drivers/net/mlx5/mlx5.c | 53 +- > drivers/net/mlx5/mlx5.h | 12

Re: [dpdk-dev] [PATCH v2 2/9] net/mlx5: fix meson build for Direct Rules

2019-04-18 Thread Yongseok Koh
On Thu, Apr 18, 2019 at 11:28:43AM +, Ori Kam wrote: > The meson build was missing the define for Direct Rules. > > Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API") > Cc: or...@mellanox.com > > Signed-off-by: Ori Kam Acked-by: Yongseok Koh > --

Re: [dpdk-dev] [PATCH v2 1/9] net/mlx5: fix translate vport function name

2019-04-18 Thread Yongseok Koh
t; Signed-off-by: Ori Kam You were supposed to change the name to flow_dv_translate_item_src_vport, but that's fine. Acked-by: Yongseok Koh > --- > v2: > * Address ML comments. > --- > drivers/net/mlx5/mlx5_flow_dv.c | 12 ++-- > 1 file changed, 6 insertions

[dpdk-dev] [PATCH v3 4/4] meson: add Mellanox BlueField cross-compile config

2019-04-18 Thread Yongseok Koh
Mellanox BlueField is armv8 CPU having cortex-a72. The implementor ID is 0x41 (arm) and the primary part number is 0xd08 (cortex-a72). Signed-off-by: Yongseok Koh Acked-by: Jerin Jacob --- config/arm/arm64_bluefield_linux_gcc | 16 1 file changed, 16 insertions(+) create mode

[dpdk-dev] [PATCH v3 3/4] net/mlx: fix library search in meson build

2019-04-18 Thread Yongseok Koh
.@debian.org Cc: sta...@dpdk.org Signed-off-by: Yongseok Koh --- v3: * use lib name without 'lib' prefix for cc.find_library() v2: * change variable names to minimize code change drivers/net/mlx4/meson.build | 15 +-- drivers/net/mlx5/meson.build | 15 +-- 2 files

[dpdk-dev] [PATCH v3 1/4] drivers/event: disable octeontx for buggy compilers on arm64

2019-04-18 Thread Yongseok Koh
buggy compilers only on arm64") Cc: pbhagavat...@marvell.com Cc: jer...@marvell.com Cc: sta...@dpdk.org Signed-off-by: Yongseok Koh Acked-by: Jerin Jacob --- v3: * fix prefix of the title v2: * fix bug - enable octeontx unless the buggy compiler is used drivers/event/meson.build | 6 ++

[dpdk-dev] [PATCH v3 2/4] meson: change default config for armv8

2019-04-18 Thread Yongseok Koh
Current default cache line size for armv8 CPUs having Implementor ID of 0x41 is 128 bytes, changing it to 64 bytes. Also, the max number of lcores is changed to 16 from 256. Signed-off-by: Yongseok Koh --- v3: * decrease RTE_MAX_LCORE to 16 from 256 * change title and commit log v2

Re: [dpdk-dev] [EXT] Re: [PATCH v2 2/4] meson: change default cache line size for armv8

2019-04-18 Thread Yongseok Koh
; >>> >>> Currently, the cache line size of armv8 CPUs having Implementor ID of >>> 0x41 is >>> 64 bytes. >> I guess you meant to say 128 bytes > > > "the current default is 128, changing it to 64." Yep, the message was wrong. Wi

Re: [dpdk-dev] [PATCH 3/6] net/mlx: fix library search in meson build

2019-04-18 Thread Yongseok Koh
> On Apr 18, 2019, at 3:14 AM, Bruce Richardson > wrote: > > On Thu, Apr 18, 2019 at 10:25:19AM +0100, Luca Boccassi wrote: >> On Mon, 2019-04-15 at 19:48 +, Yongseok Koh wrote: >>> Hi, >>> >>> >>> >>> Thanks, >>>

Re: [dpdk-dev] [EXT] [PATCH v2 1/4] meson: disable octeontx for buggy compilers on arm64

2019-04-18 Thread Yongseok Koh
> On Apr 18, 2019, at 4:04 AM, Thomas Monjalon wrote: > > 18/04/2019 12:41, Yongseok Koh: >>> On Apr 18, 2019, at 12:21 AM, Jerin Jacob Kollanukkaran >>> wrote: >>> From: Yongseok Koh >>> Nit: >>> [master] [dpdk.org] $ ./devtools/check

Re: [dpdk-dev] [EXT] [PATCH v2 1/4] meson: disable octeontx for buggy compilers on arm64

2019-04-18 Thread Yongseok Koh
> On Apr 18, 2019, at 12:21 AM, Jerin Jacob Kollanukkaran > wrote: > > >> -Original Message- >> From: Yongseok Koh >> Sent: Thursday, April 18, 2019 7:17 AM >> To: bruce.richard...@intel.com; Jerin Jacob Kollanukkaran >> ; Pavan Nikhilesh B

  1   2   3   4   5   6   7   8   9   10   >