[RFC v2 2/2] ethdev: queue-based flow aged report

2022-06-01 Thread Xiaoyu Min
above change, another new API is added which help the application get information about which queues have aged out flows after RTE_ETH_EVENT_FLOW_AGED event received. The queried queue id can be used in the above queue based query aged flows API. Signed-off-by: Xiaoyu Min --- lib/ethdev/rte_f

[RFC v2 1/2] ethdev: port flags for pre-configuration flow hints

2022-06-01 Thread Xiaoyu Min
resource could be isolated and access based on queue, without lock, for example. This patch add flag about above situation and could be extended to cover more situations. Signed-off-by: Xiaoyu Min --- lib/ethdev/rte_flow.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/lib/ethdev

[RFC 0/2] queue-based flow aged report

2022-06-01 Thread Xiaoyu Min
which queues have aged out flows instead of passing queue id via *ret_param* in event. - Use bit flags instead of enum - Fix typo and wording Xiaoyu Min (2): ethdev: port flags for pre-configuration flow hints ethdev: queue-based flow aged report lib/ethdev/rte_flow.h

[RFC 2/2] ethdev: queue-based flow aged report

2022-04-06 Thread Xiaoyu Min
isolated by queue and needn't synchronize. If application do use queue-based flow management but configure port without RTE_FLOW_PORT_FLAG_STRICT_QUEUE, which means application operate the same flow on different queues, the queue id parameter will be ignored. Signed-off-by: Xiaoyu Min --- doc/g

[RFC 1/2] ethdev: port flags for pre-configuration flow hints

2022-04-06 Thread Xiaoyu Min
ource could be isolated and access based on queue, without lock for example. This patch add flag about above situation and could be extanded to cover more situations. Signed-off-by: Xiaoyu Min --- lib/ethdev/rte_flow.h | 16 1 file changed, 16 insertions(+) diff --git a/lib/e

[RFC 0/2] queue-based flow aged report

2022-04-06 Thread Xiaoyu Min
operations of the same flow happens in sequence. The current flow aged report API hasn't queue parameter as same as other queue-based flow management API. This RFC propose to add new flow aged report API with queue parameter. Keep the old one for compatibility. Xiaoyu Min (2): ethdev: port

[PATCH] net/mlx5: reject jump to root table

2022-01-18 Thread Xiaoyu Min
Currently root table as destination is not supported. The jump action which finally be translated to underlying root table in rdma-core should be rejected. Fixes: f78f747f41d0 ("net/mlx5: allow jump to group lower than current") Cc: sta...@dpdk.org Signed-off-by: Xiaoyu Min Acked-by:

[PATCH] net/mlx4: fix empty ETH spec with VLAN support

2021-11-22 Thread Xiaoyu Min
with VLAN") Cc: sta...@dpdk.org [1]: commit c0d239263156 ("net/mlx4: support flow w/o ETH spec and with VLAN") Signed-off-by: Xiaoyu Min Acked-by: Matan Azrad --- drivers/net/mlx4/mlx4_flow.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx4/mlx4_flo

[dpdk-dev] [PATCH 2/2] net/mlx5: fix missing RSS expansion of IPv6 frag

2021-07-06 Thread Xiaoyu Min
ons rss level 2 types ip end / end Signed-off-by: Xiaoyu Min --- drivers/net/mlx5/mlx5_flow.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 1b682ac8ed..90b8cf6692 100644 --- a/drivers/net/mlx5/mlx5_flow.

[dpdk-dev] [PATCH 1/2] net/mlx5: fix missing RSS expandable items

2021-07-06 Thread Xiaoyu Min
Some RSS expandable items are missing which leads to the expanded rte flow rules with wrong patterns. Fix by adding missed items. Fixes: d91093b9a2af ("net/mlx5: fix RSS pattern expansion") Cc: sta...@dpdk.org Signed-off-by: Xiaoyu Min --- drivers/net/mlx5/mlx5_flow.c | 2 ++ 1 fi

[dpdk-dev] [PATCH 0/2] fix RSS expansion missing items

2021-07-06 Thread Xiaoyu Min
This patch set fixs the missing items in RSS expansion. Xiaoyu Min (2): net/mlx5: fix missing RSS expandable items net/mlx5: fix missing RSS expansion of IPv6 frag drivers/net/mlx5/mlx5_flow.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) -- 2.32.0

[dpdk-dev] [PATCH 3/3] net/mlx5: limit inner RSS expansion for MPLS

2021-07-02 Thread Xiaoyu Min
/ mpls / eth / ipv6 / tcp [4]: pattern eth / ipv4 / udp / mpls / eth / end actions rss type tcp udp ip level 2 / end Signed-off-by: Xiaoyu Min --- drivers/net/mlx5/mlx5_flow.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c

[dpdk-dev] [PATCH 2/3] net/mlx5: fix MPLS RSS expansion

2021-07-02 Thread Xiaoyu Min
SoGRE. In addition to above, support for eth over MPLS expansion is added too. Fixes: a4a5cd21d20a ("net/mlx5: add flow MPLS item") Cc: sta...@dpdk.org Signed-off-by: Xiaoyu Min --- drivers/net/mlx5/mlx5_flow.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-

[dpdk-dev] [PATCH 1/3] net/mlx5: fix MPLS over IP

2021-07-02 Thread Xiaoyu Min
HW doesn't support match MPLS over IP traffic. Remove related code. Fixes: d1abe664ddde ("net/mlx5: add MPLS to Direct Verbs flow engine") Cc: sta...@dpdk.org Signed-off-by: Xiaoyu Min --- drivers/net/mlx5/mlx5_flow.c| 5 ++--- drivers/net/mlx5/mlx5_flow_dv.c | 3 --- 2 f

[dpdk-dev] [PATCH 0/3] MPLS RSS fixs

2021-07-02 Thread Xiaoyu Min
This patch set fixs several problems of MPLS RSS: - removed MPLSoIP(HW doesn't support) related code - support MPLSoUDP, MPLSoGRE RSS expansion - reduced number of expanded sub-flows for inner MPLS Xiaoyu Min (3): net/mlx5: fix MPLS over IP net/mlx5: fix MPLS RSS expansion net/mlx5:

[dpdk-dev] [PATCH] net/mlx5: fix match MPLS over GRE with key

2021-06-30 Thread Xiaoyu Min
match GRE key and present bits") Cc: sta...@dpdk.org Signed-off-by: Xiaoyu Min --- drivers/net/mlx5/mlx5_flow_dv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index a04a3c2bb8..feeeaf6a1d 100644 --- a/driver

[dpdk-dev] [PATCH] net/mlx5: fix redundant flow after RSS expansion

2021-03-30 Thread Xiaoyu Min
thdev: add VLAN attributes to ethernet and VLAN items") [2]: commit 86b59a1af671 ("net/mlx5: support VLAN matching fields") Signed-off-by: Xiaoyu Min --- drivers/net/mlx5/mlx5_flow.c | 16 1 file changed, 16 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c

[dpdk-dev] [PATCH 2/2] net/mlx5: fix missing shared RSS hash types

2021-03-25 Thread Xiaoyu Min
only one TIR will be created. Fixes: d2046c09aa64 ("net/mlx5: support shared action for RSS") Cc: sta...@dpdk.org Signed-off-by: Xiaoyu Min --- drivers/net/mlx5/mlx5_flow.h| 20 + drivers/net/mlx5/mlx5_flow_dv.c | 128 2 files changed, 148

[dpdk-dev] [PATCH 1/2] net/mlx5: fix shared inner RSS

2021-03-25 Thread Xiaoyu Min
ed RSS action there is only one set of TIRs - outer or inner could be so the unnecessary set of TIRs are removed in order to reduce resource. Fixes: d2046c09aa64 ("net/mlx5: support shared action for RSS") Cc: sta...@dpdk.org Signed-off-by: Xiaoyu Min --- drivers/net/mlx5/mlx5_flow.h

[dpdk-dev] [PATCH 0/2] fixs for shared RSS action

2021-03-25 Thread Xiaoyu Min
This series of patchs fix two problems of shared RSS action: 1. inner RSS (level > 1) doesn't work 2. missed RSS types support (i.e L3-src-only) Xiaoyu Min (2): net/mlx5: fix shared inner RSS net/mlx5: fix missing shared RSS hash types drivers/net/mlx5/mlx5_flow.h| 22 +++- dri

[dpdk-dev] [PATCH 5/5] net/softnic: update headers size calculation

2020-11-15 Thread Xiaoyu Min
From: Dekel Peled The rte_flow_item_eth and rte_flow_item_vlan items were updated in [1]. The rte_flow_item_ipv6 item was updated in [2]. The structs now contain additional metadata following the header data. The size to use for match should be the header data size only, and not the size of the w

[dpdk-dev] [PATCH 4/5] net/iavf: fix protocol size for virtchnl copy

2020-11-15 Thread Xiaoyu Min
From: Xiaoyu Min The rte_flow_item_vlan items are refined. The structs do not exactly represent the packet bits captured on the wire anymore so should only copy real header instead of the whole struct. Replace the rte_flow_item_* with the existing corresponding rte_*_hdr. Fixes: 09315fc83861

[dpdk-dev] [PATCH 2/5] app/flow-perf: fix protocol size for raw encap

2020-11-15 Thread Xiaoyu Min
From: Xiaoyu Min The rte_flow_item_eth and rte_flow_item_vlan items are refined. The structs do not exactly represent the packet bits captured on the wire anymore so add_*_header functions should use real header instead of the using rte_flow_item_* struct. Replace the rte_flow_item_* with the

[dpdk-dev] [PATCH 3/5] net/bnxt: fix protocol size for VXLAN encap copy

2020-11-15 Thread Xiaoyu Min
From: Xiaoyu Min The rte_flow_item_eth and rte_flow_item_vlan items are refined. The structs do not exactly represent the packet bits captured on the wire anymore so should only copy real header instead of the whole struct. Replace the rte_flow_item_* with the existing corresponding rte_*_hdr

[dpdk-dev] [PATCH 1/5] net/mlx5: fix protocol size for raw encap judgement

2020-11-15 Thread Xiaoyu Min
From: Xiaoyu Min The rte_flow_item_eth and rte_flow_item_vlan items are refined. The structs do not exactly represent the packet bits captured on the wire anymore. Should use real header instead of the whole struct. Replace the rte_flow_item_* with the existing corresponding rte_*_hdr. Fixes

[dpdk-dev] [PATCH 0/5] fix protocol size calculation

2020-11-15 Thread Xiaoyu Min
From: Xiaoyu Min The rte_flow_item_eth, rte_flow_item_vlan, and rte_flow_item_ipv6 are refined. The structs do not exactly represent the real protocol headers any more. This serial patchs try to fix all related parts due to the changes. Dekel Peled (1): net/softnic: update headers size

[dpdk-dev] [PATCH] net/mlx5: fix validate RSS queues types

2020-11-15 Thread Xiaoyu Min
From: Xiaoyu Min When the RSS queues' types are not uniformed, i.e, mixed with normal RX queue and hairpin queue, PMD accept this flow after commit[1] instead of reject it. This because commit[1] create RX queue object as DEVX type via DEVX API instead of IBV type via verbs, in which the l

[dpdk-dev] [PATCH] net/mlx5: fix validate MPLSoGRE with GRE key

2020-11-10 Thread Xiaoyu Min
From: Xiaoyu Min Currently PMD only accept flow which item_mpls directly follow item_gre, means to match the GRE header without GRE optional field key in MPLSoGRE encapsulation. However, for the MPLSoGRE, the GRE header could have the optional field (i.e, key) according to the RFC. So PMD need

[dpdk-dev] [PATCH] app/testpmd: set raw cmd use rte hdr struct

2020-11-03 Thread Xiaoyu Min
From: Xiaoyu Min The rte_flow_item_eth and rte_flow_item_vlan items are refined [1]. The structs do not exactly represent the packet bits captured on the wire anymore so set raw_encap/decap commands should only copy real header instead of the whole struct. Replace the rte_flow_item_* with the

Re: [dpdk-dev] [PATCH] net/mlx5: remove redundant newline

2020-06-17 Thread Xiaoyu Min
5: optimize tag traversal with hash list") > Fixes: 6801116688fe ("net/mlx5: fix multiple flow table hash list") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand Acked-by: Xiaoyu Min > --- > drivers/net/mlx5/mlx5.c | 6 +++--- > drivers/net/m

[dpdk-dev] [PATCH v3] app/testpmd: add cmdline option to set Rx mq mode

2020-05-06 Thread Xiaoyu Min
tested easily. Signed-off-by: Xiaoyu Min --- app/test-pmd/parameters.c | 15 +++ app/test-pmd/testpmd.c | 17 ++--- app/test-pmd/testpmd.h | 2 ++ doc/guides/rel_notes/release_20_05.rst | 4 doc/guides/testpmd_app_ug

Re: [dpdk-dev] [PATCH v2] app/testpmd: add cmdline option to set Rx mq mode

2020-05-06 Thread Xiaoyu Min
On Wed, 20-05-06, 10:36, Ferruh Yigit wrote: > On 5/6/2020 3:52 AM, Xiaoyu Min wrote: > > On Tue, 20-05-05, 17:06, Ferruh Yigit wrote: > >> On 4/30/2020 2:07 PM, Xiaoyu Min wrote: > >>> One new cmdline option `--rx-mq-mode` is added in order to have the > >

Re: [dpdk-dev] [PATCH v2] app/testpmd: add cmdline option to set Rx mq mode

2020-05-05 Thread Xiaoyu Min
On Tue, 20-05-05, 17:06, Ferruh Yigit wrote: > On 4/30/2020 2:07 PM, Xiaoyu Min wrote: > > One new cmdline option `--rx-mq-mode` is added in order to have the > > possibility to check whether PMD handle the mq mode correctly or not. > > > > The reason is some NICs ne

[dpdk-dev] [PATCH v2] app/testpmd: add cmdline option to set Rx mq mode

2020-04-30 Thread Xiaoyu Min
tested easily. Signed-off-by: Xiaoyu Min --- app/test-pmd/parameters.c | 12 app/test-pmd/testpmd.c | 17 ++--- app/test-pmd/testpmd.h | 3 +++ doc/guides/rel_notes/release_20_05.rst | 4 doc/guides/testpmd_app_ug

Re: [dpdk-dev] [PATCH] app/testpmd: add cmdline option to set Rx mq mode

2020-04-30 Thread Xiaoyu Min
On Thu, 20-04-30, 09:16, Iremonger, Bernard wrote: > Hi Xiaoyu, Hey Bernard, > > > -Original Message- > > From: Xiaoyu Min > > Sent: Wednesday, April 29, 2020 2:04 PM > > To: Lu, Wenzhuo ; Wu, Jingjing > > ; Iremonger, Bernard > > ; Mcnamara, Jo

Re: [dpdk-dev] [PATCH v4 5/5] app/test-flow-perf: add packet forwarding support

2020-04-30 Thread Xiaoyu Min
. > > The support has single and multi core performance measurements. > > Signed-off-by: Wisam Jaddo Acked-by: Xiaoyu Min

Re: [dpdk-dev] [PATCH v4 4/5] app/test-flow-perf: add memory dump to app

2020-04-30 Thread Xiaoyu Min
ion rate scenario alone" > > 2- Check that no memory leackage after doing insertion then > deletion. > > Signed-off-by: Suanming Mou > Signed-off-by: Wisam Jaddo Acked-by: Xiaoyu Min

Re: [dpdk-dev] [PATCH v4 3/5] app/test-flow-perf: add deletion rate calculation

2020-04-30 Thread Xiaoyu Min
On Thu, 20-04-30, 10:33, Wisam Jaddo wrote: > Add the ability to test deletion rate for flow performance > application. > > This feature is disabled by default, and can be enabled by > add "--deletion-rate" in the application command line options. > > Signed-off-by

Re: [dpdk-dev] [PATCH v4 2/5] app/test-flow-perf: add insertion rate calculation

2020-04-30 Thread Xiaoyu Min
rent flow each time, and all other items will > have open masks. > > The current design have single core insertion rate. > In the future we may have a multi core insertion > rate measurement support in the app. > > Signed-off-by: Wisam Jaddo Acked-by: Xiaoyu Min

Re: [dpdk-dev] [PATCH v4 1/5] app/test-flow-perf: add flow performance skeleton

2020-04-30 Thread Xiaoyu Min
On Thu, 20-04-30, 10:33, Wisam Jaddo wrote: > Add flow performance application skeleton. > > Signed-off-by: Wisam Jaddo Acked-by: Xiaoyu Min

[dpdk-dev] [PATCH] app/testpmd: add cmdline option to set Rx mq mode

2020-04-29 Thread Xiaoyu Min
tested easily. Signed-off-by: Xiaoyu Min --- app/test-pmd/parameters.c | 12 app/test-pmd/testpmd.c| 17 ++--- app/test-pmd/testpmd.h| 3 +++ doc/guides/testpmd_app_ug/run_app.rst | 7 +++ 4 files changed, 36 insertions

[dpdk-dev] [PATCH] net/mlx5: fix default rule do RSS regardless rxmode

2020-04-29 Thread Xiaoyu Min
with ETH_MQ_RX_RSS_FLAG set, then RSS is needed for default rules. Fixes: c64ccc0eca2f ("mlx5: fix overwritten RSS configuration") Cc: sta...@dpdk.org Signed-off-by: Xiaoyu Min --- drivers/net/mlx5/mlx5_flow.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.

Re: [dpdk-dev] [RFC] app/testpmd: add generic swap forwarding engine

2020-04-22 Thread Xiaoyu Min
On Wed, 20-04-22, 10:26, Kevin Traynor wrote: > On 15/04/2020 14:48, Xiaoyu Min wrote: > > This RFC propose a generic `swap` forwarding engine, which could be seen > > as an extension of existing `macswap` but provide more flexibility. > > > > With this generic `swap

Re: [dpdk-dev] [RFC] app/testpmd: add generic swap forwarding engine

2020-04-21 Thread Xiaoyu Min
On Tue, 20-04-21, 21:56, Ferruh Yigit wrote: > On 4/15/2020 2:48 PM, Xiaoyu Min wrote: > > This RFC propose a generic `swap` forwarding engine, which could be seen > > as an extension of existing `macswap` but provide more flexibility. > > > > With this generic `swap

Re: [dpdk-dev] [RFC] app/testpmd: add generic swap forwarding engine

2020-04-21 Thread Xiaoyu Min
On Tue, 20-04-21, 15:47, Iremonger, Bernard wrote: > Hi Xiaoyu, Hey Bernard, > > > -Original Message- > > From: Xiaoyu Min > > Sent: Wednesday, April 15, 2020 2:49 PM > > To: tho...@monjalon.net; as...@mellanox.com; Lu, Wenzhuo > > ; Wu, Jingjing

Re: [dpdk-dev] [PATCH 5/5] app/test-flow-perf: add packet forwarding support

2020-04-16 Thread Xiaoyu Min
. > > The support has single and multi performance measurements. > > Signed-off-by: Wisam Jaddo Reviewed-by: Xiaoyu Min

Re: [dpdk-dev] [PATCH 4/5] app/test-flow-perf: add memory dump to app

2020-04-16 Thread Xiaoyu Min
ion rate scenario alone" > > 2- Check that no memory leackage after doing insertion then > deletion. > > Signed-off-by: Suanming Mou > Signed-off-by: Wisam Jaddo Reviewed-by: Xiaoyu Min

Re: [dpdk-dev] [PATCH 3/5] app/test-flow-perf: add deletion rate calculation

2020-04-16 Thread Xiaoyu Min
ff-by: Wisam Jaddo Reviewed-by: Xiaoyu Min

Re: [dpdk-dev] [PATCH 2/5] app/test-flow-perf: add insertion rate calculation

2020-04-16 Thread Xiaoyu Min
rent flow each time, and all other items will > have open masks. > > The current design have single core insertion rate. > In the future we may have a multi core insertion > rate measurement support in the app. > > Signed-off-by: Wisam Jaddo Reviewed-by: Xiaoyu Min

Re: [dpdk-dev] [PATCH 1/5] app/test-flow-perf: add flow performance skeleton

2020-04-16 Thread Xiaoyu Min
bject: [dpdk-dev] [PATCH 1/5] app/test-flow-perf: add flow performance > >skeleton > > > >Add flow performance application skeleton. > > > >Signed-off-by: Wisam Jaddo Reviewed-by: Xiaoyu Min

[dpdk-dev] [RFC] app/testpmd: add generic swap forwarding engine

2020-04-15 Thread Xiaoyu Min
according to the user inputs. This will be very helpful for developer/tester in some test scenarios. For example, connection tracking functinality in OVS, which needs to swap UDP ports in addition to L2/L3 addresses in order to complete one connection. Signed-off-by: Xiaoyu Min --- app/test-pmd

[dpdk-dev] [PATCH v2] net/mlx5: fix validation of push VLAN without full mask

2020-04-12 Thread Xiaoyu Min
nsfer group 0 priority 3 pattern eth / vlan vid spec 2859 vid prefix 4 / ipv4 / end actcions of_push_vlan ethertype 0x88A8 / of_set_vlan_pcp vlan_pcp 6 / port_id id 0 / end Signed-off-by: Xiaoyu Min Reviewed-by: Dekel Peled Acked-by: Viacheslav Ovsi

[dpdk-dev] [PATCH v2] net/mlx5: fix push VLAN action wrongly use item info

2020-04-12 Thread Xiaoyu Min
fix set VLAN ID/PCP in new header") Cc: sta...@dpdk.org Signed-off-by: Xiaoyu Min Reviewed-by: Dekel Peled Acked-by: Viacheslav Ovsiienko --- v2: - rebased - added Acked-by tag drivers/net/mlx5/mlx5_flow_dv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/dri

[dpdk-dev] [PATCH] net/mlx5: fix validation of push VLAN without full mask

2020-04-02 Thread Xiaoyu Min
nsfer group 0 priority 3 pattern eth / vlan vid spec 2859 vid prefix 4 / ipv4 / end actcions of_push_vlan ethertype 0x88A8 / of_set_vlan_pcp vlan_pcp 6 / port_id id 0 / end Signed-off-by: Xiaoyu Min Reviewed-by: Dekel Peled --- drivers/net/mlx5/mlx5_f

[dpdk-dev] [PATCH] net/mlx5: fix push VLAN action wrongly use item info

2020-04-02 Thread Xiaoyu Min
fix set VLAN ID/PCP in new header") Cc: sta...@dpdk.org Signed-off-by: Xiaoyu Min Reviewed-by: Dekel Peled --- drivers/net/mlx5/mlx5_flow_dv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c ind

[dpdk-dev] [PATCH] doc: update testpmd guide for flow dump command

2020-01-19 Thread Xiaoyu Min
Explanation of flow dump command is added into testpmd functions. Signed-off-by: Xiaoyu Min --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 20 1 file changed, 20 insertions(+) diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug

[dpdk-dev] [PATCH v2 5/5] doc: update mlx5 document for flow dump feature

2020-01-17 Thread Xiaoyu Min
From: Xueming Li Guide of mlx5 is updated on how to dump HW flows. Signed-off-by: Xueming Li Signed-off-by: Xiaoyu Min --- doc/guides/nics/mlx5.rst | 28 1 file changed, 28 insertions(+) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index

[dpdk-dev] [PATCH v2 4/5] net/mlx5: add socket server for external tools

2020-01-17 Thread Xiaoyu Min
From: Xueming Li Add pmd unix socket server to enable external tool applications to trigger flow dump. Socket path: /var/tmp/dpdk_mlx5_ Socket format: io_raw: port_id of uint16 file: file descriptor of int Signed-off-by: Xueming Li Signed-off-by: Xiaoyu Min Acked-by

[dpdk-dev] [PATCH v2 3/5] app/testpmd: new flow dump CLI

2020-01-17 Thread Xiaoyu Min
From: Xueming Li New flow dump CLI to dump device internal representation information of flows into screen. Signed-off-by: Xueming Li Signed-off-by: Xiaoyu Min Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 91 + app/test-pmd/config.c | 27

[dpdk-dev] [PATCH v2 2/5] net/mlx5: support flow dump API

2020-01-17 Thread Xiaoyu Min
Dump fdb/nic_rx/nic_tx raw flow data into specified file. Signed-off-by: Xueming Li Signed-off-by: Xiaoyu Min Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/Makefile | 7 ++- drivers/net/mlx5/meson.build | 4 +++- drivers/net/mlx5/mlx5.h | 4 drivers

[dpdk-dev] [PATCH v2 1/5] ethdev: add API to dump device internal flow info

2020-01-17 Thread Xiaoyu Min
Introduce an API which dump the device's internal representation information of rte flows in hardware. Signed-off-by: Xiaoyu Min Acked-by: Ori Kam --- lib/librte_ethdev/rte_ethdev_version.map | 3 +++ lib/librte_ethdev/rte_flow.c | 16 lib/librte_ethdev/rte_f

[dpdk-dev] [PATCH v2 0/5] ethdev: add API to dump device internal flow info

2020-01-17 Thread Xiaoyu Min
improvement per review comments Xiaoyu Min (2): ethdev: add API to dump device internal flow info net/mlx5: support flow dump API Xueming Li (3): app/testpmd: new flow dump CLI net/mlx5: add socket server for external tools doc: update mlx5 document for flow dump feature app/test-pmd

[dpdk-dev] [PATCH 4/5] net/mlx5: add socket server for external tools

2020-01-16 Thread Xiaoyu Min
From: Xueming Li Add pmd unix socket server to enable external tool applications to trigger flow dump. Socket path: /var/tmp/dpdk_mlx5_ Socket format: io_raw: port_id of uint16 file: file descriptor of int Signed-off-by: Xueming Li Signed-off-by: Xiaoyu Min

[dpdk-dev] [PATCH 5/5] doc: update mlx5 document for flow dump feature

2020-01-16 Thread Xiaoyu Min
From: Xueming Li Guide of mlx5 is updated on how to dump HW flows. Signed-off-by: Xueming Li Signed-off-by: Xiaoyu Min --- doc/guides/nics/mlx5.rst | 28 1 file changed, 28 insertions(+) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index

[dpdk-dev] [PATCH 1/5] ethdev: add API to dump device internal flow info

2020-01-16 Thread Xiaoyu Min
Introduce an API which dump the device's internal representation information of rte flows in hardware. Signed-off-by: Xiaoyu Min --- lib/librte_ethdev/rte_ethdev_version.map | 3 +++ lib/librte_ethdev/rte_flow.c | 16 lib/librte_ethdev/rte_flow.h

[dpdk-dev] [PATCH 3/5] app/testpmd: new flow dump CLI

2020-01-16 Thread Xiaoyu Min
From: Xueming Li New flow dump CLI to dump device internal representation information of flows into screen. Signed-off-by: Xueming Li Signed-off-by: Xiaoyu Min --- app/test-pmd/cmdline_flow.c | 91 + app/test-pmd/config.c | 27 +++ app/test

[dpdk-dev] [PATCH 2/5] net/mlx5: support flow dump API

2020-01-16 Thread Xiaoyu Min
Dump fdb/nic_rx/nic_tx raw flow data into specified file. Signed-off-by: Xueming Li Signed-off-by: Xiaoyu Min --- drivers/net/mlx5/Makefile | 7 ++- drivers/net/mlx5/meson.build | 2 ++ drivers/net/mlx5/mlx5.h | 4 drivers/net/mlx5/mlx5_devx_cmds.c | 35

[dpdk-dev] [PATCH 0/5] ethdev: add API to dump device internal flow info

2020-01-16 Thread Xiaoyu Min
in a correct way from HW perspective. The output file is in vendor specific format. An external vendor provided tool may be needed in order to get human readable info. [1]: https://patches.dpdk.org/cover/64597/ Xiaoyu Min (2): ethdev: add API to dump device internal flow info net/mlx5: support

[dpdk-dev] [RFC 0/4] net/mlx5: dump software steering flows in HW

2020-01-13 Thread Xiaoyu Min
This RFC intends to provide a way to dump all the offloaded rte flows in HW. This is very helpful for user and developer to debug flow offloading stuff, i.e, to check whether PMD offloads the rte flow in a correct way from HW perspective. A private PMD API is provided as well as a socket server fo

[dpdk-dev] [RFC 4/4] doc: update mlx5 document for flow dump feature

2020-01-13 Thread Xiaoyu Min
From: Xueming Li Guide of mlx5 is updated on how to dump HW flows. Signed-off-by: Xueming Li Signed-off-by: Xiaoyu Min --- doc/guides/nics/mlx5.rst | 28 1 file changed, 28 insertions(+) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index

[dpdk-dev] [RFC 2/4] app/testpmd: new flow dump CLI

2020-01-13 Thread Xiaoyu Min
From: Xueming Li New flow dump CLI to dump MLX5 PMD specific flows into screen. Signed-off-by: Xueming Li Signed-off-by: Xiaoyu Min --- app/test-pmd/Makefile | 4 ++ app/test-pmd/cmdline_flow.c | 91 + app/test-pmd/config.c | 33

[dpdk-dev] [RFC 3/4] net/mlx5: add socket server for external tools

2020-01-13 Thread Xiaoyu Min
From: Xueming Li Add pmd unix socket server to enable external tool applications to trigger flow dump. Socket path: /var/tmp/dpdk_mlx5_ Socket format: io_raw: port_id of uint16 file: file descriptor of int Signed-off-by: Xueming Li Signed-off-by: Xiaoyu Min

[dpdk-dev] [RFC 1/4] net/mlx5: support flow dump Api

2020-01-13 Thread Xiaoyu Min
From: Xueming Li Dump fdb/nic_rx/nic_tx raw flow data into specified file. Signed-off-by: Xueming Li Signed-off-by: Xiaoyu Min --- drivers/net/mlx5/Makefile | 11 ++- drivers/net/mlx5/meson.build | 4 +++ drivers/net/mlx5/mlx5.h | 2

[dpdk-dev] [PATCH] net/mlx5: fix multiple flow table hash list

2019-12-16 Thread Xiaoyu Min
pointer point to (sh->flow_tbls) is overwritten by the later created hast list. To fix this, just don't create hash list if it is already created. Fixes: 54534725d2f3 ("net/mlx5: fix flow table hash list conversion") Cc: sta...@dpdk.org Reported-by: Zhike Wang Signed-

[dpdk-dev] [PATCH] net/mlx5: fix layer bits not unique

2019-11-13 Thread Xiaoyu Min
The layer bits should be unique otherwise layer info will be interpreted wrongly. Fixes: 70d84dc797b7 ("net/mlx5: add internal tag item and action") Cc: or...@mellanox.com Fixes: 55deee1715f0 ("net/mlx5: extend flow mark support") Cc: viachesl...@mellanox.com Signe

[dpdk-dev] [PATCH v2] ethdev: fix expand RSS flows

2019-11-05 Thread Xiaoyu Min
nd to expand RSS flows correctly. Currently only support to complete item list based on ether type or ip next proto. Fixes: 4ed05fcd441b ("ethdev: add flow API to expand RSS flows") Cc: sta...@dpdk.org Signed-off-by: Xiaoyu Min --- v2: * more clear commit message --- lib/librte_et

[dpdk-dev] [PATCH] ethdev: expand RSS flows based on last item spec

2019-11-05 Thread Xiaoyu Min
patch will fix above by checking the last item's spec and try to complete the item list. Currently only support to complete item list based on L2/L3 layer. Fixes: 4ed05fcd441b ("ethdev: add flow API to expand RSS flows") Cc: sta...@dpdk.org Signed-off-by: Xiaoyu Min --- lib/libr

[dpdk-dev] [PATCH] net/mlx5: allow pattern start from IP

2019-11-05 Thread Xiaoyu Min
Some applications, i.e. OVS, have rule like: [1] pattern ipv4 / end actions ... which intends to match ipv4 only on non-vlan ethernet and MLX5 NIC supports this. So PMD should accept this. Fixes: 906a2efae8da ("net/mlx5: validate flow rule item order") Signed-off-by: Xiaoyu Min --

[dpdk-dev] [PATCH] net/mlx5: improve flow item IP validation

2019-11-04 Thread Xiaoyu Min
ed as failure and report corresponding error in detail. Fixes: 23c1d42c7138 ("net/mlx5: split flow validation to dedicated function") Cc: sta...@dpdk.org Signed-off-by: Xiaoyu Min Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow.c | 22 + drivers/net/m

[dpdk-dev] [PATCH v2] net/mlx5: port id action must be after VLAN actions

2019-11-04 Thread Xiaoyu Min
AN ID on existing VLAN header") Cc: mo...@mellanox.com Signed-off-by: Xiaoyu Min Acked-by: Matan Azrad --- v2: * rebased drivers/net/mlx5/mlx5_flow_dv.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_

[dpdk-dev] [PATCH] net/mlx5: fix set VLAN id/pcp in new VLAN header

2019-10-31 Thread Xiaoyu Min
eader") Fixes: 68fad3635042 ("net/mlx5: support modifying VLAN priority on VLAN header") Cc: mo...@mellanox.com Signed-off-by: Xiaoyu Min --- drivers/net/mlx5/mlx5_flow_dv.c | 122 1 file changed, 77 insertions(+), 45 deletions(-) diff --gi

[dpdk-dev] [PATCH] app/testpmd: fix IP next proto in set raw decap/encap

2019-10-31 Thread Xiaoyu Min
ld be leave it as-is if there is no upper layer or value is already set. Fixes: 30626def03d6 ("app/testpmd: support raw encap/decap actions") Cc: sta...@dpdk.org Signed-off-by: Xiaoyu Min --- app/test-pmd/cmdline_flow.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff -

[dpdk-dev] [PATCH] net/mlx5: port id action must be after VLAN actions

2019-10-30 Thread Xiaoyu Min
AN ID on existing VLAN header") Cc: mo...@mellanox.com Signed-off-by: Xiaoyu Min --- drivers/net/mlx5/mlx5_flow_dv.c | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index

[dpdk-dev] [PATCH] net/mlx5: fix segfault when create hash rxq of drop

2019-10-17 Thread Xiaoyu Min
ich is missing previously. Fixes: 78be885295b8 ("net/mlx5: handle drop queues as regular queues") Cc: sta...@dpdk.org Reported-by: Zengmo Gao Signed-off-by: Xiaoyu Min --- drivers/net/mlx5/mlx5_rxq.c | 38 +++-- 1 file changed, 24 insertions(+), 14 de

[dpdk-dev] [PATCH] app/testpmd: support multiple raw encap/decap

2019-09-16 Thread Xiaoyu Min
and to what. Signed-off-by: Xiaoyu Min --- app/test-pmd/cmdline.c | 2 + app/test-pmd/cmdline_flow.c | 310 ++-- app/test-pmd/testpmd.h | 2 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 57 +++- 4 files changed, 331

[dpdk-dev] [PATCH v2] net/mlx5: improve validation of item order

2019-09-11 Thread Xiaoyu Min
uld directly follow the tunnel layer without L2 layer. Meanwhile inner L2 layer should check whether there is inner L3 layer before it. Fixes: 23c1d42c7138 ("net/mlx5: split flow validation to dedicated function") Cc: sta...@dpdk.org Signed-off-by: Xiaoyu Min --- drivers/net/mlx5/mlx

[dpdk-dev] [PATCH] net/mlx5: improve validation of item order

2019-09-10 Thread Xiaoyu Min
uld directly follow the tunnel layer without L2 layer. Meanwhile inner L2 layer should check whether there is inner L3 layer before it. Signed-off-by: Xiaoyu Min --- drivers/net/mlx5/mlx5_flow.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.

[dpdk-dev] [RFC] app/testpmd: support multiple raw encap/decap

2019-08-31 Thread Xiaoyu Min
/ ... If there is no `index` specified, the default index is 0. Signed-off-by: Xiaoyu Min --- app/test-pmd/cmdline_flow.c | 198 +++- 1 file changed, 171 insertions(+), 27 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index

[dpdk-dev] [PATCH] net/mlx5: raw encap data cannot be empty

2019-08-20 Thread Xiaoyu Min
Signed-off-by: Xiaoyu Min --- drivers/net/mlx5/mlx5_flow_dv.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index 21faa98ec3..41500bc109 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c

[dpdk-dev] [PATCH] net/mlx5: fix missing ptype for IP-in-IP

2019-08-08 Thread Xiaoyu Min
The hw ptype information is missed for IP-in-IP tunnel. It should be RTE_PTYPE_TUNNEL_IP ptype. Fixes: 5e33bebdd8d3 ("net/mlx5: support IP-in-IP tunnel") Signed-off-by: Xiaoyu Min --- drivers/net/mlx5/mlx5_flow.c | 8 drivers/net/mlx5/mlx5_rxtx.h | 2 +- 2 files changed, 9

[dpdk-dev] [PATCH] net/mlx5: fix link speed info when link is down

2019-08-05 Thread Xiaoyu Min
, which is not right. Fixes: 188408719888 ("net/mlx5: fix support for newer link speeds") Cc: sta...@dpdk.org Signed-off-by: Xiaoyu Min --- drivers/net/mlx5/mlx5_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/driver

[dpdk-dev] [PATCH] net/mlx5: fix VLAN inner type matching on DR/DV

2019-08-02 Thread Xiaoyu Min
end - matching all ipv4 traffic in vlan with id 2: testpmd> flow create 0 ingress pattern eth / vlan vid is 2 inner_type is 0x0800 / end actions queue index 2 / end Fixes: fc2c498ccb94 ("net/mlx5: add Direct Verbs translate items") Cc: or...@mellanox.com Signed-off-by: Xiaoyu M

[dpdk-dev] [PATCH] net/mlx5: fix RSS expand for IP-in-IP

2019-07-24 Thread Xiaoyu Min
proto is 4 / ipv4 / Fixes: 5e33bebdd8d3 ("net/mlx5: support IP-in-IP tunnel") Cc: jack...@mellanox.com Signed-off-by: Xiaoyu Min --- drivers/net/mlx5/mlx5_flow.c| 8 +++- drivers/net/mlx5/mlx5_flow_dv.c | 79 - 2 files changed, 53 insertions(+

[dpdk-dev] [PATCH v4 2/4] app/testpmd: support raw encap/decap actions

2019-07-17 Thread Xiaoyu Min
1] http://mails.dpdk.org/archives/dev/2018-October/116092.html Signed-off-by: Xiaoyu Min --- app/test-pmd/cmdline.c | 7 + app/test-pmd/cmdline_flow.c | 535 +++- app/test-pmd/testpmd.h | 2 + doc/guides/testpmd_app_ug/testp

[dpdk-dev] [PATCH v4 4/4] app/testpmd: add GRE key for raw encap/decap

2019-07-17 Thread Xiaoyu Min
GRE key (rte_flow_item_type_gre_key) is also needed in raw encapsulation/decapsulation. Signed-off-by: Xiaoyu Min --- app/test-pmd/cmdline_flow.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 8409e41ea0..d08f016bec

[dpdk-dev] [PATCH v4 3/4] app/testpmd: support MPLS's TC and S bits

2019-07-17 Thread Xiaoyu Min
Open the MPLS's TC and S bits of rte_flow_item_mpls in command line. Signed-off-by: Xiaoyu Min --- app/test-pmd/cmdline_flow.c | 20 1 file changed, 20 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index a15a756461..8409e41ea0 1

[dpdk-dev] [PATCH v4 0/4] app/testpmd: support raw encap/decap actions

2019-07-17 Thread Xiaoyu Min
rect data. [1] https://patches.dpdk.org/patch/53456/ --- v2: * add gre key support v3: * removed help string from help filters * rebased on 19.08-rc1 v4: * move help string of set vxlan/nvgre/raw_encap/raw_decap into filters section --- Xiaoyu Min (4): app/testpmd: put set vxlan/nvgre h

[dpdk-dev] [PATCH v4 1/4] app/testpmd: put set vxlan/nvgre help in filters section

2019-07-17 Thread Xiaoyu Min
The help string of set vxlan*, set nvgre* are in "config"" section. But they acutally do not alter NIC or testpmd's configuration and they will be used by "flow" command later. Put them in "filters" section along with "flow" command seems more rea

[dpdk-dev] [PATCH v4] net/mlx5: support IP-in-IP tunnel

2019-07-10 Thread Xiaoyu Min
ets and do inner RSS: testpmd> flow create 0 ingress pattern eth / ipv4 proto is 0x29 / ipv6 / udp / end actions rss level 2 queues 0 1 2 3 end / end Signed-off-by: Xiaoyu Min Acked-by: Viacheslav Ovsiienko --- v2: * updated release note v3: * rebased on 19.08-rc1 v4:

[dpdk-dev] [PATCH v3 3/3] app/testpmd: add GRE key for raw encap/decap

2019-07-10 Thread Xiaoyu Min
GRE key (rte_flow_item_type_gre_key) is also needed in raw encapsulation/decapsulation. Signed-off-by: Xiaoyu Min --- app/test-pmd/cmdline_flow.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index f48b202e58..43ae42146f

  1   2   >