Re: [PATCH] build: fix invalid characters in toolchain definitions

2023-02-08 Thread Wiles, Keith
From: Richardson, Bruce Sent: Tuesday, February 7, 2023 9:22 AM To: dev@dpdk.org Cc: Richardson, Bruce; sta...@dpdk.org; Wiles, Keith Subject: [PATCH] build: fix invalid characters in toolchain definitions When using "icx" (Intel(R) oneA

Re: [PATCH] telemetry: rework code to avoid compiler warnings

2023-02-08 Thread Wiles, Keith
From: Bruce Richardson Sent: Wednesday, February 8, 2023 8:37 AM To: dev@dpdk.org Cc: Huisong Li; Chengwen Feng; Morten Brørup; Richardson, Bruce Subject: [PATCH] telemetry: rework code to avoid compiler warnings When printing values as hex strings, the telemetry code temporarily disabled warning

[PATCH] tap:remove maintainer

2021-12-02 Thread Wiles, Keith
I no longer have the bandwidth to support the TAP PMD, so I am removing myself as the maintainer so as to not hold up commits. Signed-off-by: Wiles, Keith --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 18d9edaf88..b43285b6ab

[PATCH] tap:remove maintainer

2021-12-02 Thread Wiles, Keith
I no longer have the bandwidth to support the TAP PMD, so I am removing myself as the maintainer so as to not hold up commits. Signed-off-by: Keith Wiles --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 18d9edaf88..b43285b6ab 100

Re: [dpdk-dev] [PATCH 0/2] net/tap: remove useless offload setup

2021-07-02 Thread Wiles, Keith
> On Jun 15, 2021, at 11:15 PM, Stephen Hemminger > wrote: > > This looks like some infrastructure that was set for some future > change that never happened. Remove it. > > Stephen Hemminger (2): > tap: remove useless offload capa functions > tap: replace offload_capa function with define

Re: [dpdk-dev] [PATCH 1/2] net/tap: remove useless offload capa functions

2021-07-01 Thread Wiles, Keith
> On Jul 1, 2021, at 12:18 PM, Stephen Hemminger > wrote: > > On Thu, 1 Jul 2021 17:16:21 +0300 > Andrew Rybchenko wrote: > >> On 6/16/21 7:15 AM, Stephen Hemminger wrote: >>> Since these always return 0, they were doing nothing useful. >>> >>> Signed-off-by: Stephen Hemminger >> >> I h

Re: [dpdk-dev] [PATCH] Add build option to enable/disable AVX2 support

2020-10-29 Thread Wiles, Keith
From: Felix Moessbauer Date: Monday, October 26, 2020 at 9:31 AM To: Wiles, Keith Cc: dev@dpdk.org , henning.sch...@siemens.com , Felix Moessbauer Subject: [PATCH] Add build option to enable/disable AVX2 support This patch introduces a meson option to disable the AVX2 support. If the build

Re: [dpdk-dev] [RFC] replace master/slave with primary/secondary

2020-06-05 Thread Wiles, Keith
> On Jun 5, 2020, at 2:53 PM, Stephen Hemminger > wrote: > > On Fri, 5 Jun 2020 19:23:52 +0000 > "Wiles, Keith" wrote: > >>> On Jun 5, 2020, at 12:45 PM, Stephen Hemminger >>> wrote: >>> >>> On Fri, 5 Jun 2020 17:10:05 +0

Re: [dpdk-dev] [RFC] replace master/slave with primary/secondary

2020-06-05 Thread Wiles, Keith
> On Jun 5, 2020, at 12:45 PM, Stephen Hemminger > wrote: > > On Fri, 5 Jun 2020 17:10:05 +0000 > "Wiles, Keith" wrote: > >>>>> >>>>> I'd propose instead leader lcore - there is this idea that the leader >&

Re: [dpdk-dev] [RFC] replace master/slave with primary/secondary

2020-06-05 Thread Wiles, Keith
> On Jun 5, 2020, at 11:33 AM, Stephen Hemminger > wrote: > > On Fri, 5 Jun 2020 11:14:50 + > "Ananyev, Konstantin" wrote: > >>> organization is a little specific, with an lcore that does most init work >>> and spawns the others, but then runs the application like all others. >>> >>> I

Re: [dpdk-dev] [dpdk-techboard] Consider improving the DPDK contribution processes

2020-05-26 Thread Wiles, Keith
> On May 26, 2020, at 4:33 AM, Burakov, Anatoly > wrote: > > On 25-May-20 8:26 PM, Tom Barbette wrote: >> Le 25/05/2020 à 19:50, Wiles, Keith a écrit : >>> >>>> On May 25, 2020, at 12:32 PM, Thomas Monjalon wrote: >>>> >>>> 25/

Re: [dpdk-dev] [dpdk-techboard] Consider improving the DPDK contribution processes

2020-05-26 Thread Wiles, Keith
> On May 25, 2020, at 2:26 PM, Tom Barbette wrote: > > > Le 25/05/2020 à 19:50, Wiles, Keith a écrit : >> >>> On May 25, 2020, at 12:32 PM, Thomas Monjalon wrote: >>> >>> 25/05/2020 18:57, Wiles, Keith: >>>> On May 25, 2020, at

Re: [dpdk-dev] [dpdk-techboard] Consider improving the DPDK contribution processes

2020-05-25 Thread Wiles, Keith
> On May 25, 2020, at 12:32 PM, Thomas Monjalon wrote: > > 25/05/2020 18:57, Wiles, Keith: >> On May 25, 2020, at 11:28 AM, Thomas Monjalon wrote: >>> 25/05/2020 18:09, Burakov, Anatoly: >>>> On 25-May-20 5:04 PM, Maxime Coquelin wrote: >>>

Re: [dpdk-dev] [dpdk-techboard] Consider improving the DPDK contribution processes

2020-05-25 Thread Wiles, Keith
> On May 25, 2020, at 11:28 AM, Thomas Monjalon wrote: > > 25/05/2020 18:09, Burakov, Anatoly: >> On 25-May-20 5:04 PM, Maxime Coquelin wrote: >>> On 5/25/20 5:59 PM, Burakov, Anatoly wrote: On 25-May-20 4:52 PM, Maxime Coquelin wrote: > On 5/25/20 5:35 PM, Jerin Jacob wrote: >> O

Re: [dpdk-dev] Consider improving the DPDK contribution processes

2020-05-25 Thread Wiles, Keith
> On May 25, 2020, at 9:28 AM, Burakov, Anatoly > wrote: > > On 25-May-20 1:53 PM, Thomas Monjalon wrote: >> 25/05/2020 13:58, Jerin Jacob: >>> 25/05/2020 11:34, Morten Brørup: sending patches over an email as opposed to a well-integrated web interface workflow is so alien to mo

Re: [dpdk-dev] Consider improving the DPDK contribution processes

2020-05-25 Thread Wiles, Keith
> On May 25, 2020, at 7:53 AM, Thomas Monjalon wrote: > > 25/05/2020 13:58, Jerin Jacob: >> 25/05/2020 11:34, Morten Brørup: >>> sending patches over an >>> email as opposed to a well-integrated web interface workflow is so alien >>> to most people that it definitely does discourage new contrib

Re: [dpdk-dev] Using pktgen-dpdk with Lua

2020-05-06 Thread Wiles, Keith
> On May 6, 2020, at 10:14 AM, Tiffany Kalin wrote: > > Hello, > > I'm wanting to use Lua scripts with pktgen-dpdk, but when I run pktgen-dpdk > it can't find the Pktgen.lua or Pktgen.so even with the test scripts. How > do I setup my system so that I can use the Pktgen Lua module? Is there a

Re: [dpdk-dev] [PATCH v5 00/18] update and simplify telemetry library.

2020-05-01 Thread Wiles, Keith
> On Apr 30, 2020, at 11:01 AM, Power, Ciara wrote: > > v5: > - General cleanup to address comments on v4 patchset. > > v4: > - Internal representation now uses generic data format instead of JSON. > - Help command added to provide help text for a command. > > v3: > - Removed rte_option

Re: [dpdk-dev] [PATCH 0/2] net/tap: simplfication and servicabilty improvements

2020-04-25 Thread Wiles, Keith
> On Apr 24, 2020, at 6:36 PM, Stephen Hemminger > wrote: > > These are a couple of small fixes to the TAP driver. The first makes it > more robust to random signals, and the second one adds better error > reporting. > > Stephen Hemminger (2): > net/tap: simplify netlink send/receive functi

Re: [dpdk-dev] [PATCH v4 00/18] update and simplify telemetry library.

2020-04-24 Thread Wiles, Keith
> On Apr 24, 2020, at 7:41 AM, Power, Ciara wrote: > > v4: > - Internal representation now uses generic data format instead of JSON. > - Help command added to provide help text for a command. > > v3: > - Removed rte_option as it is no longer used. > - General cleanup. > > v2: > - Added

Re: [dpdk-dev] [PATCH v4 13/18] telemetry: introduce telemetry backward compatibility

2020-04-24 Thread Wiles, Keith
> On Apr 24, 2020, at 7:41 AM, Power, Ciara wrote: > > The new telemetry will now open a socket using the old telemetry path, > to ensure backward compatibility. This is not yet initialised, as it > would clash with the existing telemetry, to be removed in a later patch. > This means that both

Re: [dpdk-dev] [PATCH v4 06/18] telemetry: introduce new telemetry functionality

2020-04-24 Thread Wiles, Keith
> On Apr 24, 2020, at 7:41 AM, Power, Ciara wrote: > > From: Bruce Richardson > > This patch introduces a new telemetry connection socket and handling > functionality. Like the existing telemetry implementation (which is > unaffected by this change) it uses a unix socket, but unlike the > ex

Re: [dpdk-dev] time for compiling test_ring.c

2020-04-22 Thread Wiles, Keith
> On Apr 22, 2020, at 3:12 AM, Thomas Monjalon wrote: > > 22/04/2020 07:11, Honnappa Nagarahalli: 22/04/2020 02:05, Honnappa Nagarahalli: > 22/04/2020 02:00, Thomas Monjalon: >> I don't want know why and when, but it seems the file test_ring.c >> became very long to compile, e

Re: [dpdk-dev] Need information on benchmark testing using pktgen

2020-04-13 Thread Wiles, Keith
> On Apr 13, 2020, at 3:55 AM, abhijit naik wrote: > > Hi All, > > I am planning to use the pktgen for benchmarking one of the Ethernet > IP. I needed some clarification w.r.t pktgen > Whether throughput, loss and latency can be measured by point to point > connection between test system and

Re: [dpdk-dev] [PATCH v2 00/16] update and simplify telemetry library.

2020-04-10 Thread Wiles, Keith
> On Apr 10, 2020, at 9:51 AM, Thomas Monjalon wrote: > > 10/04/2020 16:39, Wiles, Keith: >>> On Apr 9, 2020, at 4:37 AM, Thomas Monjalon wrote: >>> 09/04/2020 11:19, Bruce Richardson: >>>> On Wed, Apr 08, 2020 at 08:03:26PM +0200, Thomas Monjalon wro

Re: [dpdk-dev] [PATCH v2 00/16] update and simplify telemetry library.

2020-04-10 Thread Wiles, Keith
> On Apr 9, 2020, at 4:37 AM, Thomas Monjalon wrote: > > 09/04/2020 11:19, Bruce Richardson: >> On Wed, Apr 08, 2020 at 08:03:26PM +0200, Thomas Monjalon wrote: >>> 08/04/2020 18:49, Ciara Power: This patchset extensively reworks the telemetry library adding new functionality and sim

Re: [dpdk-dev] [PATCH v2 00/16] update and simplify telemetry library.

2020-04-10 Thread Wiles, Keith
> On Apr 10, 2020, at 5:49 AM, Morten Brørup wrote: > >> From: Ciara Power [mailto:ciara.po...@intel.com] >> Sent: Wednesday, April 8, 2020 6:50 PM >> >> This patchset extensively reworks the telemetry library adding new >> functionality and simplifying much of the existing code, while >> main

Re: [dpdk-dev] [PATCH v2 08/16] ethdev: add callback support for telemetry

2020-04-08 Thread Wiles, Keith
> On Apr 8, 2020, at 11:49 AM, Power, Ciara wrote: > > From: Bruce Richardson > > The ethdev library now registers commands with telemetry, and > implements the callback functions. These commands allow the list of > ethdev ports and the stats and link status for a port to be queried. > > Si

Re: [dpdk-dev] [PATCH v2 06/16] telemetry: add utility functions for creating json

2020-04-08 Thread Wiles, Keith
> On Apr 8, 2020, at 11:49 AM, Power, Ciara wrote: > > From: Bruce Richardson > > The functions added in this patch will make it easier for applications > to build up correct JSON responses to telemetry requests. > > Signed-off-by: Bruce Richardson > --- > lib/librte_telemetry/Makefile

Re: [dpdk-dev] [PATCH v2 05/16] telemetry: introduce new telemetry functionality

2020-04-08 Thread Wiles, Keith
> On Apr 8, 2020, at 11:49 AM, Power, Ciara wrote: > > From: Bruce Richardson > > This patch introduces a new telemetry connection socket and handling > functionality. Like the existing telemetry implementation (which is > unaffected by this change) it uses a unix socket, but unlike the > ex

Re: [dpdk-dev] [PATCH 00/12] update and simplify telemetry library.

2020-04-01 Thread Wiles, Keith
> On Mar 19, 2020, at 12:18 PM, Ciara Power wrote: > > This patchset extensively reworks the telemetry library adding new > functionality and simplifying much of the existing code, while > maintaining backward compatibility. > > This work is based on the previously sent RFC for a "process info

Re: [dpdk-dev] [PATCH v2] [pktgen] Fix IPv6 addressing for set/sequence/save commands, packet headers, UI printing

2019-12-02 Thread Wiles, Keith
ious allocations. To support jumbo frames I did need to increase the packet info structure to hold the largest frame. Please check to see if you can increase the amount of memory for socket 0 and socket 1 if you have two to see if that fixes the problem. I may have to rework this make jumbo frame suppor

Re: [dpdk-dev] [PATCH v2] [pktgen] Fix IPv6 addressing for set/sequence/save commands, packet headers, UI printing

2019-11-29 Thread Wiles, Keith
> On Nov 19, 2019, at 6:47 PM, Frank Li wrote: > > Current IPv6 functionality in pktgen is broken. This fix makes it so that > IPv6 addresses are properly set when using the set, sequence, and save > commands and that the IP header and UDP/TCP psuedo-header IPV6 addresses > are properly set. >

Re: [dpdk-dev] Jumbo Frame in pktgen & dpdk-pktgen

2019-11-29 Thread Wiles, Keith
> On Nov 19, 2019, at 11:42 AM, Roberts, Lee A. wrote: > > Nirmal, > > Here are the changes that I've been using to allow jumbo frames with > dpdk-19.08 and > pktgen-19.10.0: > > diff -r default/dpdk-19.08/lib/librte_mbuf/rte_mbuf.h > jumbo/dpdk-19.08/lib/librte_mbuf/rte_mbuf.h > 462c462 >

Re: [dpdk-dev] Jumbo Frame in pktgen & dpdk-pktgen

2019-11-27 Thread Wiles, Keith
needs to be changed to enable jumbo frames. The patch below seemed to work for Lee and I have not tried the patch changes. > > Regards, > N. Sarkar > > On Thu, Nov 21, 2019 at 12:24 AM Wiles, Keith wrote: > > > > On Nov 20, 2019, at 6:09 AM, Nirmal Sarkar wrote: >

Re: [dpdk-dev] [PATCH] pktgen: Fix IPv6 addressing for set/sequence/save commands, packet headers, UI printing

2019-11-25 Thread Wiles, Keith
> On Nov 25, 2019, at 3:46 PM, Frank Li wrote: > > Current IPv6 functionality in pktgen is broken. This fix makes it so that > IPv6 addresses are properly set when using the set, sequence, and save > commands and that the IP header and UDP/TCP psuedo-header IPV6 addresses > are properly set. >

Re: [dpdk-dev] Jumbo Frame in pktgen & dpdk-pktgen

2019-11-20 Thread Wiles, Keith
> On Nov 20, 2019, at 6:09 AM, Nirmal Sarkar wrote: > > Hello, > > Thanks for the help. > As I'm using DPDK-18.11.1, I did not find the definition of > "RTE_ETHER_MAX_LEN" in lib/librte_net/rte_ether.h file. > So I set "ETHER_MAX_LEN" value to 9600. > Apart from that I took rest of the changes

Re: [dpdk-dev] [PATCH] mbuf: support dynamic fields and flags

2019-09-23 Thread Wiles, Keith
> On Sep 23, 2019, at 11:16 AM, Olivier Matz wrote: > > Hi, > > (reformated the quotes) > > On Mon, Sep 23, 2019 at 03:14:51PM +, Wiles, Keith wrote: >> >> >> On Sep 23, 2019, at 4:13 AM, Olivier Matz >> mailto:olivier.m...@6wind.com>>

Re: [dpdk-dev] [PATCH] mbuf: support dynamic fields and flags

2019-09-23 Thread Wiles, Keith
Sorry, resend in plain text :-( > On Sep 23, 2019, at 4:13 AM, Olivier Matz wrote: > > Hi Keith, > > On Sat, Sep 21, 2019 at 08:28:32AM +0000, Wiles, Keith wrote: >> >> >>> On Sep 18, 2019, at 6:54 PM, Olivier Matz wrote: >>> >>> Many

Re: [dpdk-dev] [PATCH] mbuf: support dynamic fields and flags

2019-09-23 Thread Wiles, Keith
On Sep 23, 2019, at 4:13 AM, Olivier Matz mailto:olivier.m...@6wind.com>> wrote: Hi Keith, On Sat, Sep 21, 2019 at 08:28:32AM +, Wiles, Keith wrote: On Sep 18, 2019, at 6:54 PM, Olivier Matz mailto:olivier.m...@6wind.com>> wrote: Many features require to store data inside

Re: [dpdk-dev] [PATCH v2 1/1] net/tap: fix blocked rx packets error

2019-09-23 Thread Wiles, Keith
> On Sep 23, 2019, at 8:22 AM, Smoczynski, MarcinX > wrote: > > When OS sends more packets than are being read with a single > 'rte_eth_rx_burst' call, rx packets are getting stucked in the tap pmd > and are unable to receive, because trigger_seen is getting updated > and consecutive calls ar

Re: [dpdk-dev] [PATCH] mbuf: support dynamic fields and flags

2019-09-21 Thread Wiles, Keith
> On Sep 18, 2019, at 6:54 PM, Olivier Matz wrote: > > Many features require to store data inside the mbuf. As the room in mbuf > structure is limited, it is not possible to have a field for each > feature. Also, changing fields in the mbuf structure can break the API > or ABI. > > This commit

Re: [dpdk-dev] Questions about DPDK IOAT driver

2019-08-20 Thread Wiles, Keith
> On Aug 20, 2019, at 7:35 AM, cha...@m.scnu.edu.cn wrote: > > Hello DPDK, >I am a postgraduate student from South China Normal University, Guangzhou, > China. >I found that the IOAT driver was released in DPDK 19.08 for the first > time. At the same time, I noticed that the code of

Re: [dpdk-dev] [PATCH] remove unneeded eal header inclusion

2019-08-12 Thread Wiles, Keith
> On Aug 12, 2019, at 1:53 AM, David Marchand wrote: > > Restrict this header inclusion to its real users. > > Fixes: 028669bc9f0d ("eal: hide shared memory config") > > Signed-off-by: David Marchand The only thing I would suggest is to add the name of the header file in the subject or bo

Re: [dpdk-dev] [RFC 19.11 1/2] ethdev: make DPDK core functions non-inline

2019-07-30 Thread Wiles, Keith
> On Jul 30, 2019, at 10:54 AM, Stephen Hemminger > wrote: > > On Tue, 30 Jul 2019 16:33:55 +0100 > Bruce Richardson wrote: > >> On Tue, Jul 30, 2019 at 08:25:34AM -0700, Stephen Hemminger wrote: >>> On Tue, 30 Jul 2019 14:49:49 +0200 >>> Marcin Zapolski wrote: >>> Make rte_eth_rx_bu

Re: [dpdk-dev] [PATCH] net/tap: fix Rx miss the packets

2019-07-12 Thread Wiles, Keith
> On Jul 12, 2019, at 5:20 AM, donald_...@trendmicro.com wrote: > > From: Donald Lee > > > > After pmd_rx_burst be triggered, it doesn't retrieve all the frames. > > It may leave some pending frames there. > > > > Signed-off-by: Donald Lee > > --- > > drivers/net/tap/rte_eth_tap.c |

Re: [dpdk-dev] [PATCH 1/9] net/tap: remove redundant declarations

2019-07-11 Thread Wiles, Keith
> On Jul 11, 2019, at 3:03 PM, Stephen Hemminger > wrote: > > The rte_vdev_drivers are declared twice. > The first one is not necessary. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/tap/rte_eth_tap.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/tap/rte_e

Re: [dpdk-dev] [RFC] mbuf: support dynamic fields and flags

2019-07-11 Thread Wiles, Keith
> On Jul 11, 2019, at 2:53 AM, Olivier Matz wrote: > > Hi Keith, > > On Wed, Jul 10, 2019 at 06:12:16PM +0000, Wiles, Keith wrote: >> >> >>> On Jul 10, 2019, at 12:49 PM, Stephen Hemminger >>> wrote: >>> >>

Re: [dpdk-dev] [RFC] mbuf: support dynamic fields and flags

2019-07-10 Thread Wiles, Keith
> On Jul 10, 2019, at 12:49 PM, Stephen Hemminger > wrote: > > On Wed, 10 Jul 2019 11:29:07 +0200 > Olivier Matz wrote: > >> /** >> * Indicate that the metadata field in the mbuf is in use. >> @@ -738,6 +741,8 @@ struct rte_mbuf { >> */ >> struct rte_mbuf_ext_shared_info *shinfo

Re: [dpdk-dev] pktgen-dpdk send too big packet, and stop sending packets after few seconds

2019-06-24 Thread Wiles, Keith
|INFO|VHOST_CONFIG: vhost peer closed > 2019-06-24T09:11:13.781Z|00118|netdev_dpdk|INFO|vHost Device > '/usr/local/var/run/openvswitch/vhost-user2' has been removed > ##OVS error > log# > > Could you share some hints to me, thank you f

Re: [dpdk-dev] pktgen-dpdk send too big packet, and stop sending packets after few seconds

2019-06-23 Thread Wiles, Keith
> On Jun 23, 2019, at 3:00 AM, Xia Rui wrote: > > Hello, everyone. > I am using pktgen-dpdk and testpmd to test the functionality of ovs-dpdk. The > network topology is : > +-+--+ host(OVS-DPDK) > +---+-+ >

Re: [dpdk-dev] [PATCH] pktgen: fix clang compiler errors / warnings

2019-06-18 Thread Wiles, Keith
> On Jun 18, 2019, at 3:58 PM, Adam Drescher wrote: > > Clang complains about the following issues: > (1) unclear meaning of =- in assignment of pktgen.verbose > (2) unused function sct(), which is also defined in cli_cmds.c > (3) typo in include guard for rte_lua_vec.h > (4) duplicate inline

Re: [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag

2019-06-07 Thread Wiles, Keith
> On Jun 7, 2019, at 10:42 AM, Ray Kinsella wrote: > > > > On 06/06/2019 16:03, Neil Horman wrote: >> On Thu, Jun 06, 2019 at 02:02:03PM +, Jerin Jacob Kollanukkaran wrote: -Original Message- From: Neil Horman Sent: Thursday, June 6, 2019 7:05 PM To: Jerin Ja

Re: [dpdk-dev] [PATCH] pktgen: enable RSS on versions of DPDK after 18.05

2019-06-06 Thread Wiles, Keith
> On Jun 6, 2019, at 4:45 PM, David Christensen wrote: > > When backwards compatibility was added for earlier releases of DPDK, > default enablement of RSS was lost for versions of DPDK after 18.05. > This change restores the old behavior and enables RSS by default. > > Fixes: ae81c62f194c ("

Re: [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag

2019-06-06 Thread Wiles, Keith
> On Jun 6, 2019, at 8:43 AM, Neil Horman wrote: > > On Thu, Jun 06, 2019 at 01:18:29PM +0000, Wiles, Keith wrote: >> >> >>> On Jun 6, 2019, at 7:04 AM, Jerin Jacob Kollanukkaran >>> wrote: >>> >>>> -Original Message- &g

Re: [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag

2019-06-06 Thread Wiles, Keith
> On Jun 6, 2019, at 7:04 AM, Jerin Jacob Kollanukkaran > wrote: > >> -Original Message- >> From: Neil Horman >> Sent: Thursday, June 6, 2019 5:04 PM >> To: Jerin Jacob Kollanukkaran >> Cc: Bruce Richardson ; dev@dpdk.org; >> Thomas Monjalon >> Subject: Re: [EXT] [RFC PATCH 0/2] in

Re: [dpdk-dev] Pktgen Only Enables One RX Queue with Mellanox ConnectX-5

2019-06-05 Thread Wiles, Keith
> On Jun 5, 2019, at 5:08 PM, David Christensen wrote: > > Using a Mellanox ConnectX-5 @ 100Gb on a Supermicro system with DPDK 18.11.1 > and pktgen 3.6.6 from the Master branch (downloaded today). When I configure > pktgen to use multiple queues, I'm able to set the number of TX queues > c

Re: [dpdk-dev] [PATCH 2/5] net/tap: revert changes on rte_ prefixing

2019-05-29 Thread Wiles, Keith
> On May 29, 2019, at 6:29 AM, David Marchand wrote: > > This source is compiled as a bpf program out of dpdk. > Revert to structures/macros coming from libc. > > Fixes: 6d13ea8e8e49 ("net: add rte prefix to ether structures") > Fixes: 24ac604ef746 ("net: add rte prefix to IP defines") > > S

Re: [dpdk-dev] [PATCH v2] net/tap: fix potential buffer overrun

2019-04-29 Thread Wiles, Keith
> On Apr 25, 2019, at 10:17 AM, Lipiec, Herakliusz > wrote: > > When secondary to primary process synchronization occours > there is no check for number of fds which could cause buffer overrun. > > Bugzilla ID: 252 > Fixes: c9aa56edec8e ("net/tap: access primary process queues from secondary

Re: [dpdk-dev] Editor Config

2019-04-26 Thread Wiles, Keith
> On Apr 26, 2019, at 3:13 AM, Burakov, Anatoly > wrote: > > On 25-Apr-19 6:19 PM, Stephen Hemminger wrote: >> Systemd uses this and it looks like a useful addition to the DPDK source >> base. Especially since we now have Windows developers. >> https://editorconfig.org/ > > I have suggested

Re: [dpdk-dev] [PATCH v3 1/3] rte_ethdev: Add API function to read dev clock

2019-04-25 Thread Wiles, Keith
> On Apr 24, 2019, at 12:34 PM, Tom Barbette wrote: > > Add rte_eth_read_clock to read the raw clock of a devide. > > The main use is to get the device clock conversion co-efficients to be > able to translate the raw clock of the timestamp field of the pkt mbuf > to a local synced time value.

Re: [dpdk-dev] [PATCH v4 2/2] ipc: fix tap pmd memleak

2019-04-25 Thread Wiles, Keith
> On Apr 25, 2019, at 7:48 AM, Lipiec, Herakliusz > wrote: > > When sending synchronous IPC requests, the caller must free the response > buffer if the request was successful and reply is no longer needed. > Fix the code to correctly > use the IPC API. > > Bugzilla ID: 228 > Fixes: c9aa56ede

Re: [dpdk-dev] [RFC v2 2/2] eal: introduce random generator function with upper bound

2019-04-22 Thread Wiles, Keith
> On Apr 22, 2019, at 2:07 AM, Mattias Rönnblom > wrote: > > On 2019-04-22 06:33, Wiles, Keith wrote: > >>> From a performance point of view, the high-loop-count cases are rare enough >>> not to pose a serious threat. For example, being forced to redo rte_ra

Re: [dpdk-dev] [RFC v2 2/2] eal: introduce random generator function with upper bound

2019-04-21 Thread Wiles, Keith
Sent from my iPhone > On Apr 21, 2019, at 2:05 PM, Mattias Rönnblom > wrote: > > On 2019-04-20 23:08, Wiles, Keith wrote: > >>> +uint64_t __rte_experimental >>> +rte_rand_max(uint64_t upper_bound) >>> +{ >>> +uint8_t zeros; >>>

Re: [dpdk-dev] [RFC v2 2/2] eal: introduce random generator function with upper bound

2019-04-20 Thread Wiles, Keith
> On Apr 19, 2019, at 5:21 PM, Mattias Rönnblom > wrote: > > Add a function rte_rand_max() which generates an uniformly distributed > pseudo-random number less than a user-specified upper bound. > > The commonly used pattern rte_rand() % SOME_VALUE, in addition to > being slow, also creates b

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

2019-04-04 Thread Wiles, Keith
> On Apr 4, 2019, at 11:56 AM, Kevin Traynor wrote: > > On 04/04/2019 11:54, Bruce Richardson wrote: > > >> >> My thoughts on the matter are: >> 1. I think we really need to do work to start hiding more of our data >> structures - like what Stephen's latest RFC does. This hiding should redu

Re: [dpdk-dev] [PATCH 0/5] clean up snprintf use for string copying

2019-04-03 Thread Wiles, Keith
> On Apr 3, 2019, at 9:45 AM, Bruce Richardson > wrote: > > There are quite a few instances remaining in DPDK where snprintf is being > used for string copying. These were not being picked up by our existing > coccinelle script, but that can be fixed by editing the script and running > it aga

Re: [dpdk-dev] [RFC 3/3] bus/pci: add mdev support

2019-04-03 Thread Wiles, Keith
Some minor nits. > On Apr 3, 2019, at 2:18 AM, Tiwei Bie wrote: > > This patch adds the mdev support in PCI bus driver. A mdev > driver is introduced to probe the mdev devices whose device > API is "vfio-pci" on the mdev bus. > > PS. There are some hacks in this patch for now. > > Signed-off-b

Re: [dpdk-dev] [PATCH] eal: change init macro as exec environment specific

2019-04-02 Thread Wiles, Keith
> On Apr 2, 2019, at 7:57 AM, Thomas Monjalon wrote: > > 11/10/2017 16:33, Jerin Jacob: >> From: Thomas Monjalon >>> 07/08/2017 14:04, Jerin Jacob: baremetal execution environments may have a different method to enable RTE_INIT instead of using compiler constructor scheme. Move

Re: [dpdk-dev] [PATCH v3] app/pdump: enhance to support multi-core capture

2019-03-28 Thread Wiles, Keith
> On Mar 28, 2019, at 10:04 AM, Varghese, Vipin > wrote: > > Enhance pdump application, to allow user to run on multiple cores. > > Signed-off-by: Vipin Varghese > --- > > Change Log: > > V3: > - correct the parse_usage - Vipin Varghese > - add change log - Vipin Varghese > > V2: > - Rep

Re: [dpdk-dev] [PATCH v2 0/3] Add rte_eth_read_clock API

2019-03-27 Thread Wiles, Keith
> On Mar 27, 2019, at 9:41 AM, Stephen Hemminger > wrote: > > On Wed, 27 Mar 2019 07:19:32 +0100 > Tom Barbette wrote: > >> Some NICs allow to timestamp packets, but do not support the full >> PTP synchronization process. Hence, the value set in the mbuf >> timestamp field is only the raw v

Re: [dpdk-dev] [PATCH v2 1/7] mbuf: new function to generate raw Tx offload value

2019-03-20 Thread Wiles, Keith
> On Mar 20, 2019, at 10:24 AM, Konstantin Ananyev > wrote: > > Operations to set/update bit-fields often cause compilers > to generate suboptimal code. > To help avoid such situation for tx_offload fields: > introduce new enum for tx_offload bit-fields lengths and offsets, > and new function

Re: [dpdk-dev] [EXT] Re: [PATCH v2 2/2] eal: roundup tsc frequency when estimating it

2019-03-16 Thread Wiles, Keith
> On Mar 16, 2019, at 12:56 PM, Pavan Nikhilesh Bhagavatula > wrote: > > On Sat, 2019-03-16 at 17:18 +0000, Wiles, Keith wrote: >>> On Mar 16, 2019, at 10:06 AM, Pavan Nikhilesh Bhagavatula < >>> pbhagavat...@marvell.com> wrote: >>> >>>

Re: [dpdk-dev] [EXT] Re: [PATCH v2 2/2] eal: roundup tsc frequency when estimating it

2019-03-16 Thread Wiles, Keith
> On Mar 16, 2019, at 10:06 AM, Pavan Nikhilesh Bhagavatula > wrote: > > On Sat, 2019-03-16 at 14:42 +0000, Wiles, Keith wrote: >>> On Mar 16, 2019, at 2:03 AM, Pavan Nikhilesh Bhagavatula < >>> pbhagavat...@marvell.com> wrote: >>> >>&g

Re: [dpdk-dev] [PATCH v2 2/2] eal: roundup tsc frequency when estimating it

2019-03-16 Thread Wiles, Keith
> On Mar 16, 2019, at 2:03 AM, Pavan Nikhilesh Bhagavatula > wrote: > > From: Pavan Nikhilesh > > When estimating tsc frequency using sleep/gettime round it up to the > nearest multiple of 10Mhz for more accuracy. > > Signed-off-by: Pavan Nikhilesh > --- > Useful in case of ARM64 if we en

Re: [dpdk-dev] [PATCH v4] net/tap: fix missing _SC_IOV_MAX

2019-03-08 Thread Wiles, Keith
> On Mar 8, 2019, at 1:06 PM, olegpoly123 wrote: > > If the value _SC_IOV_MAX is missing, sysconf returns -1. > In this case, iov_max is set to a default value of 1024. > > Cc: sta...@dpdk.org > > Signed-off-by: Oleg Polyakov > --- > drivers/net/tap/rte_eth_tap.c | 8 > 1 file chang

Re: [dpdk-dev] [PATCH] net/tap: fix missing _SC_IOV_MAX

2019-03-08 Thread Wiles, Keith
> On Mar 8, 2019, at 12:00 PM, olegpoly123 wrote: > > If the value _SC_IOV_MAX is missing, sysconf returns -1. > In this case, iov_max is set to a default value of 1024. > > Cc: sta...@dpdk.org > > Signed-off-by: olegpoly123 > --- > drivers/net/tap/rte_eth_tap.c | 8 > 1 file change

Re: [dpdk-dev] [PATCH v2 2/2] Define macro for iov_max default value

2019-03-08 Thread Wiles, Keith
> On Mar 8, 2019, at 9:55 AM, olegpoly123 wrote: > > Cc: sta...@dpdk.org > > Signed-off-by: Oeg Polyakov > --- > drivers/net/tap/rte_eth_tap.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c > index

Re: [dpdk-dev] [PATCH] net/tap: fix missing _SC_IOV_MAX

2019-03-07 Thread Wiles, Keith
> On Mar 7, 2019, at 4:25 PM, olegpoly123 wrote: > > If the value _SC_IOV_MAX is missing, sysconf returns -1. > In this case, iov_max is set to a default value of 1024. > > Cc: sta...@dpdk.org > > Signed-off-by: Oeg Polyakov > --- > drivers/net/tap/rte_eth_tap.c | 5 + > 1 file changed,

Re: [dpdk-dev] [PATCH 12/12] net/tap: fix incorrect rxq errors stat

2019-03-04 Thread Wiles, Keith
> On Mar 4, 2019, at 5:18 AM, David Marchand wrote: > > Transmit errors must not be reported in q_errors[] which is for > reception. > > Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD") > Cc: sta...@dpdk.org > Cc: Keith Wiles > Signed-off-by: David Marchand > --- > drivers/net/tap/rt

Re: [dpdk-dev] [PATCH 3/5] app/testpmd: add missing transmit errors stats

2019-02-15 Thread Wiles, Keith
> On Feb 15, 2019, at 8:05 AM, Bruce Richardson > wrote: > > On Fri, Feb 15, 2019 at 10:33:47AM +0100, David Marchand wrote: >> On Fri, Feb 15, 2019 at 9:58 AM Thomas Monjalon >> <[1]tho...@monjalon.net> wrote: >> >> 14/02/2019 19:51, David Marchand: >>> What is the purpose of oerror

Re: [dpdk-dev] [RFC PATCH] mbuf: move headers not fragmented check to checksum

2019-02-13 Thread Wiles, Keith
> On Feb 13, 2019, at 3:50 AM, Andrew Rybchenko > wrote: > > Ping. > > Do 2 weeks without reply mean that it looks good and I should send non-RCF > version? Just send the non-RFC patch as it seems most do not even look at the RFC’s anyway. > > Andrew. > > On 1/29/19 11:49 AM, Andrew Rybc

Re: [dpdk-dev] [PATCH] kni: fix sprintf with snprintf

2019-02-07 Thread Wiles, Keith
> On Feb 7, 2019, at 10:40 AM, Ferruh Yigit wrote: > > On 2/4/2019 7:02 AM, Pallantla Poornima wrote: >> sprintf function is not secure as it doesn't check the length of string. >> More secure function snprintf is used. >> >> Fixes: 3fc5ca2f63 ("kni: initial import") >> Fixes: b9ee370557 ("kn

Re: [dpdk-dev] Question about DPDK hugepage fd change

2019-02-05 Thread Wiles, Keith
> On Feb 5, 2019, at 3:49 PM, Iain Barker wrote: > > >> >> Maybe I do not see the full problem here. If DPDK used poll instead of >> select it would solve the 1024 problem as poll has a high limit to the >> number of file descriptors at least that was my assumption. >>> > > Thanks Keith.

Re: [dpdk-dev] Question about DPDK hugepage fd change

2019-02-05 Thread Wiles, Keith
> On Feb 5, 2019, at 3:27 PM, Iain Barker wrote: > >> >> Would poll work here instead? > > Poll (or epoll) would definitely work - if we controlled the source and > compilation of all the libraries that the application links against. > > But an app doesn’t know how the libraries in the OS a

Re: [dpdk-dev] Question about DPDK hugepage fd change

2019-02-05 Thread Wiles, Keith
> On Feb 5, 2019, at 12:56 PM, Iain Barker wrote: > > Hi everyone, > > We just updated our application from DPDK 17.11.4 (LTS) to DPDK 18.11 (LTS) > and we noticed a regression. > > Our host platform is providing 2MB huge pages, so for 8GB reservation this > means 4000 pages are allocated.

Re: [dpdk-dev] Compiler for Windows

2019-01-31 Thread Wiles, Keith
OK just seems like an unnecessary step to me. Sent from my iPhone > On Jan 31, 2019, at 11:36 AM, Thomas Monjalon wrote: > > 31/01/2019 18:12, Wiles, Keith: >> Sorry I have to top post. I had surgery on my shoulder so I’m doing this >> from my phone. >>

Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C

2019-01-31 Thread Wiles, Keith
I agree using register for todays compilers is unnecessary and can actually be wrong in some cases. The compilers can pick the correct registers better then we can normally and restricting the compiler makes no sense. Sent from my iPhone > On Jan 31, 2019, at 3:11 AM, Bruce Richardson > wrot

Re: [dpdk-dev] Compiler for Windows

2019-01-31 Thread Wiles, Keith
Sorry I have to top post. I had surgery on my shoulder so I’m doing this from my phone. Why does the windows Eal directory have to be a stub? Normally the port must use a separate directory for different architecture. In this case it is the windows architecture which should have all of the ch

Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix parsing zero socket memory and limits

2019-01-23 Thread Wiles, Keith
> On Jan 23, 2019, at 5:03 PM, Thomas Monjalon wrote: > > 23/01/2019 11:15, Burakov, Anatoly: >> On 22-Jan-19 4:27 PM, Ilya Maximets wrote: >>> Modern memory mode allowes to not reserve any memory by the >>> '--socket-mem' option. i.e. it could be possible to specify >>> zero preallocated memo

Re: [dpdk-dev] dev Digest, Vol 231, Issue 6

2019-01-21 Thread Wiles, Keith
r you verify that pings are working. > > Regards, > Anudeep > > > On Mon, Jan 21, 2019, 21:27 Wiles, Keith > > > On Jan 21, 2019, at 7:23 AM, Anudeep Kumar wrote: > > > > Hi, > > > > I am unable to run l3fwd in dpdk. Please provide steps to run. >

Re: [dpdk-dev] dev Digest, Vol 231, Issue 6

2019-01-21 Thread Wiles, Keith
> On Jan 21, 2019, at 7:23 AM, Anudeep Kumar wrote: > > Hi, > > I am unable to run l3fwd in dpdk. Please provide steps to run. > > Regards, > Anudeep > > On Mon, Jan 21, 2019, 18:49 Please provide much more information as to what the problem is here. DPDK version used? What do you mean

Re: [dpdk-dev] [PATCH v2 7/7] net/tap: don't print pointer in info message

2019-01-14 Thread Wiles, Keith
> On Jan 11, 2019, at 2:35 PM, Stephen Hemminger > wrote: > > Printing pointer in log is uninformative (unless in a debugger), > instead print the assigned kernel device name which correlates > well with what TAP is doing. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/tap/rte_eth

Re: [dpdk-dev] [PATCH v2] ethdev: report error on name truncation

2019-01-13 Thread Wiles, Keith
> On Jan 13, 2019, at 2:02 PM, Thomas Monjalon wrote: > > 13/01/2019 20:28, Wiles, Keith: >>> On Jan 13, 2019, at 9:38 AM, Nithin Kumar Dabilpuram >>> wrote: >>> --- a/lib/librte_ethdev/rte_ethdev.c >>> +++ b/lib/librte_ethdev/rte_et

Re: [dpdk-dev] [PATCH v2] ethdev: report error on name truncation

2019-01-13 Thread Wiles, Keith
> On Jan 13, 2019, at 9:38 AM, Nithin Kumar Dabilpuram > wrote: > > Currently this api doesn't report error if name is > truncated and so user is not sure about uniqueness > of name. This change reports error to help user. > > Signed-off-by: Nithin Dabilpuram > --- > > v2: > Fix issue caus

Re: [dpdk-dev] [PATCH 3/6] net/tap: check interface name in kvargs

2019-01-11 Thread Wiles, Keith
> On Jan 11, 2019, at 1:49 PM, Stephen Hemminger > wrote: > > On Fri, 11 Jan 2019 19:37:00 +0000 > "Wiles, Keith" wrote: > >>> +/* make sure name is a possible Linux network device name */ >>> +static bool is_valid_iface(const char *name) &g

Re: [dpdk-dev] [PATCH 2/6] net/tap: allow full length names

2019-01-11 Thread Wiles, Keith
> On Jan 11, 2019, at 1:48 PM, Stephen Hemminger > wrote: > > On Fri, 11 Jan 2019 19:32:39 +0000 > "Wiles, Keith" wrote: > >>> On Jan 11, 2019, at 12:06 PM, Stephen Hemminger >>> wrote: >>> >>> The code for set_interfac

Re: [dpdk-dev] [PATCH 0/6] net/tap: fixes and cleanups

2019-01-11 Thread Wiles, Keith
> On Jan 11, 2019, at 12:06 PM, Stephen Hemminger > wrote: > > The tap device (used by vdev_netvsc on Azure) has a bug that > prevents it working with primary/secondary process model because > the device name generation assumed a single process. The fix for > this is to have the kernel assig

Re: [dpdk-dev] [PATCH 5/6] net/tap: let kernel choose tun device name

2019-01-11 Thread Wiles, Keith
> On Jan 11, 2019, at 12:06 PM, Stephen Hemminger > wrote: > > Assigning tun and tap index in DPDK tap device driver is racy and > fails if used with primary/secondary process model. Instead, use the > kernel feature of device wildcarding where if a name with %d is used > the kernel will fill

Re: [dpdk-dev] [PATCH 3/6] net/tap: check interface name in kvargs

2019-01-11 Thread Wiles, Keith
> On Jan 11, 2019, at 12:06 PM, Stephen Hemminger > wrote: > > If interface name is passed to remote or iface then check > the length and for invalid characters. This avoids problems where > name gets truncated or rejected by kernel. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/

  1   2   3   4   5   6   7   8   9   >