[PATCH] examples/ipsec-secgw: fix number of queue pairs

2025-07-09 Thread Volodymyr Fialko
.@dpdk.org Signed-off-by: Volodymyr Fialko --- examples/ipsec-secgw/ipsec-secgw.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c index 063cc8768e..fe489f9a56 100644 --- a/examples/ipsec-s

RE: [EXTERNAL] [PATCH 12/15] reorder: add allocation function attributes

2025-01-21 Thread Volodymyr Fialko
> Use function attributes to catch cases where reorder table is allocated > but not freed correctly. > > Signed-off-by: Stephen Hemminger > --- > lib/reorder/rte_reorder.h | 23 --- > 1 file changed, 12 insertions(+), 11 deletions(-) Acked-by: Volodymyr Fialko

RE: [EXTERNAL] Re: [PATCH v5] bitmap: add scan from offset function

2024-10-10 Thread Volodymyr Fialko
From discussion with Thomas in previous versions of this patch, we agreed to omit both markers. > From: Thomas Monjalon mailto:tho...@monjalon.net>> > Sent: Monday, July 3, 2023 2:17 PM > To: Dumitrescu, Cristian; Volodymyr Fialko > Cc: dev@dpdk.org<mailto:dev@d

Re: [PATCH v5] bitmap: add scan from offset function

2024-07-03 Thread Volodymyr Fialko
> From: Thomas Monjalon > Sent: Wednesday, July 3, 2024 2:50 PM > To: Volodymyr Fialko > Cc: dev@dpdk.org; cristian.dumitre...@intel.com; Jerin Jacob; Anoob Joseph > Subject: Re: [PATCH v5] bitmap: add scan from offset function > > 03/07/2023 14:39, Volodymyr Fialko: >

RE: [PATCH v5] bitmap: add scan from offset function

2024-07-03 Thread Volodymyr Fialko
Hi Thomas, Is there any remaining work for this patch, or is it ready to be merged? /Volodymyr

RE: [EXT] [PATCH 8/9] reorder: use C11 alignof

2024-01-24 Thread Volodymyr Fialko
hin Kumar Dabilpuram > ; Ori Kam > ; Pavan Nikhilesh Bhagavatula ; > Thomas Monjalon > ; Volodymyr Fialko ; Tyler Retzlaff > > Subject: [EXT] [PATCH 8/9] reorder: use C11 alignof > > External Email > > --

RE: [EXT] [PATCH v3] examples/packet_ordering: fix segfault in disable_reorder mode

2023-12-18 Thread Volodymyr Fialko
> -Original Message- > From: Qian Hao > Sent: Wednesday, December 13, 2023 12:07 PM > To: dev@dpdk.org > Cc: Volodymyr Fialko > Subject: [EXT] [PATCH v3] examples/packet_ordering: fix segfault in > disable_reorder mod

RE: [EXT] [PATCH] examples/packet_ordering: fix segfault in disable_reorder mode

2023-12-11 Thread Volodymyr Fialko
> -Original Message- > From: Qian Hao > Sent: Friday, December 8, 2023 1:43 PM > To: dev@dpdk.org > Cc: Volodymyr Fialko > Subject: [EXT] [PATCH] examples/packet_ordering: fix segfault in > disable_reorder mode Good catch overall, but few comments: 1. Please

RE: [EXT] [PATCH v8 2/6] reorder: use a dynamic logtype

2023-08-16 Thread Volodymyr Fialko
> -Original Message- > From: Stephen Hemminger > Sent: Monday, August 14, 2023 6:31 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; > sergio.gonzalez.mon...@intel.com; > Volodymyr Fialko ; Reshma Pattan > ; Neil Horman > ; Richardson Bruce ; > Declan Dohe

[PATCH v5] bitmap: add scan from offset function

2023-07-03 Thread Volodymyr Fialko
and perform scan, this will allow getting the next set bit after certain offset within one scan call. Signed-off-by: Volodymyr Fialko --- v2: - added rte_bitmap_scan_from_offset v3: - added note for internal use only for init_at function v4: - marked init_at function as __rte_internal v5

RE: [EXT] Re: [PATCH v3] bitmap: add scan from offset function

2023-07-03 Thread Volodymyr Fialko
> -Original Message- > From: Thomas Monjalon > Sent: Monday, July 3, 2023 1:51 PM > To: Dumitrescu, Cristian ; Volodymyr Fialko > > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Anoob Joseph > > Subject: [EXT] Re: [PATCH v3] bitmap: add scan from offset func

RE: [PATCH v3] bitmap: add scan from offset function

2023-07-03 Thread Volodymyr Fialko
the double underscores. So, should I simply remove __rte_internal from v4, or there's another approach to resolve this issue(beside creating .c file)? /Volodymyr > -Original Message- > From: Dumitrescu, Cristian > Sent: Friday, June 23, 2023 2:41 PM > To: Thomas Monjalon ; Vol

[PATCH v4] bitmap: add scan from offset function

2023-07-03 Thread Volodymyr Fialko
and perform scan, this will allow getting the next set bit after certain offset within one scan call. Signed-off-by: Volodymyr Fialko --- v2: - added rte_bitmap_scan_from_offset v3: - added note for internal use only for init_at function v4: - marked init_at function as __rte_internal app

[PATCH v3] bitmap: add scan from offset function

2023-06-21 Thread Volodymyr Fialko
and perform scan, this will allow getting the next set bit after certain offset within one scan call. Signed-off-by: Volodymyr Fialko --- v2: - added rte_bitmap_scan_from_offset v3 - added note for internal use only for init_at function app/test/test_bitmap.c | 33

[PATCH] test/pdcp: remove side affect from assertion

2023-06-19 Thread Volodymyr Fialko
Remove side affect from test assertion, to avoid different behaviour in non-debug build. Issues reported by coverity scan. Coverity issue: 385419, 385420 Fixes: 6f00462979ad ("test/pdcp: add timer expiry cases") Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 6

[PATCH v2] bitmap: add scan from offset function

2023-06-13 Thread Volodymyr Fialko
and perform scan, this will allow getting the next set bit after certain offset within one scan call. Signed-off-by: Volodymyr Fialko --- app/test/test_bitmap.c | 33 - lib/eal/include/rte_bitmap.h | 56 2 files changed, 88

RE: [PATCH] bitmap: add scan init at given position

2023-06-12 Thread Volodymyr Fialko
Hi Cristian, > > My understanding is your proposed procedure for scanning starting at an > offset is: > 1. Call the new function: __rte_bitmap_scan_init_at() 2. Call the regular > function: rte_bitmap_scan() > > I think this procedure is not ideal, therefore I suggest we create a new API > f

[PATCH] maintainers: update for Reorder

2023-06-06 Thread Volodymyr Fialko
Update maintainer for Reorder lib. Signed-off-by: Volodymyr Fialko --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 42a5b20fb7..09befb116f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1488,7 +1488,7 @@ F: examples/distributor

RE: [PATCH] reorder: introduce API to obtain memory footprint

2023-06-02 Thread Volodymyr Fialko
Hi Thomas and Reshma, I would be interested in taking on the role of maintaining the reorder library. > -Original Message- > From: Pattan, Reshma > Sent: Friday, June 2, 2023 1:06 PM > To: Thomas Monjalon ; Volodymyr Fialko > > Cc: dev@dpdk.org; Jerin Jacob Kol

[PATCH v2] reorder: improve buffer structure layout

2023-04-17 Thread Volodymyr Fialko
bool is_initialized; // -> padding to cache align (cir_buffer is also cache aligned) struct cir_buffer ready_buf; struct cir_buffer order_buf; // -> no padding }; Signed-off-by: Volodymyr Fialko Acked-by: Bruce Richardson --- v2: - changed flag type to `bool` lib/reorder/rte_r

[PATCH] reorder: introduce API to obtain memory footprint

2023-04-14 Thread Volodymyr Fialko
required memory for reorder buffer. Signed-off-by: Volodymyr Fialko --- app/test/test_reorder.c | 8 lib/reorder/rte_reorder.c | 13 + lib/reorder/rte_reorder.h | 16 lib/reorder/version.map | 2 ++ 4 files changed, 31 insertions(+), 8 deletions(-) diff

[PATCH] reorder: improve buffer structure layout

2023-04-14 Thread Volodymyr Fialko
int is_initialized; // -> padding to cache align (cir_buffer is also cache aligned) struct cir_buffer ready_buf; struct cir_buffer order_buf; // -> no padding }; Signed-off-by: Volodymyr Fialko --- lib/reorder/rte_reorder.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[PATCH] bitmap: add scan init at given position

2023-04-14 Thread Volodymyr Fialko
, this will allow getting the next bit set after some value within one rte_bitmap_scan() call. Signed-off-by: Volodymyr Fialko --- app/test/test_bitmap.c | 23 +++ lib/eal/include/rte_bitmap.h | 22 ++ 2 files changed, 45 insertions(+) diff --git a

RE: [PATCH v2] reorder: fix registration of dynamic field in mbuf

2023-03-15 Thread Volodymyr Fialko
Hi, A gentle reminder, please review and ack/comment. Can we have this merged before RC3? > -Original Message- > From: Volodymyr Fialko > Sent: Monday, March 13, 2023 2:04 PM > To: dev@dpdk.org; Reshma Pattan ; David Marchand > ; Andrew Rybchenko > Cc: Jerin Jacob Kol

[PATCH] crypto/cnxk: update number of max capabilities

2023-03-14 Thread Volodymyr Fialko
scans will read memory outside of the array. Signed-off-by: Volodymyr Fialko --- drivers/common/cnxk/roc_platform.h | 1 + drivers/crypto/cnxk/cnxk_cryptodev.h | 2 +- .../crypto/cnxk/cnxk_cryptodev_capabilities.c | 18 +- 3 files changed, 7 insertions(+

[PATCH v5] test: add cryptodev crosscheck suite

2023-03-14 Thread Volodymyr Fialko
chaining. Example commands: DPDK_TEST=cryptodev_crosscheck ./dpdk-test \ --vdev "crypto_openssl0" --vdev "crypto_openssl1" DPDK_TEST=cryptodev_crosscheck ./dpdk-test \ -a --vdev "crypto_openssl" Signed-off-by: Volodymyr Fialko --- V2: - Updated commit m

RE: [PATCH v2] test: add cryptodev crosscheck suite

2023-03-14 Thread Volodymyr Fialko
Hi Ciara, > -Original Message- > From: Power, Ciara > Sent: Wednesday, March 8, 2023 6:31 PM > To: Volodymyr Fialko ; dev@dpdk.org; Akhil Goyal > ; Fan > Zhang > Cc: Jerin Jacob Kollanukkaran ; Anoob Joseph > ; > hemant.agra...@nxp.com; Ji, Kai > Subj

[PATCH v4] test: add cryptodev crosscheck suite

2023-03-14 Thread Volodymyr Fialko
chaining. Example commands: DPDK_TEST=cryptodev_crosscheck ./dpdk-test \ --vdev "crypto_openssl0" --vdev "crypto_openssl1" DPDK_TEST=cryptodev_crosscheck ./dpdk-test \ -a --vdev "crypto_openssl" Signed-off-by: Volodymyr Fialko --- V2: - Updated commit m

RE: [EXT] Re: [PATCH] reorder: fix registration of dynamic field in mbuf

2023-03-13 Thread Volodymyr Fialko
> -Original Message- > From: Stephen Hemminger > Sent: Monday, March 13, 2023 4:51 PM > To: Volodymyr Fialko > Cc: dev@dpdk.org; Reshma Pattan ; David Marchand > ; Andrew Rybchenko > ; Jerin Jacob > Kollanukkaran ; Anoob Joseph > Subject: [EXT] Re: [PATCH

RE: [EXT] Re: [PATCH] reorder: fix registration of dynamic field in mbuf

2023-03-13 Thread Volodymyr Fialko
> All rte_reorder_buffer objects need to go through rte_reorder_init(). > You can check rte_reorder_init() return code. Hi David, I agree with all comments, however there is one catch with locks. Both reorder lib and mbuf dynamic field are using `rte_mcfg_tailq` read/write lock for synchronization

[PATCH v2] reorder: fix registration of dynamic field in mbuf

2023-03-13 Thread Volodymyr Fialko
lock for synchronization, to avoid deadlocking move reorder buffer initialization before queue insertion. Fixes: 01f3496695b5 ("reorder: switch sequence number to dynamic mbuf field") Cc: sta...@dpdk.org Signed-off-by: Volodymyr Fialko --- lib/reorder/rte

[PATCH v2] reorder: fix registration of dynamic field in mbuf

2023-03-13 Thread Volodymyr Fialko
lock for synchronization, to avoid deadlocking move reorder buffer initialization before queue insertion. Fixes: 01f3496695b5 ("reorder: switch sequence number to dynamic mbuf field") Cc: sta...@dpdk.org Signed-off-by: Volodymyr Fialko --- lib/reorder/rte

[PATCH] reorder: fix registration of dynamic field in mbuf

2023-03-13 Thread Volodymyr Fialko
") Signed-off-by: Volodymyr Fialko --- lib/reorder/rte_reorder.c | 40 ++- 1 file changed, 31 insertions(+), 9 deletions(-) diff --git a/lib/reorder/rte_reorder.c b/lib/reorder/rte_reorder.c index 6e029c9e02..a759a9c434 100644 --- a/lib/reorder/rte_reor

[PATCH] event/cnxk: fix SSO return code at fini

2023-03-02 Thread Volodymyr Fialko
dev_fini() can return EAGAIN in case if LF is active(used by other devices). Ignoring return code leads to early free of resources that are still in use. Fixes: 8558dcaa05b8 ("event/cnxk: add build infra and device setup") Cc: sta...@dpdk.org Signed-off-by: Volodymyr Fialko --- dri

[PATCH v2 2/2] reorder: add ability to set min sequence number

2023-02-20 Thread Volodymyr Fialko
Add API `rte_reorder_min_seqn_set` to allow user to specify minimum sequence number. Currently sequence number of first inserted packet is used as minimum sequence number. But for case when we want to wait for packets before the received one this will not work. Signed-off-by: Volodymyr Fialko

[PATCH v2 0/2] reorder: introduce new APIs

2023-02-20 Thread Volodymyr Fialko
This patch series provides new APIs for reorder library and test cases for them. v2: - squash tests with corresponding API patches - address minor comments Volodymyr Fialko (2): reorder: add new drain up to seq number API reorder: add ability to set min sequence number app/test

[PATCH v2 1/2] reorder: add new drain up to seq number API

2023-02-20 Thread Volodymyr Fialko
give user ability to drain inserted packets, without need to wait for missing or newer packets. Signed-off-by: Volodymyr Fialko --- app/test/test_reorder.c | 91 +++ lib/reorder/rte_reorder.c | 78 + lib/reorder/rte_reorder.h

[PATCH v3] test: add cryptodev crosscheck suite

2023-02-09 Thread Volodymyr Fialko
chaining. Example command: DPDK_TEST=cryptodev_crosscheck ./dpdk-test \ -a --vdev "crypto_openssl" Signed-off-by: Volodymyr Fialko --- V2: - Updated commit message. V3: - Removed usage of deprecated crypto strings API. app/test/meson.build |1 +

[PATCH v2] bus: fix leak for devices without driver

2023-02-09 Thread Volodymyr Fialko
Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown") Cc: sta...@dpdk.org Signed-off-by: Volodymyr Fialko --- V2: - Updated commit message. drivers/bus/pci/pci_common.c | 3 ++- drivers/bus/vdev/vdev.c | 5 +++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/

[PATCH v2] test: add cryptodev crosscheck suite

2023-02-09 Thread Volodymyr Fialko
chaining. Example command: DPDK_TEST=cryptodev_crosscheck ./dpdk-test \ -a --vdev "crypto_openssl" Signed-off-by: Volodymyr Fialko --- V2: - Updated commit message. app/test/meson.build |1 + app/test/test_cryptodev_crosscheck.c | 1008 +

RE: [PATCH 0/2] lib/reorder: fix drain/free issues

2023-02-06 Thread Volodymyr Fialko
Hi All, Kind reminder to all maintainers, please review and ack/comment. > This patch address issues with reorder drain/free, discovered with enabled > `RTE_LIBRTE_MEMPOOL_DEBUG`.

[PATCH] test/crypto: add missing MAC-I to PDCP vectors

2023-01-24 Thread Volodymyr Fialko
ot;) Fixes: cca7d1f78524 ("test/crypto: add PDCP U-Plane encap with integrity cases") Cc: sta...@dpdk.org Signed-off-by: Volodymyr Fialko --- app/test/test_cryptodev_security_pdcp_test_vectors.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) d

RE: [PATCH 3/3] test/reorder: add cases to cover new API

2023-01-20 Thread Volodymyr Fialko
to same packet twice due to double free. > -Original Message- > From: Volodymyr Fialko > Sent: Friday, January 20, 2023 11:22 AM > To: dev@dpdk.org; Reshma Pattan > Cc: Jerin Jacob Kollanukkaran ; Anoob Joseph > ; > Volodymyr Fialko > Subject: [PATCH 3/3] t

[PATCH 3/3] test/reorder: add cases to cover new API

2023-01-20 Thread Volodymyr Fialko
Add new test cases to cover `rte_reorder_drain_up_to_seqn` and `rte_reorder_min_seqn_set`. Signed-off-by: Volodymyr Fialko --- app/test/test_reorder.c | 160 1 file changed, 160 insertions(+) diff --git a/app/test/test_reorder.c b/app/test

[PATCH 2/3] reorder: add ability to set min sequence number

2023-01-20 Thread Volodymyr Fialko
Add API `rte_reorder_min_seqn_set` to allow user to specify minimum sequence number. Currently sequence number of first inserted packet is used as minimum sequence number. But for case when we want to wait for packets before the received one this will not work. Signed-off-by: Volodymyr Fialko

[PATCH 1/3] reorder: add new drain up to seq number API

2023-01-20 Thread Volodymyr Fialko
give user ability to drain inserted packets, without need to wait for missing or newer packets. Signed-off-by: Volodymyr Fialko --- lib/reorder/rte_reorder.c | 77 +++ lib/reorder/rte_reorder.h | 25 + lib/reorder/version.map | 1 + 3 files changed

[PATCH 0/3] reorder: introduce new APIs

2023-01-20 Thread Volodymyr Fialko
This patch series provides new APIs for reorder library and test cases for them. Volodymyr Fialko (3): reorder: add new drain up to seq number API reorder: add ability to set min sequence number test/reorder: add cases to cover new API app/test/test_reorder.c | 160

[PATCH v2] eventdev/crypto: fix missing crypto vec limits

2023-01-18 Thread Volodymyr Fialko
Add missing function `rte_event_crypto_adapter_vector_limits_get` to version.map. Fixes: c1749bc5ee10 ("eventdev: introduce event cryptodev vector type") Signed-off-by: Volodymyr Fialko --- v2: - mark function as experimental lib/eventdev/rte_event_crypto_adapter.h | 4 li

[PATCH v2 3/3] crypto/cnxk: add support for SHAKE hash

2023-01-12 Thread Volodymyr Fialko
Add support for SHAKE hash and hmac operations Signed-off-by: Volodymyr Fialko --- doc/guides/cryptodevs/cnxk.rst| 2 + doc/guides/cryptodevs/features/cn10k.ini | 2 + doc/guides/cryptodevs/features/cn9k.ini | 2 + drivers/common/cnxk/roc_se.h | 4

[PATCH v2 2/3] app/test: add SHAKE test cases

2023-01-12 Thread Volodymyr Fialko
Add test cases for SHAKE hash algorithm for Digest and Digest-Verify. Signed-off-by: Volodymyr Fialko --- app/test/test_cryptodev_hash_test_vectors.h | 66 + 1 file changed, 66 insertions(+) diff --git a/app/test/test_cryptodev_hash_test_vectors.h b/app/test

[PATCH v2 1/3] cryptodev: add SHAKE algorithm

2023-01-12 Thread Volodymyr Fialko
Add SHAKE to enum of auth algorithms. Signed-off-by: Volodymyr Fialko --- doc/guides/cryptodevs/features/default.ini | 2 ++ lib/cryptodev/rte_crypto_sym.h | 7 ++- lib/cryptodev/rte_cryptodev.c | 5 - 3 files changed, 12 insertions(+), 2 deletions(-) diff

[PATCH v2 0/3] Add support for SHAKE

2023-01-12 Thread Volodymyr Fialko
This series defines new enums for SHAKE128 and SHAKE256 authentication algorithms and implements support for CNXK crypto PMD. v2: - rebased for dpdk-next-crypto Volodymyr Fialko (3): cryptodev: add SHAKE algorithm app/test: add SHAKE test cases crypto/cnxk: add support for SHAKE hash app

[PATCH 2/2] test/reorder: fix double free of drained buffers

2023-01-07 Thread Volodymyr Fialko
Set to zero array of drained buffers after free, to prevent freeing them one more time. Discovered with enabled `RTE_LIBRTE_MEMPOOL_DEBUG`. Fixes: ecd867faa860 ("test/reorder: fix freeing mbuf twice") Signed-off-by: Volodymyr Fialko --- app/test/test_reorder.c | 2 ++ 1 file

[PATCH 1/2] reorder: invalidate buf from ready queue in drain

2023-01-07 Thread Volodymyr Fialko
Set drained buffers from ready queue to NULL, since their ownership returned to user. Otherwise it's possible that both user and library will attempt to free the packet. Signed-off-by: Volodymyr Fialko --- lib/reorder/rte_reorder.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/re

[PATCH 0/2] lib/reorder: fix drain/free issues

2023-01-07 Thread Volodymyr Fialko
This patch address issues with reorder drain/free, discovered with enabled `RTE_LIBRTE_MEMPOOL_DEBUG`. Volodymyr Fialko (2): reorder: invalidate buf from ready queue in drain test/reorder: fix double free of drained buffers app/test/test_reorder.c | 2 ++ lib/reorder/rte_reorder.c | 1

[PATCH] bus: fix leak for devices without driver

2023-01-07 Thread Volodymyr Fialko
For devices not assigned to any driver, we leak a pci device object since it is never freed from the PCI bus device list, reported by ASAN. Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown") Signed-off-by: Volodymyr Fialko --- drivers/bus/pci/pci_common.c | 3 ++- drivers/bus/v

[PATCH 3/3] crypto/cnxk: add support for SHAKE hash

2023-01-04 Thread Volodymyr Fialko
Add support for SHAKE hash and hmac operations Signed-off-by: Volodymyr Fialko --- doc/guides/cryptodevs/cnxk.rst| 2 + doc/guides/cryptodevs/features/cn10k.ini | 2 + doc/guides/cryptodevs/features/cn9k.ini | 2 + drivers/common/cnxk/roc_se.h | 4

[PATCH 2/3] app/test: add SHAKE test cases

2023-01-04 Thread Volodymyr Fialko
Add test cases for SHAKE hash algorithm for Digest and Digest-Verify. Signed-off-by: Volodymyr Fialko --- app/test/test_cryptodev_hash_test_vectors.h | 66 + 1 file changed, 66 insertions(+) diff --git a/app/test/test_cryptodev_hash_test_vectors.h b/app/test

[PATCH 1/3] cryptodev: add SHAKE algorithm

2023-01-04 Thread Volodymyr Fialko
Add SHAKE to enum of auth algorithms. Signed-off-by: Volodymyr Fialko --- doc/guides/cryptodevs/features/default.ini | 2 ++ lib/cryptodev/rte_crypto_sym.h | 7 ++- lib/cryptodev/rte_cryptodev.c | 5 - 3 files changed, 12 insertions(+), 2 deletions(-) diff

[PATCH 0/3] Add support for SHAKE

2023-01-04 Thread Volodymyr Fialko
This series defines new enums for SHAKE128 and SHAKE256 authentication algorithms and implements support for CNXK crypto PMD. Depends-on: 26375 ("cryptodev: add algo enums to string conversion APIs") Volodymyr Fialko (3): cryptodev: add SHAKE algorithm app/test: add SHAKE test case

[PATCH] test: add cryptodev crosscheck suite

2022-12-21 Thread Volodymyr Fialko
Add new test suite that allow to crosscheck cryptodevs based on their capabilities. Test suite will scan supported capabilities, determine common and generate appropriate input, then suite will check if output from all crpytodevs are the same. Signed-off-by: Volodymyr Fialko --- app/test

RE: [PATCH] app/testeventdev: add vector worker to perf test

2022-12-06 Thread Volodymyr Fialko
> -Original Message- > From: Volodymyr Fialko > Sent: Friday, December 2, 2022 11:12 AM > To: dev@dpdk.org; Jerin Jacob Kollanukkaran > Cc: Anoob Joseph ; Akhil Goyal ; > Volodymyr Fialko > > Subject: [PATCH] app/testeventdev: add vector worker to perf

[PATCH] build: fix missing crypto vec limits in version

2022-12-06 Thread Volodymyr Fialko
Add missing function `rte_event_crypto_adapter_vector_limits_get` to version.map. Fixes: c1749bc5ee10 ("eventdev: introduce event cryptodev vector type") Signed-off-by: Volodymyr Fialko --- lib/eventdev/version.map | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/eventdev/ver

RE: [EXT] [PATCH v2 5/5] eventdev/crypto: add all failed events to circular buffer

2022-12-05 Thread Volodymyr Fialko
rocessing. > > Add all failed ops to buffer for later processing. > > Signed-off-by: Ganapati Kundapura > --- Acked-by: Volodymyr Fialko

RE: [EXT] [PATCH v2 4/5] eventdev/crypto: fix overflow in circular buffer

2022-12-05 Thread Volodymyr Fialko
cryptodev. > > Checked CPM backpressure for every iteration in enq_run() > > Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation") > > Signed-off-by: Ganapati Kundapura > --- Acked-by: Volodymyr Fialko

RE: [EXT] [PATCH v2 3/5] eventdev/crypto: fix wrong offset used while flushing events

2022-12-05 Thread Volodymyr Fialko
d events getting enqueued to eventdev > from the circular buffer. > > Fixed by enqueuing the events to eventdev from the head pointer of circular > buffer. > > Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation") > > Signed-off-by: Ganapati Kundapura > --- Acked-by: Volodymyr Fialko

RE: [EXT] [PATCH v2 2/5] eventdev/crypto: fix wrong crypto enqueue count stats

2022-12-05 Thread Volodymyr Fialko
ccessful enqueue of ops to cryptodev. > > Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation") > > Signed-off-by: Ganapati Kundapura > --- Acked-by: Volodymyr Fialko

[PATCH] app/testeventdev: add crypto producer burst mode

2022-12-02 Thread Volodymyr Fialko
--crypto_adptr_mode 1 --test=perf_atq \ --stlist=a --wlcores 1 --plcores 2 --prod_enq_burst_sz 32 Signed-off-by: Volodymyr Fialko --- app/test-eventdev/test_perf_common.c | 235 ++- doc/guides/tools/testeventdev.rst| 3 +- 2 files changed, 235 insertions(+), 3 deletions

[PATCH] app/testeventdev: add vector worker to perf test

2022-12-02 Thread Volodymyr Fialko
\ --enable_vector --vector_tmo_ns 0 --nb_flows 2 Signed-off-by: Volodymyr Fialko --- app/test-eventdev/test_perf_atq.c| 62 ++-- app/test-eventdev/test_perf_common.c | 68 +++--- app/test-eventdev/test_perf_common.h | 102 ++- app/test

RE: [EXT] [PATCH v2 1/5] eventdev/event_crypto: process event port's impl rel cap

2022-12-01 Thread Volodymyr Fialko
vents. > > This patch updates the adapter to query the port caps for implicit release to > decide on events > enqueuing back as NEW/FWD events. > > Signed-off-by: Ganapati Kundapura > --- Acked-by: Volodymyr Fialko

[PATCH] test/crypto: add scatter-gather test cases

2022-11-30 Thread Volodymyr Fialko
Add test cases to verify scatter-gather (SGL) buffers, with multiple segments. Signed-off-by: Volodymyr Fialko Signed-off-by: Archana Muniganti --- app/test/test_cryptodev.c| 49 ++--- app/test/test_cryptodev_security_ipsec.c | 93 +--- app/test

[PATCH] app/test: add SHA3 test cases

2022-11-09 Thread Volodymyr Fialko
Add test cases for SHA3 hash family for Digest and Digest-Verify. Signed-off-by: Volodymyr Fialko Expected vectors were generated with OpenSSL. Adding to CC original authors of PMDs that currently have support for SHA3 to check if there's any issues. --- app

[PATCH] examples/ipsec-secgw: fix uninitialized variable access

2022-11-09 Thread Volodymyr Fialko
Fix uninitialized variable access of outbound offloads flags. Coverity issue: 381669 Fixes: 6938fc92c404 ("examples/ipsec-secgw: add lookaside event mode") Signed-off-by: Volodymyr Fialko --- examples/ipsec-secgw/ipsec-secgw.c | 19 +++ examples/ipsec-secgw/ipsec.h

[PATCH v2 3/3] app/testeventdev: fix timestamp with crypto producer

2022-11-04 Thread Volodymyr Fialko
rypto producer mode") Cc: sta...@dpdk.org Signed-off-by: Volodymyr Fialko --- app/test-eventdev/test_perf_atq.c| 64 --- app/test-eventdev/test_perf_common.c | 47 +--- app/test-eventdev/test_perf_common.h | 111 +-- app/test-eventdev/test_pe

[PATCH v2 2/3] app/testeventdev: fix asymmetric last stage handling

2022-11-04 Thread Volodymyr Fialko
;) Cc: sta...@dpdk.org Signed-off-by: Volodymyr Fialko --- app/test-eventdev/test_perf_atq.c| 10 +- app/test-eventdev/test_perf_common.h | 11 +-- app/test-eventdev/test_perf_queue.c | 10 +- 3 files changed, 15 insertions(+), 16 deletions(-) diff --git a/app/tes

[PATCH v2 1/3] app/testeventdev: setup crypto adapter before sessions

2022-11-04 Thread Volodymyr Fialko
Setup crypto adapter and add queue pairs before assigning them in session metadata. Session metadata may use queue pair configuration parameters, so queue pair should be added before meta assignment. Signed-off-by: Volodymyr Fialko --- app/test-eventdev/test_perf_common.c | 16

[PATCH v2 0/3] app/testseventdev: crypto producer fixes

2022-11-04 Thread Volodymyr Fialko
This patch series address issues with crypto producer - correct setup sequence and multi stage handling with time stamp attached. v2: - Split fixes into individual patches Volodymyr Fialko (3): app/testeventdev: setup crypto adapter before sessions app/testeventdev: fix asymmetric last stage

[PATCH 2/2] app/testeventdev: resolve issues with crypto producer

2022-11-03 Thread Volodymyr Fialko
producer check for event type in `process_crypto_request` will not pass in case of multiple stages, due to overwrite of event type during event forward. Use producer type to dispatch. Signed-off-by: Volodymyr Fialko --- app/test-eventdev/test_perf_atq.c| 74 + app/test

[PATCH 1/2] app/testeventdev: setup crypto adapter before sessions

2022-11-03 Thread Volodymyr Fialko
Setup crypto adapter and add queue pairs before assigning them in session metadata. Session metadata may use queue pair configuration parameters, so queue pair should be added before meta assignment. Signed-off-by: Volodymyr Fialko --- app/test-eventdev/test_perf_common.c | 16

[PATCH 0/2] app/testseventdev: crypto producer fixes

2022-11-03 Thread Volodymyr Fialko
This patch series address issues with crypto producer - correct setup sequence and multi stage handling with time stamp attached. Volodymyr Fialko (2): app/testeventdev: setup crypto adapter before sessions app/testeventdev: resolve issues with crypto producer app/test-eventdev

[PATCH] app/testeventdev: fix limit names in error message

2022-10-31 Thread Volodymyr Fialko
Swap min and max values to match their labels. Fixes: 2eaa37b8663 ("app/eventdev: add vector mode in pipeline test") Signed-off-by: Volodymyr Fialko --- app/test-eventdev/test_pipeline_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/tes

[PATCH v3 6/6] examples/ipsec-secgw: reduce number of QP for event lookaside

2022-10-10 Thread Volodymyr Fialko
Limit number of queue pairs to one for event lookaside mode, since all cores are using same queue in this mode. Signed-off-by: Volodymyr Fialko --- examples/ipsec-secgw/ipsec-secgw.c | 56 +++--- 1 file changed, 36 insertions(+), 20 deletions(-) diff --git a/examples

[PATCH v3 5/6] examples/ipsec-secgw: add event vector support for lookaside

2022-10-10 Thread Volodymyr Fialko
Add vector support for event crypto adapter in lookaside mode. Once --event-vector enabled, event crypto adapter will group processed crypto operation into rte_event_vector event with type RTE_EVENT_TYPE_CRYPTODEV_VECTOR. Signed-off-by: Volodymyr Fialko --- doc/guides/sample_app_ug

[PATCH v3 4/6] examples/ipsec-secgw: add stats for event mode

2022-10-10 Thread Volodymyr Fialko
Add per core statistic(rx/tx) counters for event mode worker. Signed-off-by: Volodymyr Fialko --- examples/ipsec-secgw/ipsec_worker.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/examples/ipsec-secgw/ipsec_worker.c b/examples/ipsec-secgw/ipsec_worker.c index

[PATCH v3 3/6] examples/ipsec-secgw: add lookaside event mode

2022-10-10 Thread Volodymyr Fialko
Add base support for lookaside event mode. Events that are coming from ethdev will be enqueued to the event crypto adapter, processed and enqueued back to ethdev for the transmission. Signed-off-by: Volodymyr Fialko --- doc/guides/rel_notes/release_22_11.rst | 5 + doc/guides/sample_app_ug

[PATCH v3 2/6] examples/ipsec-secgw: add queue for event crypto adapter

2022-10-10 Thread Volodymyr Fialko
Add separate event queue for event crypto adapter processing, to resolve queue contention between new and already processed events. Signed-off-by: Volodymyr Fialko --- examples/ipsec-secgw/event_helper.c | 95 + examples/ipsec-secgw/event_helper.h | 2 + 2 files

[PATCH v3 0/6] examples/ipsec-secgw: add lookaside event mode

2022-10-10 Thread Volodymyr Fialko
Add support for lookaside event mode for ipsec-secgw example application. * Changes since v1 - Resolve issue with ipv6 free packet in case of error - Rebase on top of dpdk-next-crypto - Update release note * Changes since v2 - Fix compilation with old gcc Volodymyr Fialko (6): examples/ipsec

[PATCH v3 1/6] examples/ipsec-secgw: add event crypto adapter init

2022-10-10 Thread Volodymyr Fialko
Create, configure and start an event crypto adapter. This adapter will be used in lookaside event mode processing. Signed-off-by: Volodymyr Fialko --- examples/ipsec-secgw/event_helper.c | 144 examples/ipsec-secgw/event_helper.h | 2 + examples/ipsec-secgw/ipsec

[PATCH v2 6/6] examples/ipsec-secgw: reduce number of QP for event lookaside

2022-10-10 Thread Volodymyr Fialko
Limit number of queue pairs to one for event lookaside mode, since all cores are using same queue in this mode. Signed-off-by: Volodymyr Fialko --- examples/ipsec-secgw/ipsec-secgw.c | 56 +++--- 1 file changed, 36 insertions(+), 20 deletions(-) diff --git a/examples

[PATCH v2 5/6] examples/ipsec-secgw: add event vector support for lookaside

2022-10-10 Thread Volodymyr Fialko
Add vector support for event crypto adapter in lookaside mode. Once --event-vector enabled, event crypto adapter will group processed crypto operation into rte_event_vector event with type RTE_EVENT_TYPE_CRYPTODEV_VECTOR. Signed-off-by: Volodymyr Fialko --- doc/guides/sample_app_ug

[PATCH v2 4/6] examples/ipsec-secgw: add stats for event mode

2022-10-10 Thread Volodymyr Fialko
Add per core statistic(rx/tx) counters for event mode worker. Signed-off-by: Volodymyr Fialko --- examples/ipsec-secgw/ipsec_worker.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/examples/ipsec-secgw/ipsec_worker.c b/examples/ipsec-secgw/ipsec_worker.c index

[PATCH v2 3/6] examples/ipsec-secgw: add lookaside event mode

2022-10-10 Thread Volodymyr Fialko
Add base support for lookaside event mode. Events that are coming from ethdev will be enqueued to the event crypto adapter, processed and enqueued back to ethdev for the transmission. Signed-off-by: Volodymyr Fialko --- doc/guides/rel_notes/release_22_11.rst | 5 + doc/guides/sample_app_ug

[PATCH v2 2/6] examples/ipsec-secgw: add queue for event crypto adapter

2022-10-10 Thread Volodymyr Fialko
Add separate event queue for event crypto adapter processing, to resolve queue contention between new and already processed events. Signed-off-by: Volodymyr Fialko --- examples/ipsec-secgw/event_helper.c | 95 + examples/ipsec-secgw/event_helper.h | 2 + 2 files

[PATCH v2 1/6] examples/ipsec-secgw: add event crypto adapter init

2022-10-10 Thread Volodymyr Fialko
Create, configure and start an event crypto adapter. This adapter will be used in lookaside event mode processing. Signed-off-by: Volodymyr Fialko --- examples/ipsec-secgw/event_helper.c | 144 examples/ipsec-secgw/event_helper.h | 2 + examples/ipsec-secgw/ipsec

[PATCH v2 0/6] examples/ipsec-secgw: add lookaside event mode

2022-10-10 Thread Volodymyr Fialko
Add support for lookaside event mode for ipsec-secgw example application. * Changes since v1 - Resolve issue with ipv6 free packet in case of error - Rebase on top of dpdk-next-crypto - Update release note Volodymyr Fialko (6): examples/ipsec-secgw: add event crypto adapter init examples

[PATCH v3 2/2] crypto/cnxk: add vectorization for event crypto

2022-09-30 Thread Volodymyr Fialko
Add support for vector aggregation of crypto operations for cn10k. Crypto operations will be grouped by sub event type, flow id, scheduler type and queue id fields from rte_event_crypto_metadata::response_info. Signed-off-by: Volodymyr Fialko --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 398

[PATCH v3 1/2] eventdev: introduce event cryptodev vector type

2022-09-30 Thread Volodymyr Fialko
information in rte_event_crypto_metadata::response_info. Updated drivers and tests accordingly to new API. Signed-off-by: Volodymyr Fialko --- app/test-eventdev/test_perf_common.c | 11 +- app/test/test_event_crypto_adapter.c | 12 +- .../prog_guide/event_crypto_adapter.rst

[PATCH v3 0/2] Vector support for event crypto adapter

2022-09-30 Thread Volodymyr Fialko
input parameter * Changes since v2 - Rebase on top of dpdk-next-eventdev branch - Remove already merged patch Volodymyr Fialko (2): eventdev: introduce event cryptodev vector type crypto/cnxk: add vectorization for event crypto app/test-eventdev/test_perf_common.c | 11 +- app/test

RE: [PATCH 1/3] eventdev: introduce event cryptodev vector type

2022-09-27 Thread Volodymyr Fialko
> -Original Message- > From: Gujjar, Abhinandan S > Sent: Tuesday, September 27, 2022 11:05 AM > To: Volodymyr Fialko ; dev@dpdk.org; Jerin Jacob > Kollanukkaran > ; Pavan Nikhilesh Bhagavatula ; > Shijith Thotton > ; Hemant Agrawal ; Sachin Saxena > ; Jaya

[PATCH] eventdev: fix name of Rx conf type

2022-09-26 Thread Volodymyr Fialko
Rename configuration structure type to correspond definition. Fixes: dcc806c2638 ("eventdev: add eth Rx adapter API") Signed-off-by: Volodymyr Fialko --- lib/eventdev/rte_event_eth_rx_adapter.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/li

  1   2   >